New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 881669 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

V4L2SVDA: Don't continue with an invalid iterator for security consideration

Project Member Reported by johnylin@chromium.org, Sep 7

Issue description

Fix vulnerable code of checking an invalid iterator in v4l2_slice_video_decode_accelerator

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/993541aff428c4fdee4765d4c7e19f4bc499d760

commit 993541aff428c4fdee4765d4c7e19f4bc499d760
Author: Pin-chih Lin <johnylin@chromium.org>
Date: Fri Sep 07 03:43:28 2018

V4L2SVDA: Don't continue with an invalid iterator

BUG=b:112181526
BUG= 881669 
TEST=build

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ife2de572cad1a47c0e98a6b9f792cfd962af96f0
Reviewed-on: https://chromium-review.googlesource.com/1212204
Commit-Queue: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589426}
[modify] https://crrev.com/993541aff428c4fdee4765d4c7e19f4bc499d760/media/gpu/v4l2/v4l2_slice_video_decode_accelerator.cc

Labels: Merge-Request-70
Cc: -hiroh@chromium.org geohsu@chromium.org
Hi geohsu@,

this CL is requested-merge to M-70. It's a mini change to fix vulnerable code, thanks.
Cc: hiroh@chromium.org geo...@google.com
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 8

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 10

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ac691af10b4684ed11309903f869b337ec5976b

commit 9ac691af10b4684ed11309903f869b337ec5976b
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Mon Sep 10 03:41:46 2018

V4L2SVDA: Don't continue with an invalid iterator

BUG=b:112181526
BUG= 881669 
TEST=build
TBR=johnylin@chromium.org

(cherry picked from commit 993541aff428c4fdee4765d4c7e19f4bc499d760)

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ife2de572cad1a47c0e98a6b9f792cfd962af96f0
Reviewed-on: https://chromium-review.googlesource.com/1212204
Commit-Queue: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589426}
Reviewed-on: https://chromium-review.googlesource.com/1214974
Reviewed-by: Heng-ruey Hsu <henryhsu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#197}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/9ac691af10b4684ed11309903f869b337ec5976b/media/gpu/v4l2/v4l2_slice_video_decode_accelerator.cc

Status: Fixed (was: Started)
Merge back to 3538

Sign in to add a comment