Switch Android Messages URL to prod endpoint |
||||||||||
Issue descriptionRight now, we're hardcoded to point to the sandbox url for dogfooding. We need to switch this to prod before launch. It might be the safest move to actually gate this on a finch flag so that we could flip is independently of the binary rollout. The problem with switching it to prod right now for all dogfooders is that the Messages Web experiments won't actually propagate on prod and so we won't be able to install or use the PWA correctly until those flags roll out more broadly. We'll need to stay on sandbox until that happens (which we're rushing to do).
,
Sep 11
,
Sep 11
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d8f9b2ef644e34fb3967069df412f83ebe5734d commit 8d8f9b2ef644e34fb3967069df412f83ebe5734d Author: Jeremy Klein <jlklein@google.com> Date: Thu Sep 13 21:48:57 2018 Use prod Android Messages URL instead of staging. This change adds a new flag which, if true, points Android Messages ChromeOS integration to the prod Messages for Web endpoint rather than the sandbox URL which is being used for staging. This flag is off by default to continue to allow dogfood until all our web experiments have rolled out to production. Bug: 881664 Change-Id: I4e84a19d2a9fb84972889e42644f6fe8d4464389 Reviewed-on: https://chromium-review.googlesource.com/1222880 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Reviewed-by: Jeremy Klein <jlklein@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#591172} [modify] https://crrev.com/8d8f9b2ef644e34fb3967069df412f83ebe5734d/chrome/browser/about_flags.cc [modify] https://crrev.com/8d8f9b2ef644e34fb3967069df412f83ebe5734d/chrome/browser/chromeos/android_sms/BUILD.gn [modify] https://crrev.com/8d8f9b2ef644e34fb3967069df412f83ebe5734d/chrome/browser/chromeos/android_sms/android_sms_urls.cc [modify] https://crrev.com/8d8f9b2ef644e34fb3967069df412f83ebe5734d/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/8d8f9b2ef644e34fb3967069df412f83ebe5734d/chrome/browser/flag_descriptions.h [modify] https://crrev.com/8d8f9b2ef644e34fb3967069df412f83ebe5734d/chromeos/chromeos_features.cc [modify] https://crrev.com/8d8f9b2ef644e34fb3967069df412f83ebe5734d/chromeos/chromeos_features.h [modify] https://crrev.com/8d8f9b2ef644e34fb3967069df412f83ebe5734d/tools/metrics/histograms/enums.xml
,
Sep 13
We'll have to remember to flip this flag to true when we roll out our other flags, but the work here is done.
,
Oct 9
Reopening because we'll be able to flip this to true by default and then can remove the flag entirely in a follow-up.
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f44369a64f1e39efcd389d6dc552d74be97e75f4 commit f44369a64f1e39efcd389d6dc552d74be97e75f4 Author: Jeremy Klein <jlklein@google.com> Date: Wed Oct 10 00:29:41 2018 Remove unneeded url params from android sms url. The experiment flags are fully ramped up on staging and don't work on prod anyway. Bug: 881664 Change-Id: Ibc25a68e2789a9787e4f6304f7cb8fa61dfd0dff Reviewed-on: https://chromium-review.googlesource.com/c/1272161 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#598145} [modify] https://crrev.com/f44369a64f1e39efcd389d6dc552d74be97e75f4/chrome/browser/chromeos/android_sms/android_sms_urls.cc
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbe547af1bca45c9bd728d90c1e6685fc314f001 commit bbe547af1bca45c9bd728d90c1e6685fc314f001 Author: Jeremy Klein <jlklein@google.com> Date: Tue Oct 16 00:23:04 2018 Switch Android SMS to prod endpoint by default Bug: 881664 Change-Id: If8bc6ea2368c32a4a76d474ed625a0db5da0492d Reviewed-on: https://chromium-review.googlesource.com/c/1279426 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#599792} [modify] https://crrev.com/bbe547af1bca45c9bd728d90c1e6685fc314f001/chromeos/chromeos_features.cc
,
Oct 16
,
Oct 17
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa5f794f71a0b472ffda322d13d54c2f684994f1 commit aa5f794f71a0b472ffda322d13d54c2f684994f1 Author: Jeremy Klein <jlklein@google.com> Date: Wed Oct 17 15:54:39 2018 Switch Android SMS to prod endpoint by default Bug: 881664 Change-Id: If8bc6ea2368c32a4a76d474ed625a0db5da0492d Reviewed-on: https://chromium-review.googlesource.com/c/1279426 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599792}(cherry picked from commit bbe547af1bca45c9bd728d90c1e6685fc314f001) Reviewed-on: https://chromium-review.googlesource.com/c/1286874 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#85} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/aa5f794f71a0b472ffda322d13d54c2f684994f1/chromeos/chromeos_features.cc
,
Oct 17
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa5f794f71a0b472ffda322d13d54c2f684994f1 Commit: aa5f794f71a0b472ffda322d13d54c2f684994f1 Author: jlklein@google.com Commiter: jlklein@chromium.org Date: 2018-10-17 15:54:39 +0000 UTC Switch Android SMS to prod endpoint by default Bug: 881664 Change-Id: If8bc6ea2368c32a4a76d474ed625a0db5da0492d Reviewed-on: https://chromium-review.googlesource.com/c/1279426 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599792}(cherry picked from commit bbe547af1bca45c9bd728d90c1e6685fc314f001) Reviewed-on: https://chromium-review.googlesource.com/c/1286874 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#85} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by khorimoto@chromium.org
, Sep 11