[📍] Bisect did not detect a regression that it should have. |
||
Issue descriptionhttps://pinpoint-dot-chromeperf.appspot.com/job/10c6fff5640000 There should be a regression found on the right side of the chart. Digging into this, I found a bug in the code that calculates the IQR to estimate the noise level. If index is a round number, this function returns 0. def _Percentile(values, percentile): """Returns a percentile of a sorted list of values.""" index = (len(values) - 1) * percentile floor = math.floor(index) ceil = math.ceil(index) low = values[int(floor)] * (ceil - index) high = values[int(ceil)] * (index - floor) return low + high
,
Sep 7
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/957876a8e78e1d6e618926c56ff8d593a80065a9 commit 957876a8e78e1d6e618926c56ff8d593a80065a9 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Sep 07 22:34:05 2018 Roll src/third_party/catapult febcf8764dc1..ead23c2a266c (1 commits) https://chromium.googlesource.com/catapult.git/+log/febcf8764dc1..ead23c2a266c git log febcf8764dc1..ead23c2a266c --date=short --no-merges --format='%ad %ae %s' 2018-09-07 dtu@chromium.org [pinpoint] Fix edge case in _Percentile(). Created with: gclient setdep -r src/third_party/catapult@ead23c2a266c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:881661 TBR=sullivan@chromium.org Change-Id: I4cfde01f46b232a9328c49a03ae33a75537be9a7 Reviewed-on: https://chromium-review.googlesource.com/1214283 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589694} [modify] https://crrev.com/957876a8e78e1d6e618926c56ff8d593a80065a9/DEPS |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Sep 7