New issue
Advanced search Search tips

Issue 881650 link

Starred by 1 user
Status: Fixed
Owner:
ma...@chromium.org
Closed: Sep 7
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Translate] Send Variations Headers when fetching translate script

Project Member Reported by ma...@chromium.org, Sep 7 
Title explains all. It is currently not hooked up to send experiment headers.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7aee07900b9396b88a8dc33ac1ed22a8993d55f9

commit 7aee07900b9396b88a8dc33ac1ed22a8993d55f9
Author: Mathieu Perreault <mathp@chromium.org>
Date: Fri Sep 07 02:45:12 2018

[Translate] Add Variations Headers to the request for the translate script

Bug:  881650 
Test: Run chrome with --force-variations-ids=12345, look for the headers in the
request to translate in chrome://net-internals

Change-Id: I51cc33d4d7b0cf9d6a74a433b277f0890b990b01
Reviewed-on: https://chromium-review.googlesource.com/1212403
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589416}
[modify] https://crrev.com/7aee07900b9396b88a8dc33ac1ed22a8993d55f9/components/translate/core/browser/BUILD.gn
[modify] https://crrev.com/7aee07900b9396b88a8dc33ac1ed22a8993d55f9/components/translate/core/browser/translate_language_list.cc
[modify] https://crrev.com/7aee07900b9396b88a8dc33ac1ed22a8993d55f9/components/translate/core/browser/translate_manager.cc
[modify] https://crrev.com/7aee07900b9396b88a8dc33ac1ed22a8993d55f9/components/translate/core/browser/translate_script.cc
[modify] https://crrev.com/7aee07900b9396b88a8dc33ac1ed22a8993d55f9/components/translate/core/browser/translate_script.h
[modify] https://crrev.com/7aee07900b9396b88a8dc33ac1ed22a8993d55f9/components/translate/core/browser/translate_script_unittest.cc
[modify] https://crrev.com/7aee07900b9396b88a8dc33ac1ed22a8993d55f9/components/translate/core/browser/translate_url_fetcher.cc
[modify] https://crrev.com/7aee07900b9396b88a8dc33ac1ed22a8993d55f9/components/translate/core/browser/translate_url_fetcher.h

Comment 2 by ma...@chromium.org, Sep 7

Status: Fixed (was: Started)

Comment 3 by ma...@chromium.org, Sep 7

Labels: -M-71 Merge-Request-70 M-70
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 8

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 8

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c5348112cec359f7a0fbdcf4b4eb35c2f1e0e6f

commit 7c5348112cec359f7a0fbdcf4b4eb35c2f1e0e6f
Author: Mathieu Perreault <mathp@chromium.org>
Date: Sat Sep 08 17:38:44 2018

[Translate] Add Variations Headers to the request for the translate script

Bug:  881650 
Test: Run chrome with --force-variations-ids=12345, look for the headers in the
request to translate in chrome://net-internals

Change-Id: I51cc33d4d7b0cf9d6a74a433b277f0890b990b01
Reviewed-on: https://chromium-review.googlesource.com/1212403
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589416}(cherry picked from commit 7aee07900b9396b88a8dc33ac1ed22a8993d55f9)
Reviewed-on: https://chromium-review.googlesource.com/1214925
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#189}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/7c5348112cec359f7a0fbdcf4b4eb35c2f1e0e6f/components/translate/core/browser/BUILD.gn
[modify] https://crrev.com/7c5348112cec359f7a0fbdcf4b4eb35c2f1e0e6f/components/translate/core/browser/translate_language_list.cc
[modify] https://crrev.com/7c5348112cec359f7a0fbdcf4b4eb35c2f1e0e6f/components/translate/core/browser/translate_manager.cc
[modify] https://crrev.com/7c5348112cec359f7a0fbdcf4b4eb35c2f1e0e6f/components/translate/core/browser/translate_script.cc
[modify] https://crrev.com/7c5348112cec359f7a0fbdcf4b4eb35c2f1e0e6f/components/translate/core/browser/translate_script.h
[modify] https://crrev.com/7c5348112cec359f7a0fbdcf4b4eb35c2f1e0e6f/components/translate/core/browser/translate_script_unittest.cc
[modify] https://crrev.com/7c5348112cec359f7a0fbdcf4b4eb35c2f1e0e6f/components/translate/core/browser/translate_url_fetcher.cc
[modify] https://crrev.com/7c5348112cec359f7a0fbdcf4b4eb35c2f1e0e6f/components/translate/core/browser/translate_url_fetcher.h
►

Sign in to add a comment