New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 881630 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 880649



Sign in to add a comment

[Findit] Flake detection: make show_flake page more concise

Project Member Reported by chanli@chromium.org, Sep 7

Issue description

Make show_flake page more concise by reducing redundant information.

Currently the show_flake page looks like https://17452-b480670-tainted-chanli-dot-findit-for-me-staging.appspot.com/flake/detection/show-flake?key=ahdzfmZpbmRpdC1mb3ItbWUtc3RhZ2luZ3JyCxIFRmxha2UiZ2Nocm9taXVtQHdlYmtpdF9sYXlvdXRfdGVzdHNAdmlydHVhbC91c2VyLWFjdGl2YXRpb24tdjIvZmFzdC9ldmVudHMvbWlkZGxlQ2xpY2tBdXRvc2Nyb2xsLWxhdGNoaW5nLmh0bWwM

We can try to reduce the redundant information by grouping the occurrences by the same builder/step_name/test_name, etc.


 
In the preliminary version, we agree to group the occurrences by the builder first.

And we can work on other grouping criteria after that,
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/77696cce0900a9c03c57dcf50d6d8d36f8497ec7

commit 77696cce0900a9c03c57dcf50d6d8d36f8497ec7
Author: Chan <chanli@chromium.org>
Date: Wed Sep 12 20:27:05 2018

[Findit] Polish show-flake page

Polish the exisiting show-flake page:
1. Group the occurrences by builder
  1.1 Sort the groups by the time of the most recent occurrence, in descending order
  1.2 Only display orrurrences that happened within a week
  1.3 Sort the occurrences in the group by the time of occurrence, in descending order
  1.4 Cap the number of displayed orrurrences in each group, add scrollbar for more occurrences
2. For each occurrence, shorted the long test names and add tooltip for test names

Design: https://docs.google.com/document/d/11KB8EunJj8U7ZUTbzh_qQw31g9GRsTgJydvrHaIibhE/edit#heading=h.6d500vevyf0d

Bug:  881630 
Change-Id: Ica15df87fcfef7cdd9a9d35a6debe1169c9caa5f
Reviewed-on: https://chromium-review.googlesource.com/1220193
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17540}
[add] https://crrev.com/77696cce0900a9c03c57dcf50d6d8d36f8497ec7/appengine/findit/ui/elements/flake_detection/grouped-occurrences.html
[modify] https://crrev.com/77696cce0900a9c03c57dcf50d6d8d36f8497ec7/appengine/findit/ui/elements/flake_detection/flake-occurrence.html
[modify] https://crrev.com/77696cce0900a9c03c57dcf50d6d8d36f8497ec7/appengine/findit/frontend_main.py
[modify] https://crrev.com/77696cce0900a9c03c57dcf50d6d8d36f8497ec7/appengine/findit/handlers/flake/detection/flake_detection_utils.py
[modify] https://crrev.com/77696cce0900a9c03c57dcf50d6d8d36f8497ec7/appengine/findit/ui/elements/flake_detection/flake.html
[modify] https://crrev.com/77696cce0900a9c03c57dcf50d6d8d36f8497ec7/appengine/findit/handlers/flake/detection/test/show_flake_test.py
[modify] https://crrev.com/77696cce0900a9c03c57dcf50d6d8d36f8497ec7/appengine/findit/handlers/flake/detection/test/flake_detection_utils_test.py

Status: Fixed (was: Assigned)

Sign in to add a comment