New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 881620 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 880910

Blocking:
issue 880649



Sign in to add a comment

[Findit] Flake Detection: display weekly ranked flakes

Project Member Reported by chanli@chromium.org, Sep 6

Issue description

Create a dashboard to rank flakes by occurrence count within a week.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/33e77d13e54b10dab09894b7f90393c72ca353b5

commit 33e77d13e54b10dab09894b7f90393c72ca353b5
Author: Chan <chanli@chromium.org>
Date: Sat Sep 15 04:30:23 2018

[Findit] Fix paging issue with ranked flakes page.

Before we only rank flakes by false_rejection_count_last_week, but if there are entries with the same false_rejection_count_last_week, the paging may act weirdly and if users click next then previous they may not get the same page. Add last_occurred_time as the secondary field for ordering to fix the issue.

Bug:  881620 
Change-Id: I59165b725b5ffd10a228cb55203f8e3898d6f96b
Reviewed-on: https://chromium-review.googlesource.com/1227418
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17630}
[modify] https://crrev.com/33e77d13e54b10dab09894b7f90393c72ca353b5/appengine/findit/handlers/flake/list_flakes.py
[modify] https://crrev.com/33e77d13e54b10dab09894b7f90393c72ca353b5/appengine/predator/scripts/delta_test/delta_test.py
[modify] https://crrev.com/33e77d13e54b10dab09894b7f90393c72ca353b5/appengine/findit/gae_libs/dashboard_util.py
[modify] https://crrev.com/33e77d13e54b10dab09894b7f90393c72ca353b5/appengine/findit/index.yaml
[modify] https://crrev.com/33e77d13e54b10dab09894b7f90393c72ca353b5/appengine/findit/handlers/flake/detection/rank_flakes.py
[modify] https://crrev.com/33e77d13e54b10dab09894b7f90393c72ca353b5/appengine/findit/handlers/flake/test/list_flakes_test.py
[modify] https://crrev.com/33e77d13e54b10dab09894b7f90393c72ca353b5/appengine/predator/app/frontend/handlers/dashboard.py
[modify] https://crrev.com/33e77d13e54b10dab09894b7f90393c72ca353b5/appengine/findit/gae_libs/test/dashboard_util_test.py

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/761a3c57bdefb53d1aa5beda071a54caa68505cb

commit 761a3c57bdefb53d1aa5beda071a54caa68505cb
Author: Chan <chanli@chromium.org>
Date: Thu Sep 20 00:15:20 2018

[Findit] Flake Detection UI: add normalized_step_name and test_label_name to order_properties

The paging for ranked flakes dashboard still had issues because the last_occurred_time of flakes are still likely to be the same.

Add normalized_step_name and test_label_name to order_properties as well to ensure the entities can be ordered in a unique way.

Bug:  881620 
Change-Id: Ida067dab99f5ee961712bdda957a0f74dac1b47b
Reviewed-on: https://chromium-review.googlesource.com/1234838
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17748}
[modify] https://crrev.com/761a3c57bdefb53d1aa5beda071a54caa68505cb/appengine/findit/handlers/flake/list_flakes.py
[modify] https://crrev.com/761a3c57bdefb53d1aa5beda071a54caa68505cb/appengine/findit/gae_libs/dashboard_util.py
[modify] https://crrev.com/761a3c57bdefb53d1aa5beda071a54caa68505cb/appengine/findit/index.yaml
[modify] https://crrev.com/761a3c57bdefb53d1aa5beda071a54caa68505cb/appengine/findit/handlers/flake/detection/rank_flakes.py
[modify] https://crrev.com/761a3c57bdefb53d1aa5beda071a54caa68505cb/appengine/findit/handlers/flake/test/list_flakes_test.py
[modify] https://crrev.com/761a3c57bdefb53d1aa5beda071a54caa68505cb/appengine/predator/app/frontend/handlers/dashboard.py
[modify] https://crrev.com/761a3c57bdefb53d1aa5beda071a54caa68505cb/appengine/findit/gae_libs/test/dashboard_util_test.py

Sign in to add a comment