New issue
Advanced search Search tips

Issue 881618 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Fling a browser on the caption area does not always have the correct result

Project Member Reported by x...@chromium.org, Sep 6

Issue description

Chrome Version: (copy from chrome://version)
OS: Chrome

What steps will reproduce the problem?
(1) Open at least 2 windows in tablet mode, at least 1 of them is browser window
(2) Enter splitview mode.
(3) Press on the caption area of the browser window to drag a small distance, and then fling to left side of the screen

What is the expected result?
The browser window should be snapped to left, while the other windows should open in overview

What happens instead?
Sometimes (not always, depending on the fling event velocity), the browser window was snapped to left, but the window that was previously snapped to left still stays in left side of the screen. See the attached video.


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
Sep 6, 2018 4_09 PM - Edited.webm
955 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46f0e45b394d0107a4774e8ed2cf78b71e3aeb2b

commit 46f0e45b394d0107a4774e8ed2cf78b71e3aeb2b
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Fri Sep 07 17:41:10 2018

Fix the fling event behavior for browser window.

Currently there is no fling event for browser window in tablet mode.
We'll add fling event handling for browser window in tablet mode later.

Bug:  881618 
Change-Id: I683458455449fb2fe8e903e503c49072c917dc2f
Reviewed-on: https://chromium-review.googlesource.com/1212084
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589571}
[modify] https://crrev.com/46f0e45b394d0107a4774e8ed2cf78b71e3aeb2b/ash/wm/wm_toplevel_window_event_handler.cc

Labels: Merge-Request-70
Status: Fixed (was: Assigned)
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 8

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 12

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 17

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 17

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1835369010e8532b755a9c08d2c95ce597884c33

commit 1835369010e8532b755a9c08d2c95ce597884c33
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Mon Sep 17 19:56:32 2018

[Merge to M70] Fix the fling event behavior for browser window.

Currently there is no fling event for browser window in tablet mode.
We'll add fling event handling for browser window in tablet mode later.

Bug:  881618 
TBR=xiyuan@chromium.org

Change-Id: I683458455449fb2fe8e903e503c49072c917dc2f
Reviewed-on: https://chromium-review.googlesource.com/1212084
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589571}(cherry picked from commit 46f0e45b394d0107a4774e8ed2cf78b71e3aeb2b)
Reviewed-on: https://chromium-review.googlesource.com/1228937
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#456}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/1835369010e8532b755a9c08d2c95ce597884c33/ash/wm/wm_toplevel_window_event_handler.cc

Sign in to add a comment