UI for attempting to update termina while offline |
|||||||
Issue descriptionIf the user is offline and requires a termina update for Crostini to work, we should show them a message when they try to launch any Crostini apps.
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc9185c627f678ff37431b6e9e112f72cabe0f4d commit bc9185c627f678ff37431b6e9e112f72cabe0f4d Author: Nicholas Verne <nverne@chromium.org> Date: Thu Sep 13 06:16:01 2018 Creates a new dialog for Crostini Upgrade. If the user's cros-termina component is incompatible with the current version of Chrome and must be upgraded, but the user is offline, we show this dialog asking the user to go online and try again. This happens when they attempt to launch any crostini app (e.g. the terminal). Testing the dialog showed a bug in which the spinner for Terminal was not dismissed if the CrostiniRestart failed before the standard spinner delay. This has been fixed in the current CL. Also added testing code to configure the component updater in browser tests so we can simulate the circumstances leading to the dialog being shown. Bug: 881616 Change-Id: I1007a3bd2c34c8403ab80335063072c4995d5bff Reviewed-on: https://chromium-review.googlesource.com/1218264 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#590937} [modify] https://crrev.com/bc9185c627f678ff37431b6e9e112f72cabe0f4d/chrome/browser/chromeos/crostini/crostini_manager.cc [modify] https://crrev.com/bc9185c627f678ff37431b6e9e112f72cabe0f4d/chrome/browser/chromeos/crostini/crostini_manager.h [modify] https://crrev.com/bc9185c627f678ff37431b6e9e112f72cabe0f4d/chrome/browser/chromeos/crostini/crostini_manager_unittest.cc [modify] https://crrev.com/bc9185c627f678ff37431b6e9e112f72cabe0f4d/chrome/browser/chromeos/crostini/crostini_remover.cc [modify] https://crrev.com/bc9185c627f678ff37431b6e9e112f72cabe0f4d/chrome/browser/chromeos/crostini/crostini_remover.h [modify] https://crrev.com/bc9185c627f678ff37431b6e9e112f72cabe0f4d/chrome/browser/chromeos/crostini/crostini_util.cc [modify] https://crrev.com/bc9185c627f678ff37431b6e9e112f72cabe0f4d/chrome/browser/chromeos/crostini/crostini_util.h [modify] https://crrev.com/bc9185c627f678ff37431b6e9e112f72cabe0f4d/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/bc9185c627f678ff37431b6e9e112f72cabe0f4d/chrome/browser/ui/browser_dialogs.h [modify] https://crrev.com/bc9185c627f678ff37431b6e9e112f72cabe0f4d/chrome/browser/ui/views/crostini/crostini_browser_test_util.cc [modify] https://crrev.com/bc9185c627f678ff37431b6e9e112f72cabe0f4d/chrome/browser/ui/views/crostini/crostini_browser_test_util.h [add] https://crrev.com/bc9185c627f678ff37431b6e9e112f72cabe0f4d/chrome/browser/ui/views/crostini/crostini_upgrade_view.cc [add] https://crrev.com/bc9185c627f678ff37431b6e9e112f72cabe0f4d/chrome/browser/ui/views/crostini/crostini_upgrade_view.h [add] https://crrev.com/bc9185c627f678ff37431b6e9e112f72cabe0f4d/chrome/browser/ui/views/crostini/crostini_upgrade_view_browsertest.cc [modify] https://crrev.com/bc9185c627f678ff37431b6e9e112f72cabe0f4d/chrome/test/BUILD.gn [modify] https://crrev.com/bc9185c627f678ff37431b6e9e112f72cabe0f4d/tools/metrics/histograms/histograms.xml
,
Sep 13
,
Sep 14
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 24
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2c302e96e6dadfa26cd09a3985105db00f43d21 commit e2c302e96e6dadfa26cd09a3985105db00f43d21 Author: Nicholas Verne <nverne@chromium.org> Date: Wed Sep 26 01:19:55 2018 Creates a new dialog for Crostini Upgrade. If the user's cros-termina component is incompatible with the current version of Chrome and must be upgraded, but the user is offline, we show this dialog asking the user to go online and try again. This happens when they attempt to launch any crostini app (e.g. the terminal). Testing the dialog showed a bug in which the spinner for Terminal was not dismissed if the CrostiniRestart failed before the standard spinner delay. This has been fixed in the current CL. Also added testing code to configure the component updater in browser tests so we can simulate the circumstances leading to the dialog being shown. TBR=nverne@chromium.org (cherry picked from commit bc9185c627f678ff37431b6e9e112f72cabe0f4d) Bug: 881616 Change-Id: I1007a3bd2c34c8403ab80335063072c4995d5bff Reviewed-on: https://chromium-review.googlesource.com/1218264 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#590937} Reviewed-on: https://chromium-review.googlesource.com/1244177 Reviewed-by: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#676} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/e2c302e96e6dadfa26cd09a3985105db00f43d21/chrome/browser/chromeos/crostini/crostini_manager.cc [modify] https://crrev.com/e2c302e96e6dadfa26cd09a3985105db00f43d21/chrome/browser/chromeos/crostini/crostini_manager.h [modify] https://crrev.com/e2c302e96e6dadfa26cd09a3985105db00f43d21/chrome/browser/chromeos/crostini/crostini_manager_unittest.cc [modify] https://crrev.com/e2c302e96e6dadfa26cd09a3985105db00f43d21/chrome/browser/chromeos/crostini/crostini_remover.cc [modify] https://crrev.com/e2c302e96e6dadfa26cd09a3985105db00f43d21/chrome/browser/chromeos/crostini/crostini_remover.h [modify] https://crrev.com/e2c302e96e6dadfa26cd09a3985105db00f43d21/chrome/browser/chromeos/crostini/crostini_util.cc [modify] https://crrev.com/e2c302e96e6dadfa26cd09a3985105db00f43d21/chrome/browser/chromeos/crostini/crostini_util.h [modify] https://crrev.com/e2c302e96e6dadfa26cd09a3985105db00f43d21/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/e2c302e96e6dadfa26cd09a3985105db00f43d21/chrome/browser/ui/browser_dialogs.h [modify] https://crrev.com/e2c302e96e6dadfa26cd09a3985105db00f43d21/chrome/browser/ui/views/crostini/crostini_browser_test_util.cc [modify] https://crrev.com/e2c302e96e6dadfa26cd09a3985105db00f43d21/chrome/browser/ui/views/crostini/crostini_browser_test_util.h [add] https://crrev.com/e2c302e96e6dadfa26cd09a3985105db00f43d21/chrome/browser/ui/views/crostini/crostini_upgrade_view.cc [add] https://crrev.com/e2c302e96e6dadfa26cd09a3985105db00f43d21/chrome/browser/ui/views/crostini/crostini_upgrade_view.h [add] https://crrev.com/e2c302e96e6dadfa26cd09a3985105db00f43d21/chrome/browser/ui/views/crostini/crostini_upgrade_view_browsertest.cc [modify] https://crrev.com/e2c302e96e6dadfa26cd09a3985105db00f43d21/chrome/test/BUILD.gn [modify] https://crrev.com/e2c302e96e6dadfa26cd09a3985105db00f43d21/tools/metrics/histograms/histograms.xml
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2c302e96e6dadfa26cd09a3985105db00f43d21 Commit: e2c302e96e6dadfa26cd09a3985105db00f43d21 Author: nverne@chromium.org Commiter: nverne@chromium.org Date: 2018-09-26 01:19:55 +0000 UTC Creates a new dialog for Crostini Upgrade. If the user's cros-termina component is incompatible with the current version of Chrome and must be upgraded, but the user is offline, we show this dialog asking the user to go online and try again. This happens when they attempt to launch any crostini app (e.g. the terminal). Testing the dialog showed a bug in which the spinner for Terminal was not dismissed if the CrostiniRestart failed before the standard spinner delay. This has been fixed in the current CL. Also added testing code to configure the component updater in browser tests so we can simulate the circumstances leading to the dialog being shown. TBR=nverne@chromium.org (cherry picked from commit bc9185c627f678ff37431b6e9e112f72cabe0f4d) Bug: 881616 Change-Id: I1007a3bd2c34c8403ab80335063072c4995d5bff Reviewed-on: https://chromium-review.googlesource.com/1218264 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#590937} Reviewed-on: https://chromium-review.googlesource.com/1244177 Reviewed-by: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#676} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6d4e59b5cb1316e3371b47690bc03d327969046 commit c6d4e59b5cb1316e3371b47690bc03d327969046 Author: Nicholas Verne <nverne@chromium.org> Date: Thu Sep 27 03:55:59 2018 Revert "Creates a new dialog for Crostini Upgrade." This reverts commit e2c302e96e6dadfa26cd09a3985105db00f43d21. Reason for revert: <INSERT REASONING HERE> Original change's description: > Creates a new dialog for Crostini Upgrade. > > If the user's cros-termina component is incompatible with the current version > of Chrome and must be upgraded, but the user is offline, we show this dialog > asking the user to go online and try again. This happens when they attempt to > launch any crostini app (e.g. the terminal). Testing the dialog showed a bug > in which the spinner for Terminal was not dismissed if the CrostiniRestart > failed before the standard spinner delay. This has been fixed in the current > CL. > > Also added testing code to configure the component updater in browser tests so > we can simulate the circumstances leading to the dialog being shown. > > TBR=nverne@chromium.org > > (cherry picked from commit bc9185c627f678ff37431b6e9e112f72cabe0f4d) > > Bug: 881616 > Change-Id: I1007a3bd2c34c8403ab80335063072c4995d5bff > Reviewed-on: https://chromium-review.googlesource.com/1218264 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Reviewed-by: Timothy Loh <timloh@chromium.org> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#590937} > Reviewed-on: https://chromium-review.googlesource.com/1244177 > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/branch-heads/3538@{#676} > Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} TBR=tapted@chromium.org,isherman@chromium.org,timloh@chromium.org,nverne@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 881616 Change-Id: I7103a1695b322de83551a21ed35d065892d2ef9c Reviewed-on: https://chromium-review.googlesource.com/1248070 Reviewed-by: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#700} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/c6d4e59b5cb1316e3371b47690bc03d327969046/chrome/browser/chromeos/crostini/crostini_manager.cc [modify] https://crrev.com/c6d4e59b5cb1316e3371b47690bc03d327969046/chrome/browser/chromeos/crostini/crostini_manager.h [modify] https://crrev.com/c6d4e59b5cb1316e3371b47690bc03d327969046/chrome/browser/chromeos/crostini/crostini_manager_unittest.cc [modify] https://crrev.com/c6d4e59b5cb1316e3371b47690bc03d327969046/chrome/browser/chromeos/crostini/crostini_remover.cc [modify] https://crrev.com/c6d4e59b5cb1316e3371b47690bc03d327969046/chrome/browser/chromeos/crostini/crostini_remover.h [modify] https://crrev.com/c6d4e59b5cb1316e3371b47690bc03d327969046/chrome/browser/chromeos/crostini/crostini_util.cc [modify] https://crrev.com/c6d4e59b5cb1316e3371b47690bc03d327969046/chrome/browser/chromeos/crostini/crostini_util.h [modify] https://crrev.com/c6d4e59b5cb1316e3371b47690bc03d327969046/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/c6d4e59b5cb1316e3371b47690bc03d327969046/chrome/browser/ui/browser_dialogs.h [modify] https://crrev.com/c6d4e59b5cb1316e3371b47690bc03d327969046/chrome/browser/ui/views/crostini/crostini_browser_test_util.cc [modify] https://crrev.com/c6d4e59b5cb1316e3371b47690bc03d327969046/chrome/browser/ui/views/crostini/crostini_browser_test_util.h [delete] https://crrev.com/539ab45b55a7ba714f9f969d020a0cff79fc85fc/chrome/browser/ui/views/crostini/crostini_upgrade_view.cc [delete] https://crrev.com/539ab45b55a7ba714f9f969d020a0cff79fc85fc/chrome/browser/ui/views/crostini/crostini_upgrade_view.h [delete] https://crrev.com/539ab45b55a7ba714f9f969d020a0cff79fc85fc/chrome/browser/ui/views/crostini/crostini_upgrade_view_browsertest.cc [modify] https://crrev.com/c6d4e59b5cb1316e3371b47690bc03d327969046/chrome/test/BUILD.gn [modify] https://crrev.com/c6d4e59b5cb1316e3371b47690bc03d327969046/tools/metrics/histograms/histograms.xml
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6d4e59b5cb1316e3371b47690bc03d327969046 Commit: c6d4e59b5cb1316e3371b47690bc03d327969046 Author: nverne@chromium.org Commiter: nverne@chromium.org Date: 2018-09-27 03:55:59 +0000 UTC Revert "Creates a new dialog for Crostini Upgrade." This reverts commit e2c302e96e6dadfa26cd09a3985105db00f43d21. Reason for revert: <INSERT REASONING HERE> Original change's description: > Creates a new dialog for Crostini Upgrade. > > If the user's cros-termina component is incompatible with the current version > of Chrome and must be upgraded, but the user is offline, we show this dialog > asking the user to go online and try again. This happens when they attempt to > launch any crostini app (e.g. the terminal). Testing the dialog showed a bug > in which the spinner for Terminal was not dismissed if the CrostiniRestart > failed before the standard spinner delay. This has been fixed in the current > CL. > > Also added testing code to configure the component updater in browser tests so > we can simulate the circumstances leading to the dialog being shown. > > TBR=nverne@chromium.org > > (cherry picked from commit bc9185c627f678ff37431b6e9e112f72cabe0f4d) > > Bug: 881616 > Change-Id: I1007a3bd2c34c8403ab80335063072c4995d5bff > Reviewed-on: https://chromium-review.googlesource.com/1218264 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Reviewed-by: Timothy Loh <timloh@chromium.org> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#590937} > Reviewed-on: https://chromium-review.googlesource.com/1244177 > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/branch-heads/3538@{#676} > Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} TBR=tapted@chromium.org,isherman@chromium.org,timloh@chromium.org,nverne@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 881616 Change-Id: I7103a1695b322de83551a21ed35d065892d2ef9c Reviewed-on: https://chromium-review.googlesource.com/1248070 Reviewed-by: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#700} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91040634e5a739820c470371c1d1386a7cd750a6 commit 91040634e5a739820c470371c1d1386a7cd750a6 Author: Nicholas Verne <nverne@chromium.org> Date: Thu Sep 27 05:48:41 2018 Merge Crostini Upgrade dialog into M70. Note, this required coding to the pre-"CrostiniManager as a KeyedService" world. Old description follows, and it still applies: Creates a new dialog for Crostini Upgrade. If the user's cros-termina component is incompatible with the current version of Chrome and must be upgraded, but the user is offline, we show this dialog asking the user to go online and try again. This happens when they attempt to launch any crostini app (e.g. the terminal). Testing the dialog showed a bug in which the spinner for Terminal was not dismissed if the CrostiniRestart failed before the standard spinner delay. This has been fixed in the current CL. Also added testing code to configure the component updater in browser tests so we can simulate the circumstances leading to the dialog being shown. (cherry picked from commit bc9185c627f678ff37431b6e9e112f72cabe0f4d) Bug: 881616 Change-Id: Id1521e66c8ab9fb94b8ec4fe4334ee58616ebe03 Reviewed-on: https://chromium-review.googlesource.com/1248461 Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#701} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/91040634e5a739820c470371c1d1386a7cd750a6/chrome/browser/chromeos/crostini/crostini_manager.cc [modify] https://crrev.com/91040634e5a739820c470371c1d1386a7cd750a6/chrome/browser/chromeos/crostini/crostini_manager.h [modify] https://crrev.com/91040634e5a739820c470371c1d1386a7cd750a6/chrome/browser/chromeos/crostini/crostini_manager_unittest.cc [modify] https://crrev.com/91040634e5a739820c470371c1d1386a7cd750a6/chrome/browser/chromeos/crostini/crostini_remover.cc [modify] https://crrev.com/91040634e5a739820c470371c1d1386a7cd750a6/chrome/browser/chromeos/crostini/crostini_remover.h [modify] https://crrev.com/91040634e5a739820c470371c1d1386a7cd750a6/chrome/browser/chromeos/crostini/crostini_util.cc [modify] https://crrev.com/91040634e5a739820c470371c1d1386a7cd750a6/chrome/browser/chromeos/crostini/crostini_util.h [modify] https://crrev.com/91040634e5a739820c470371c1d1386a7cd750a6/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/91040634e5a739820c470371c1d1386a7cd750a6/chrome/browser/ui/browser_dialogs.h [modify] https://crrev.com/91040634e5a739820c470371c1d1386a7cd750a6/chrome/browser/ui/views/crostini/crostini_browser_test_util.cc [modify] https://crrev.com/91040634e5a739820c470371c1d1386a7cd750a6/chrome/browser/ui/views/crostini/crostini_browser_test_util.h [add] https://crrev.com/91040634e5a739820c470371c1d1386a7cd750a6/chrome/browser/ui/views/crostini/crostini_upgrade_view.cc [add] https://crrev.com/91040634e5a739820c470371c1d1386a7cd750a6/chrome/browser/ui/views/crostini/crostini_upgrade_view.h [add] https://crrev.com/91040634e5a739820c470371c1d1386a7cd750a6/chrome/browser/ui/views/crostini/crostini_upgrade_view_browsertest.cc [modify] https://crrev.com/91040634e5a739820c470371c1d1386a7cd750a6/chrome/test/BUILD.gn [modify] https://crrev.com/91040634e5a739820c470371c1d1386a7cd750a6/tools/metrics/histograms/histograms.xml
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91040634e5a739820c470371c1d1386a7cd750a6 Commit: 91040634e5a739820c470371c1d1386a7cd750a6 Author: nverne@chromium.org Commiter: nverne@chromium.org Date: 2018-09-27 05:48:41 +0000 UTC Merge Crostini Upgrade dialog into M70. Note, this required coding to the pre-"CrostiniManager as a KeyedService" world. Old description follows, and it still applies: Creates a new dialog for Crostini Upgrade. If the user's cros-termina component is incompatible with the current version of Chrome and must be upgraded, but the user is offline, we show this dialog asking the user to go online and try again. This happens when they attempt to launch any crostini app (e.g. the terminal). Testing the dialog showed a bug in which the spinner for Terminal was not dismissed if the CrostiniRestart failed before the standard spinner delay. This has been fixed in the current CL. Also added testing code to configure the component updater in browser tests so we can simulate the circumstances leading to the dialog being shown. (cherry picked from commit bc9185c627f678ff37431b6e9e112f72cabe0f4d) Bug: 881616 Change-Id: Id1521e66c8ab9fb94b8ec4fe4334ee58616ebe03 Reviewed-on: https://chromium-review.googlesource.com/1248461 Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#701} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Sep 28
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tbuck...@chromium.org
, Sep 6