New issue
Advanced search Search tips

Issue 881615 link

Starred by 1 user
Status: Fixed
Owner:
baileyberro@chromium.org
Closed: Sep 7
Cc:
zentaro@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

SMB Write File leaks file descriptors

Project Member Reported by baileyberro@chromium.org, Sep 6 
After writing ~4GB worth of files, Chrome OOMs and crashes. This can be reproduced by mounting an SMB Share, and copying 4GB worth of files (either one file or many) to the share. 

The cause is that DBus::MessageWriter::AppendFileDescriptor duplicates file descriptors so it should be called with base::ScopedFD.get() rather than base::ScopedFD.release()
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a2d75839379aad2c471871e2b0ab30bb3041b95

commit 6a2d75839379aad2c471871e2b0ab30bb3041b95
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Sep 07 00:07:19 2018

Do not duplicate FD in SmbProviderClient

This change fixes an issue where FileDescriptors were being duplicated,
and as a result leaked, when writing them into a proto to send over
D-Bus

Bug:  chromium:881615 
Change-Id: I6e7e7abce34a537c3d9228cf9baa6d1d9074625f
Reviewed-on: https://chromium-review.googlesource.com/1211877
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589378}
[modify] https://crrev.com/6a2d75839379aad2c471871e2b0ab30bb3041b95/chromeos/dbus/smb_provider_client.cc

Comment 2 by baileyberro@chromium.org, Sep 7

Status: Fixed (was: Started)

Comment 3 by zentaro@chromium.org, Sep 9

Labels: Merge-Request-70
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 10

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 10

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edeb51dfe44199494e4fde5b70a09f54f34493d8

commit edeb51dfe44199494e4fde5b70a09f54f34493d8
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Sep 10 20:26:43 2018

Do not duplicate FD in SmbProviderClient

This change fixes an issue where FileDescriptors were being duplicated,
and as a result leaked, when writing them into a proto to send over
D-Bus

Bug:  chromium:881615 
Change-Id: I6e7e7abce34a537c3d9228cf9baa6d1d9074625f
Reviewed-on: https://chromium-review.googlesource.com/1211877
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589378}(cherry picked from commit 6a2d75839379aad2c471871e2b0ab30bb3041b95)
Reviewed-on: https://chromium-review.googlesource.com/1217442
Cr-Commit-Position: refs/branch-heads/3538@{#244}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/edeb51dfe44199494e4fde5b70a09f54f34493d8/chromeos/dbus/smb_provider_client.cc
►

Sign in to add a comment