New issue
Advanced search Search tips

Issue 881611 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Participants' hotlists:
Harmony-Cast-Dialog

Show other hotlists

Other hotlists containing this issue:
Harmony-Cast-Dialog-Accessibility


Sign in to add a comment

[Harmony Cast Dialog] Stop button should be screen reader accessible

Project Member Reported by taku...@chromium.org, Sep 6

Issue description

The button should say its functionality and which sink it's for when in focus.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30e19e39b03436517664bb3c650cf16889953cd1

commit 30e19e39b03436517664bb3c650cf16889953cd1
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Fri Sep 07 17:00:15 2018

[Harmony Cast Dialog] Make stop button compatible with screen readers

When a stop button is in focus, the screen reader will say "stop, <sink
name>, <sink status>, button".

Bug:  881611 
Change-Id: If90512e79c5c47a0cbe04a8e88e49fe165fcbb2c
Reviewed-on: https://chromium-review.googlesource.com/1211666
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589553}
[modify] https://crrev.com/30e19e39b03436517664bb3c650cf16889953cd1/chrome/app/media_router_strings.grdp
[modify] https://crrev.com/30e19e39b03436517664bb3c650cf16889953cd1/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc

Status: Fixed (was: Assigned)

Sign in to add a comment