Move password page in unified setup to after the one that follows it |
|||||
Issue descriptionRight now the password prompt shows up immediately after clicking the notification on ChromeOS with very little context. It's pretty jarring and scary to just have a dialog ask for your password like that. Putting it after the next screen (where the user reads about better together, picks a phone, clicks accept) would be much clearer and less scary. This was also brought up by our GmsCore security reviewer as a security risk with entering passwords without appropriate context (which is why this is a blocker). We can also get rid of the logic that returns to the password page after a timeout.
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8943110d03e7b0b3eb1f8ab471f8fa27bb2bd3d5 commit 8943110d03e7b0b3eb1f8ab471f8fa27bb2bd3d5 Author: Ryan Hansberry <hansberry@chromium.org> Date: Fri Sep 07 22:57:41 2018 [CrOS MultiDevice] Make the password entry page of setup flow the 2nd page. Improve user experience by showing the "Start" page first, and the "Password" page after, making for a less jarring experience. Bug: 881610 Change-Id: I0a54c0d6c8b5ffc11e6bfdd2aba80adf6bab374d Reviewed-on: https://chromium-review.googlesource.com/1214169 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#589701} [modify] https://crrev.com/8943110d03e7b0b3eb1f8ab471f8fa27bb2bd3d5/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup.js [modify] https://crrev.com/8943110d03e7b0b3eb1f8ab471f8fa27bb2bd3d5/chrome/test/data/webui/multidevice_setup/integration_test.js
,
Sep 7
,
Sep 8
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/053f6754b334ac643475d74accf4c7a4b6221e64 commit 053f6754b334ac643475d74accf4c7a4b6221e64 Author: Ryan Hansberry <hansberry@chromium.org> Date: Mon Sep 10 16:30:09 2018 [CrOS MultiDevice] Make the password entry page of setup flow the 2nd page. Improve user experience by showing the "Start" page first, and the "Password" page after, making for a less jarring experience. Bug: 881610 Change-Id: I0a54c0d6c8b5ffc11e6bfdd2aba80adf6bab374d Reviewed-on: https://chromium-review.googlesource.com/1214169 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589701}(cherry picked from commit 8943110d03e7b0b3eb1f8ab471f8fa27bb2bd3d5) Reviewed-on: https://chromium-review.googlesource.com/1216846 Cr-Commit-Position: refs/branch-heads/3538@{#222} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/053f6754b334ac643475d74accf4c7a4b6221e64/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup.js [modify] https://crrev.com/053f6754b334ac643475d74accf4c7a4b6221e64/chrome/test/data/webui/multidevice_setup/integration_test.js
,
Sep 10
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by hansberry@chromium.org
, Sep 7