New issue
Advanced search Search tips

Issue 881589 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 914423



Sign in to add a comment

Missing POSIX platform support

Project Member Reported by nicolaso@chromium.org, Sep 6

Issue description

It should be fairly easy to open an alternative browser on Mac/Linux, so why not do it.
 
Components: Enterprise>BrowserSwitcher
Labels: -BrowserSwitcher
Summary: Missing POSIX platform support (was: Missing POSIX platform support to BrowserSwitcher)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a4a94d66c8b42c979b083a4062ea1b696b146e8

commit 9a4a94d66c8b42c979b083a4062ea1b696b146e8
Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Date: Mon Sep 17 15:26:11 2018

[BrowserSwitcher] Add Linux support

This will let BrowserSwitcher invoke an alternative browser on Linux,
and updates various files to build the feature on Linux.

Bug:  881589 
Change-Id: Ic4e544ef67839201f646c94dd119c280c95afa54
Reviewed-on: https://chromium-review.googlesource.com/1212003
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Pam Greene (Please send IM for reviews) <pam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591682}
[modify] https://crrev.com/9a4a94d66c8b42c979b083a4062ea1b696b146e8/chrome/browser/BUILD.gn
[modify] https://crrev.com/9a4a94d66c8b42c979b083a4062ea1b696b146e8/chrome/browser/browser_switcher/alternative_browser_driver.h
[add] https://crrev.com/9a4a94d66c8b42c979b083a4062ea1b696b146e8/chrome/browser/browser_switcher/alternative_browser_driver_linux.cc
[add] https://crrev.com/9a4a94d66c8b42c979b083a4062ea1b696b146e8/chrome/browser/browser_switcher/alternative_browser_driver_unittest.cc
[rename] https://crrev.com/9a4a94d66c8b42c979b083a4062ea1b696b146e8/chrome/browser/browser_switcher/alternative_browser_driver_win.cc
[modify] https://crrev.com/9a4a94d66c8b42c979b083a4062ea1b696b146e8/chrome/browser/browser_switcher/alternative_browser_launcher.cc
[modify] https://crrev.com/9a4a94d66c8b42c979b083a4062ea1b696b146e8/chrome/browser/browser_switcher/alternative_browser_launcher_unittest.cc
[modify] https://crrev.com/9a4a94d66c8b42c979b083a4062ea1b696b146e8/chrome/browser/browser_switcher/browser_switcher_prefs.cc
[modify] https://crrev.com/9a4a94d66c8b42c979b083a4062ea1b696b146e8/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/9a4a94d66c8b42c979b083a4062ea1b696b146e8/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/9a4a94d66c8b42c979b083a4062ea1b696b146e8/chrome/test/BUILD.gn

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a22c5ffce8c2a1f357ca4433f284a26ce670d1c

commit 8a22c5ffce8c2a1f357ca4433f284a26ce670d1c
Author: Daniel Bratell <bratell@opera.com>
Date: Fri Oct 19 13:51:53 2018

Fixed misspelled references to browser_switcher headers

Some isolate step errors in trybots mentioned these non-existing
headers so hoping the trybots will be happier, this patch removes
and changes the names to point to existing files.

Bug:  881589 
Change-Id: I6c7728110a9ce162293c57606824140cdacd8d38
Reviewed-on: https://chromium-review.googlesource.com/c/1286660
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#601133}
[modify] https://crrev.com/8a22c5ffce8c2a1f357ca4433f284a26ce670d1c/chrome/browser/BUILD.gn

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdcab009d81a8eda93ad098631d9f534bc5e9ad4

commit bdcab009d81a8eda93ad098631d9f534bc5e9ad4
Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Date: Mon Oct 22 14:50:33 2018

[BrowserSwitcher] Add Mac OS support

This enables the build on Mac OS X, and refactors
AlternativeBrowserDriver to work correctly on Mac OS.

Bug:  881589 
Change-Id: I6e73d33d83af5bc1c0d8bb3ec3e76fcf8409ee2e
Reviewed-on: https://chromium-review.googlesource.com/c/1283835
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601570}
[modify] https://crrev.com/bdcab009d81a8eda93ad098631d9f534bc5e9ad4/chrome/browser/BUILD.gn
[modify] https://crrev.com/bdcab009d81a8eda93ad098631d9f534bc5e9ad4/chrome/browser/browser_switcher/alternative_browser_driver.h
[rename] https://crrev.com/bdcab009d81a8eda93ad098631d9f534bc5e9ad4/chrome/browser/browser_switcher/alternative_browser_driver_posix.cc
[modify] https://crrev.com/bdcab009d81a8eda93ad098631d9f534bc5e9ad4/chrome/browser/browser_switcher/alternative_browser_driver_unittest.cc
[modify] https://crrev.com/bdcab009d81a8eda93ad098631d9f534bc5e9ad4/chrome/browser/browser_switcher/alternative_browser_driver_win.cc
[modify] https://crrev.com/bdcab009d81a8eda93ad098631d9f534bc5e9ad4/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/bdcab009d81a8eda93ad098631d9f534bc5e9ad4/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/bdcab009d81a8eda93ad098631d9f534bc5e9ad4/chrome/test/BUILD.gn

Status: Verified (was: Started)

Sign in to add a comment