New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 881574 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Sign in to add a comment

Investigate having content not embed renders using the window service

Project Member Reported by sky@chromium.org, Sep 6

Issue description

We may want this long term, but in the short term using the window service in content isn't buying us anything but additional complexity. This should make OOPIFs easier to get working in mash.

Fady is going to work on a design doc for this. Once the design doc is done we can better scope the work and file more specific bugs.
 
Blocking: 866991
Cc: jonr...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c906465e5b78c10fa1d8aab63a80b94096f1a0b

commit 7c906465e5b78c10fa1d8aab63a80b94096f1a0b
Author: Scott Violet <sky@chromium.org>
Date: Wed Sep 19 16:18:50 2018

aura/window-service: couple of random changes

EmbedRoot: needs to show the WindowTreeHost. I'm a surprised we actually see
  anything without this.
WindowPortMus: removes an unnecessary local.
WindowTree: Renames GetClientRootWindowFor() to FindClientRootContaining().

BUG=881574
TEST=covered by tests

Change-Id: I869d59dd2a20c5a608ef1c7346bc906de73f84dc
Reviewed-on: https://chromium-review.googlesource.com/1233173
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592429}
[modify] https://crrev.com/7c906465e5b78c10fa1d8aab63a80b94096f1a0b/services/ws/window_tree.cc
[modify] https://crrev.com/7c906465e5b78c10fa1d8aab63a80b94096f1a0b/services/ws/window_tree.h
[modify] https://crrev.com/7c906465e5b78c10fa1d8aab63a80b94096f1a0b/ui/aura/mus/embed_root.cc
[modify] https://crrev.com/7c906465e5b78c10fa1d8aab63a80b94096f1a0b/ui/aura/mus/window_port_mus.cc

Owner: sky@chromium.org
Status: Started (was: Untriaged)
Cc: jamescook@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47a3f38c37bc545b01c1f8eb90322ff057320fac

commit 47a3f38c37bc545b01c1f8eb90322ff057320fac
Author: James Cook <jamescook@chromium.org>
Date: Thu Sep 20 19:21:11 2018

Re-enable MediaEngagementAutoplayBrowserTest.UsePreloadedData_Allowed

It was disabled on all Linux platforms due to failures on Chrome OS
in SingleProcessMash browser_tests.

Instead, disable all MediaEngagement browser_tests via filter file
for SingleProcessMash. There's a fix in-flight for renderer
embedding in this mode, so I expect to re-enable them shortly.

Bug:  884589 ,  883706 , 881574
Change-Id: If6257ea160c7ba83c9bb322941001ce5ab1cc1b7
Reviewed-on: https://chromium-review.googlesource.com/1236836
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592897}
[modify] https://crrev.com/47a3f38c37bc545b01c1f8eb90322ff057320fac/chrome/browser/media/media_engagement_autoplay_browsertest.cc
[modify] https://crrev.com/47a3f38c37bc545b01c1f8eb90322ff057320fac/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e46b335bf85509c6a33dadab359b94f0bc043756

commit e46b335bf85509c6a33dadab359b94f0bc043756
Author: Scott Violet <sky@chromium.org>
Date: Sat Sep 22 00:37:07 2018

chromeos: makes renderers not use window-service for single-process-mash

In order to support this the window-service gets Attach/UnattachFrameSinkId.

BUG=881574
TEST=covered by tests

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I1bbf82170adf0e254eda8ffa7f1804d56495cb2a
Reviewed-on: https://chromium-review.googlesource.com/1233174
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593393}
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/components/viz/host/host_frame_sink_manager.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/components/viz/host/host_frame_sink_manager.h
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/browser/browser_main_loop.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/browser/frame_host/cross_process_frame_connector.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/browser/oop_browsertest.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/browser/renderer_host/render_widget_host_view_child_frame_browsertest.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/browser/service_manager/common_browser_interfaces.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/browser/web_contents/web_contents_view_guest.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/common/content_param_traits.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/ppapi_plugin/ppapi_thread.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/renderer/mus/renderer_window_tree_client.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/content/renderer/render_widget.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/services/ws/BUILD.gn
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/services/ws/DEPS
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/services/ws/client_root.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/services/ws/client_root.h
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/services/ws/public/mojom/window_tree.mojom
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/services/ws/server_window.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/services/ws/server_window.h
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/services/ws/window_tree.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/services/ws/window_tree.h
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/services/ws/window_tree_unittest.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/ui/aura/mus/window_port_mus.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/ui/aura/mus/window_port_mus.h
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/ui/aura/mus/window_tree_client.h
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/ui/aura/test/mus/test_window_tree.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/ui/aura/test/mus/test_window_tree.h
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/ui/aura/window.cc
[modify] https://crrev.com/e46b335bf85509c6a33dadab359b94f0bc043756/ui/aura/window_port.h

Labels: -Proj-Mash-SingleProcess Proj-Mash-MultiProcess
This is now done for single-process-mash, but not multi-process-mash requires more work. Fady has a design doc out for the work. I'm retargetting to multi-process-mash.
Owner: ----
Status: Available (was: Started)
I'm moving this to available until the design doc is worked out.
Blocking: 905394

Sign in to add a comment