Weird compile failure on win_chromium_compile_dbg_ng |
||
Issue descriptionOn this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1200388 ... compile fails consitently on win_chromium_compile_dbg_ng, e.g.: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win_chromium_compile_dbg_ng/115270 ... but succeeds on all other builders (including other win builders), e.g.: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/80008 ?
,
Sep 6
../..\third_party/blink/renderer/platform/heap/visitor.h(108,19): error: invalid application of 'sizeof' to an incomplete type 'blink::LocalDOMWindow'
static_assert(sizeof(T), "T must be fully defined");
^~~~~~~~~
../..\third_party/blink/renderer/platform/heap/visitor.h(91,5): note: in instantiation of function template specialization 'blink::Visitor::Trace<blink::LocalDOMWindow>' requested here
Trace(t.Get());
^
../..\third_party/blink/renderer/platform/supplementable.h(141,14): note: in instantiation of function template specialization 'blink::Visitor::Trace<blink::LocalDOMWindow>' requested here
visitor->Trace(supplementable_);
^
../..\third_party/blink/renderer/platform/supplementable.h(109,7): note: in instantiation of member function 'blink::Supplement<blink::LocalDOMWindow>::Trace' requested here
class Supplement : public GarbageCollectedMixin {
^
../..\third_party/blink/renderer/core/execution_context/execution_context.h(64,7): note: forward declaration of 'blink::LocalDOMWindow'
class LocalDOMWindow;
^
1 error generated.
Does including local_dom_window.h in execution_context.h help?
,
Sep 7
@thakis, yes that seems to fix it: https://chromium-review.googlesource.com/c/chromium/src/+/1212351
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c0f2dd7e749214e1cf96de4ba9c353005f26967 commit 8c0f2dd7e749214e1cf96de4ba9c353005f26967 Author: Kent Tamura <tkent@chromium.org> Date: Tue Sep 11 23:15:00 2018 Reduce the size of execution_context.h. It is used in 4,300+ compilation units. http://crrev.com/590155 increased its pre-processed size by 3.72MB, and this CL fixes it. Bug: 242216, 881537, 882997 Change-Id: If723b9d77dbd06fdde184498aa6ed7aa3e5e88e2 Reviewed-on: https://chromium-review.googlesource.com/1218388 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#590526} [modify] https://crrev.com/8c0f2dd7e749214e1cf96de4ba9c353005f26967/third_party/blink/renderer/core/execution_context/execution_context.h [modify] https://crrev.com/8c0f2dd7e749214e1cf96de4ba9c353005f26967/third_party/blink/renderer/core/intersection_observer/intersection_observer_controller.cc
,
Sep 11
The compilation failure was caused by DOMWindowPerformance, which inherits from Supplement<LocalDOMWindow>. * Why does the compiler try to produce Supplement<LocalDOMWindow> during compiling intersection_observer_controller.cc only on Windows? It seems DOMWindowPerformance isn't used in intersection_observer_controller.cc. * The error message is not very helpful. It doesn't mention DOMWindowPerformance. |
||
►
Sign in to add a comment |
||
Comment 1 by thakis@chromium.org
, Sep 6