macOS: Open elements panel [devtools shortcut] should be added to main menu. |
|||
Issue descriptionThe canonical place for macOS shortcuts is the main menu. See https://bugs.chromium.org/p/chromium/issues/detail?id=880867#c8 for an image of the other devtool shortcuts present there. See https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/main_menu_builder.mm?type=cs&q=main+menu+cocoa&sq=package:chromium&g=0&l=233 for the code that generates the menu item and https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/accelerators_cocoa.mm?type=cs&q=IDC_DEV_TOOLS&sq=package:chromium&g=0&l=34 for the hotkey mapping.
,
Nov 20
Since we are adding the Mac-specific shortcut to macOS' main menu > Developer menu, does it make sense to add this to the X11 main menu as well? I found an old bug ( issue 304708 ) where we added the item to both places. groby@, thomasanderson@, would it make sense to add to add "Inspect Elements - Ctrl + Shift + C" to the X11 menu?
,
Nov 20
Adding it on Linux too SGTM. But beware that the Mac-style top menu is only available on certain environments (Unity is the only one I can think of and that's since been killed by Canonical). So the option should be supplemental to having it somewhere else.
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a4d59db345a60e3c75a673267e2af0e34d22298 commit 3a4d59db345a60e3c75a673267e2af0e34d22298 Author: Erik Luo <luoe@chromium.org> Date: Wed Nov 21 21:25:15 2018 DevTools: add inspect elements shortcut to OS main menus Adds the "Inspect Elements" (Ctrl-Shift-C, Mac: Cmd-Alt-C) to X11's main menu and Mac's developer menu. This matches locations for "Javascript Console" (Ctrl-Shift-J). Screenshot: https://imgur.com/a/jOFOmTn TBR=cpu@chromium.org Bug: 881534 Change-Id: Id17b9ca123ebc54c8e753ec25f31604ab3248f3d Reviewed-on: https://chromium-review.googlesource.com/c/1343513 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#610219} [modify] https://crrev.com/3a4d59db345a60e3c75a673267e2af0e34d22298/chrome/app/generated_resources.grd [modify] https://crrev.com/3a4d59db345a60e3c75a673267e2af0e34d22298/chrome/browser/ui/cocoa/accelerators_cocoa.mm [modify] https://crrev.com/3a4d59db345a60e3c75a673267e2af0e34d22298/chrome/browser/ui/cocoa/main_menu_builder.mm [modify] https://crrev.com/3a4d59db345a60e3c75a673267e2af0e34d22298/chrome/browser/ui/views/frame/global_menu_bar_x11.cc
,
Dec 13
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dgozman@chromium.org
, Oct 9Status: Assigned (was: Untriaged)