New issue
Advanced search Search tips

Issue 881530 link

Starred by 1 user
Status: Fixed
Owner:
oksamyt@chromium.org
Closed: Oct 10
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add more coverage for service options

Project Member Reported by oksamyt@chromium.org, Sep 6 
Negatives cases need to be covered (when the lack of the option causes a connection to be denied) for the following options described in  https://crbug.com/866967 :

can_connect_to_other_services_as_any_user
can_connect_to_other_services_with_any_instance_name

Comment 1 by oksamyt@chromium.org, Oct 9

Blockedon: -881524

Comment 2 by oksamyt@chromium.org, Oct 9

Owner: oksamyt@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60b52d8e199047976059e374f6b9799adc4d402b

commit 60b52d8e199047976059e374f6b9799adc4d402b
Author: Oksana Zhuravlova <oksamyt@chromium.org>
Date: Wed Oct 10 20:32:12 2018

Add a negative test for can_connect_to_other_services_with_any_instance_name

This change adds a test that verifies the connection is refused when
trying to connect with a different instance name without having the
'can_connect_to_other_services_with_any_instance_name' in the manifest.
Also, the same option was removed from connect_test_sandboxed_app_manifest.json
since it is not necessary.

Bug:  881530 
Change-Id: I8659d520cc384c73b0c8c1a6e29c3b9a1b774789
Reviewed-on: https://chromium-review.googlesource.com/c/1270949
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598480}
[modify] https://crrev.com/60b52d8e199047976059e374f6b9799adc4d402b/services/service_manager/service_manager.cc
[modify] https://crrev.com/60b52d8e199047976059e374f6b9799adc4d402b/services/service_manager/tests/connect/connect_test.mojom
[modify] https://crrev.com/60b52d8e199047976059e374f6b9799adc4d402b/services/service_manager/tests/connect/connect_test_app.cc
[modify] https://crrev.com/60b52d8e199047976059e374f6b9799adc4d402b/services/service_manager/tests/connect/connect_test_app_a_manifest.json
[modify] https://crrev.com/60b52d8e199047976059e374f6b9799adc4d402b/services/service_manager/tests/connect/connect_test_app_manifest.json
[modify] https://crrev.com/60b52d8e199047976059e374f6b9799adc4d402b/services/service_manager/tests/connect/connect_test_package.cc
[modify] https://crrev.com/60b52d8e199047976059e374f6b9799adc4d402b/services/service_manager/tests/connect/connect_test_sandboxed_app_manifest.json
[modify] https://crrev.com/60b52d8e199047976059e374f6b9799adc4d402b/services/service_manager/tests/connect/connect_unittest.cc
[modify] https://crrev.com/60b52d8e199047976059e374f6b9799adc4d402b/services/service_manager/tests/connect/connect_unittests_manifest.json

Comment 4 by oksamyt@chromium.org, Oct 10

Status: Fixed (was: Started)
►

Sign in to add a comment