New issue
Advanced search Search tips

Issue 881529 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

Move the moblab init files to project moblab

Project Member Reported by haddowk@chromium.org, Sep 6

Issue description

cros_workon for project-moblab is broken crbug.com/854633

Until that is fixed move the init files to platform/moblab so we can have multiple changes in flight without ebuild version issues.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/a7dd9762d6c3de1b6973cc06d9a3b2b96890fc70

commit a7dd9762d6c3de1b6973cc06d9a3b2b96890fc70
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri Oct 12 22:16:26 2018

[moblab] Copy the files from the project-moblab overlay.

The cros-workon build is broken for the project-moblab overlay
until that is fixed move the init files to platform-moblab
so multiple changes can be in flight at the same time.

CQ-DEPEND=CL:1214286
BUG=chromium:881529
TEST=ad hoc moblab testing

Change-Id: Ia5a534c98224023e6629fd004b951369687767e4
Reviewed-on: https://chromium-review.googlesource.com/1214290
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>

[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-external-settings-init.conf
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-whining-update-db.conf
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-devserver-cleanup-init.conf
[add] https://crrev.com/a7dd9762d6c3de1b6973cc06d9a3b2b96890fc70/project-moblab/sys-apps/moblab-upstart-init/moblab-upstart-init-9999.ebuild
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-database-test-importer.conf
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-mobmonitor-init.conf
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-bootup-status-init.conf
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-scheduler-init.conf
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-external-storage-init.conf
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-gsoffloader-init.conf
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-host-scheduler-init.conf
[rename] https://crrev.com/a7dd9762d6c3de1b6973cc06d9a3b2b96890fc70/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.1-r49.ebuild
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-base-container-init.conf
[modify] https://crrev.com/a7dd9762d6c3de1b6973cc06d9a3b2b96890fc70/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-9999.ebuild
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-dhcpd-init.conf
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-homedir-init.conf
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-network-bridge-init.conf
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-apache-init.conf
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-containers-dir-init.conf
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-internetcheck.conf
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/boot-logging-moblab.conf
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-kill-long-running-sql-query.conf
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-gsoffloader_s-init.conf
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-devserver-init.conf
[delete] https://crrev.com/f3b4aff998a6b6e39305898b0145d67a07d0f1a6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-database-init.conf

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/moblab/+/6db314c8e75233625739bcab9fd0f284a5534553

commit 6db314c8e75233625739bcab9fd0f284a5534553
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri Oct 12 22:16:25 2018

[moblab] Copy the files from the project-moblab overlay.

The cros-workon build is broken for the project-moblab overlay
until that is fixed move the init files to platform-moblab
so multiple changes can be in flight at the same time.

CQ-DEPEND=CL:1214290
BUG=chromium:881529
TEST= ad hoc moblab testing

Change-Id: Ic2fa7a74b452a313f75101e37c875f38ef374fdc
Reviewed-on: https://chromium-review.googlesource.com/1214286
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-host-scheduler-init.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-devserver-init.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-network-bridge-init.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-containers-dir-init.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-mobmonitor-init.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-external-settings-init.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-kill-long-running-sql-query.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/job_aborter.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-homedir-init.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-apache-init.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-bootup-status-init.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-devserver-cleanup-init.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-external-storage-init.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-database-init.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-dhcpd-init.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-gsoffloader_s-init.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/boot-logging-moblab.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-internetcheck.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-database-test-importer.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-whining-update-db.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-gsoffloader-init.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-base-container-init.conf
[add] https://crrev.com/6db314c8e75233625739bcab9fd0f284a5534553/src/upstart_init/moblab-scheduler-init.conf

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/moblab/+/b44c34807ca251db7e612841513cf20cc0ce28e2

commit b44c34807ca251db7e612841513cf20cc0ce28e2
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed Oct 17 21:23:26 2018

[moblab] Move moblab specific service settings to the platform.

As cros_workon does not work on the overlays/project moblab this
makes changes easier when multiple people/changes are being made.

BUG=chromium:881529
TEST=None

Change-Id: Ida5fef1eb21d535cbda9d04f104e4737c4944b74
Reviewed-on: https://chromium-review.googlesource.com/1281949
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>

[add] https://crrev.com/b44c34807ca251db7e612841513cf20cc0ce28e2/src/service_settings/dhcpd-moblab.conf
[add] https://crrev.com/b44c34807ca251db7e612841513cf20cc0ce28e2/src/service_settings/mysql_defaults_extra.cnf
[add] https://crrev.com/b44c34807ca251db7e612841513cf20cc0ce28e2/src/service_settings/moblab-apache-settings.conf
[add] https://crrev.com/b44c34807ca251db7e612841513cf20cc0ce28e2/src/service_settings/ssp_deploy_shadow_config.json

Sign in to add a comment