Autofill suggestions text color doesn't have enough contrast
Reported by
rom7...@gmail.com,
Sep 6
|
|||||||||||||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.81 Safari/537.36 Example URL: Steps to reproduce the problem: 1. Type something in a form field with auto-fill What is the expected behavior? Suggestions text color is readable What went wrong? Suggestions text color is not very readable Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? Yes 63 Does this work in other browsers? Yes Chrome version: 69.0.3497.81 Channel: beta OS Version: Ubuntu 17.10 Flash Version:
,
Sep 6
Hi rom7011, thanks for the report! A few questions: 1. What theme are you using in Chrome? (You can find this under chrome://settings/appearance > Themes) 2. What desktop environment are you using? Have you changed or set any themes at this level?
,
Sep 6
Hi rom7011@. A few more questions: 3. Do you have any extensions that might be changing something? You can check installed extensions on chrome://extensions. 4. Do you see the same problem in other fields, such as credit card or billing address on checkout forms? Thanks,
,
Sep 7
,
Sep 7
,
Sep 7
Hey! 1. Theme: GTK+ 2. DE: Gnome, Theme: Adwaita-dark (default, no modifications) 3. I'm able to reproduce with a fresh user, no extensions. 4. Yes, I see the same shade being used for other stuff. See images.
,
Sep 7
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 8
For some reason, the font color is bypassing Harmony and may be using the color from the native team, maybe because of this: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/chrome_typography_provider.cc?l=167 rom7011@: can you please confirm if this is how your environment look like? https://www.gnome-look.org/p/1014995/
,
Sep 9
Somewhat, that's an old Gtk2 theme, I'm using the default Gtk3 dark theme for the Gnome desktop. More something like this: https://blogs.gnome.org/mclasen/files/2014/06/adwaita-dark.png
,
Sep 10
Tried checking the issue on reported chrome version 69.0.3497.81 using Ubuntu 14.04 with the below mentioned steps. 1. Launched Chrome 2. Have set the Gnome Theme: Adwaita-dark 3. Under Chrome://settings/autofill saved few details. 4. Navigated to https://rsolomakhin.github.io/autofill/ Tried autofilling the columns. The suggested text colour was properly seen. Attaching the screenshot of the same for reference. @Reporter: Please let us know if anything missed from our end in reproducing the issue. And requesting someone from Dev team to help in triaging this further. Thanks!
,
Sep 10
Here are more versions: Ubuntu: 17.10 GNOME Shell: 3.26.2 libgtk-3-0: 3.22.25-0ubuntu0.1 Note that if you're using Ubuntu 14.04, you might be using the Unity desktop? The Gnome desktop is installable on older versions of Ubuntu with the `ubuntu-gnome-desktop` package. Gnome desktop comes by default on newer Ubuntu versions. Anything else I can do to debug on my end?
,
Sep 10
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 10
vamshi.kommuri@: Please enable chrome://flags#enable-autofill-native-dropdown-views
,
Sep 11
As mentioned in comment#11, installed the Gnome Desktop and Checked the issue by enabling the flag mentioned in comment#13, i.e., #enable-autofill-native-dropdown-views Still we could not find any issues with the contrast of the autofill suggestions, attaching the screenshot of the same for reference. Any further inputs in reproducing the issue would be helpful. Thanks!
,
Sep 11
I was able to reproduce the issue. For some reason, an active profile will retain the previous Gnome theme. I needed to create a new profile and sign-in to it to be able to apply the Gnome theme on the window. Once it was applied, I was able to reproduce the issue. We will investigate what's happening here. This behavior is not what we want and needs to be fixed.
,
Sep 11
Screenshots for crrev.com/c/1219991.
,
Sep 11
Two more, with correct file extension.
,
Sep 11
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c498633e31133e276cd3e38e2362ffdbfb3925c commit 0c498633e31133e276cd3e38e2362ffdbfb3925c Author: Fabio Tirelo <ftirelo@chromium.org> Date: Wed Sep 12 15:24:59 2018 [AF] Force MD2 colors on labels This fixes a low contrast issue that happens when a dark native theme is enabled. The solution consists of disabling auto-color readability for the labels, which forces minimum contrast when background colors for labels are not explicitely set. That protection is not needed for the Autofill/Password generation dropdowns, because contrast is already taken into account in MD2. The same idea has been applied elsewhere in the code base (see https://bugs.chromium.org/p/chromium/issues/detail?id=814121 for an example). Bug: 881514 Change-Id: If455e053499fb23add58197f11a14fa7493cecc8 Reviewed-on: https://chromium-review.googlesource.com/1219991 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#590686} [modify] https://crrev.com/0c498633e31133e276cd3e38e2362ffdbfb3925c/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc [modify] https://crrev.com/0c498633e31133e276cd3e38e2362ffdbfb3925c/chrome/browser/ui/views/autofill/view_util.cc [modify] https://crrev.com/0c498633e31133e276cd3e38e2362ffdbfb3925c/chrome/browser/ui/views/autofill/view_util.h [modify] https://crrev.com/0c498633e31133e276cd3e38e2362ffdbfb3925c/chrome/browser/ui/views/passwords/password_generation_popup_view_views.cc
,
Sep 12
,
Sep 13
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 14
Tried reproducing the issue as per comment# 11, 13 & 15, but unable to reproduce it and as per comment# 14 unable to reproduce the issue from TE end. @Fabio Tirelo: Could you please try to test it on latest Dev# 71.0.3551.3 and help us in verifying the fix. Thanks!
,
Sep 14
Current dev on Linux is 70.0.3538.16. Is there any place where I can download 71.0.3551.3 for testing?
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/924d0e10f093daf3d3dba29b2171aae1d234e698 commit 924d0e10f093daf3d3dba29b2171aae1d234e698 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Fri Sep 14 20:21:17 2018 [M70 merge][AF] Force MD2 colors on labels This fixes a low contrast issue that happens when a dark native theme is enabled. The solution consists of disabling auto-color readability for the labels, which forces minimum contrast when background colors for labels are not explicitely set. That protection is not needed for the Autofill/Password generation dropdowns, because contrast is already taken into account in MD2. The same idea has been applied elsewhere in the code base (see https://bugs.chromium.org/p/chromium/issues/detail?id=814121 for an example). Bug: 881514 Change-Id: If455e053499fb23add58197f11a14fa7493cecc8 Reviewed-on: https://chromium-review.googlesource.com/1219991 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#590686}(cherry picked from commit 0c498633e31133e276cd3e38e2362ffdbfb3925c) Reviewed-on: https://chromium-review.googlesource.com/1227220 Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#422} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/924d0e10f093daf3d3dba29b2171aae1d234e698/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc [modify] https://crrev.com/924d0e10f093daf3d3dba29b2171aae1d234e698/chrome/browser/ui/views/autofill/view_util.cc [modify] https://crrev.com/924d0e10f093daf3d3dba29b2171aae1d234e698/chrome/browser/ui/views/autofill/view_util.h [modify] https://crrev.com/924d0e10f093daf3d3dba29b2171aae1d234e698/chrome/browser/ui/views/passwords/password_generation_popup_view_views.cc
,
Sep 19
ftirelo@, Here is the chrome binaries storage console for downloading builds: https://goto.google.com/wceix Also, would be great if you can help us verifying this fix on today's Beta RC# 70.0.35838.22. Thank you!
,
Sep 19
I tested locally on the current dev (71.0.3554.0) and the fix works. Since the CL is in the 70.0.3538.22, I think we are OK to go.
,
Sep 19
Thank you Fabio for verifying the fix. |
|||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Sep 6