New issue
Advanced search Search tips

Issue 881513 link

Starred by 2 users
Status: Assigned
Owner:
kyleju@chromium.org
Cc:
robertma@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Import webdriver/ from wpt and run against chromedriver in CI

Project Member Reported by foolip@chromium.org, Sep 6 
https://github.com/web-platform-tests/wpt/tree/master/webdriver/tests has tests written in Python for the WebDriver protocol. These are currently being run as part of wpt.fyi:
https://wpt.fyi/results/infrastructure/testdriver?label=experimental

Like other parts of web-platform-tests, we should also import and run them in the Chromium repository directly. This will make it possible to make changes to chromedriver and see the effects on the conformance test suite during review. We should also export changes (2-way sync) so that the test suite can be updated together with the source changes.

Comment 1 by foolip@chromium.org, Nov 13 

kyleju@, do you have an update on this bug? Can you link to design docs and other things, and also be sure to include "Bug: 881513" in CLs working towards this? Thanks!

Comment 2 by kyleju@chromium.org, Nov 13 

Created a CL for a working prototype - https://chromium-review.googlesource.com/c/chromium/src/+/1330031

Next step:
1. create testexpectations
2. integrate with trybots
3. two way sync
Project Member

Comment 3 by bugdroid1@chromium.org, Today (14 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f6874260539e70ec774687f49a56d6fd1feb8f5

commit 9f6874260539e70ec774687f49a56d6fd1feb8f5
Author: kyle Ju <kyleju@chromium.org>
Date: Tue Jan 22 19:00:13 2019

Roll in WPT WebDriver library.

Update WPTWhitelist to add webdriver library files

Need to roll in this library in preparation to run WPT WebDriver Tests fully inside
of Chromium and help land CL - https://chromium-review.googlesource.com/c/chromium/src/+/1368404

Change-Id: I47eca44257971b3c94df722cfcf68bcb64dd6eea
Bug: 881513
Reviewed-on: https://chromium-review.googlesource.com/c/1426011
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624857}
[modify] https://crrev.com/9f6874260539e70ec774687f49a56d6fd1feb8f5/third_party/blink/tools/blinkpy/third_party/wpt/WPTWhiteList
[add] https://crrev.com/9f6874260539e70ec774687f49a56d6fd1feb8f5/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/webdriver/webdriver/__init__.py
[add] https://crrev.com/9f6874260539e70ec774687f49a56d6fd1feb8f5/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/webdriver/webdriver/client.py
[add] https://crrev.com/9f6874260539e70ec774687f49a56d6fd1feb8f5/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/webdriver/webdriver/error.py
[add] https://crrev.com/9f6874260539e70ec774687f49a56d6fd1feb8f5/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/webdriver/webdriver/protocol.py
[add] https://crrev.com/9f6874260539e70ec774687f49a56d6fd1feb8f5/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/webdriver/webdriver/transport.py
►

Sign in to add a comment