The peeking launcher shows high on the screen |
|||||||||||
Issue descriptionChrome Version: ToT from 06AUG2018 What steps will reproduce the problem? (1) With zero state enabled. (2) open peeking launcher (3) Show emojii keyboard. (4) Click x in search box. (5) Close onscreen keyboard. What is the expected result? launcher is peeking at regular height. What happens instead? Launcher is peeking at "Half" height Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Sep 15
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/392f9653da8d1492beae5a27303934c7cfcf6aaf commit 392f9653da8d1492beae5a27303934c7cfcf6aaf Author: Kevin Strohbehn <ginko@google.com> Date: Mon Sep 17 22:19:40 2018 a11y keyboard no longer causes peeking launcher to appear at half-height after close Bug: 881510 Change-Id: Ic75fb402df6dad4fd1c863a3475a09f45092ed6e Reviewed-on: https://chromium-review.googlesource.com/1225798 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#591840} [modify] https://crrev.com/392f9653da8d1492beae5a27303934c7cfcf6aaf/ash/app_list/views/app_list_view.cc [modify] https://crrev.com/392f9653da8d1492beae5a27303934c7cfcf6aaf/ash/app_list/views/app_list_view.h [modify] https://crrev.com/392f9653da8d1492beae5a27303934c7cfcf6aaf/ash/app_list/views/search_box_view.cc [modify] https://crrev.com/392f9653da8d1492beae5a27303934c7cfcf6aaf/ash/app_list/views/search_box_view_unittest.cc
,
Sep 17
,
Sep 20
,
Sep 20
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7503e1b5362f49e83731a9562f1a20bf0eccd4ad commit 7503e1b5362f49e83731a9562f1a20bf0eccd4ad Author: Kevin Strohbehn <ginko@google.com> Date: Fri Sep 21 22:04:00 2018 a11y keyboard no longer causes peeking launcher to appear at half-height after close Bug: 881510 Change-Id: Ic75fb402df6dad4fd1c863a3475a09f45092ed6e Reviewed-on: https://chromium-review.googlesource.com/1225798 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#591840}(cherry picked from commit 392f9653da8d1492beae5a27303934c7cfcf6aaf) Reviewed-on: https://chromium-review.googlesource.com/1239264 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#569} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/7503e1b5362f49e83731a9562f1a20bf0eccd4ad/ash/app_list/views/app_list_view.cc [modify] https://crrev.com/7503e1b5362f49e83731a9562f1a20bf0eccd4ad/ash/app_list/views/app_list_view.h [modify] https://crrev.com/7503e1b5362f49e83731a9562f1a20bf0eccd4ad/ash/app_list/views/search_box_view.cc [modify] https://crrev.com/7503e1b5362f49e83731a9562f1a20bf0eccd4ad/ash/app_list/views/search_box_view_unittest.cc
,
Sep 21
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 7503e1b5362f49e83731a9562f1a20bf0eccd4ad was merged to refs/branch-heads/3538 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7503e1b5362f49e83731a9562f1a20bf0eccd4ad Commit: 7503e1b5362f49e83731a9562f1a20bf0eccd4ad Author: ginko@google.com Commiter: newcomer@chromium.org Date: 2018-09-21 22:04:00 +0000 UTC a11y keyboard no longer causes peeking launcher to appear at half-height after close Bug: 881510 Change-Id: Ic75fb402df6dad4fd1c863a3475a09f45092ed6e Reviewed-on: https://chromium-review.googlesource.com/1225798 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#591840}(cherry picked from commit 392f9653da8d1492beae5a27303934c7cfcf6aaf) Reviewed-on: https://chromium-review.googlesource.com/1239264 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#569} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Sep 24
,
Sep 28
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by newcomer@chromium.org
, Sep 12Owner: ginko@chromium.org