New issue
Advanced search Search tips

Issue 881507 link

Starred by 1 user
Status: Fixed
Owner:
vapier@chromium.org
Closed: Sep 9
Cc:
vapier@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

hterm: CSI-J3 should wipe scrollback (with a config option)

Project Member Reported by vapier@chromium.org, Sep 6 
currently hterm has this:
  } else if (arg == 3) {
    // The xterm docs say this means "Erase saved lines", but we'll just clear
    // the display since killing the scrollback seems rude.
    this.terminal.clear();

we should add a config knob here akin to enable-dec12 and have the default behavior match xterm.  namely, it should actually clear scrollback and not just the current screen.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/9c482b8efe60b95ffa70011de94ef6b431987b17

commit 9c482b8efe60b95ffa70011de94ef6b431987b17
Author: Mike Frysinger <vapier@chromium.org>
Date: Sun Sep 09 07:36:04 2018

hterm: add a clearScrollback hook

We provide terminal methods to clear the screen, and to clear the
screen+scrollback, but nothing to just clear scrollback.  Add that
and related keyboard shortcuts for completeness.

Bug:  chromium:881507 
Change-Id: I437c2b64e0b9d12f721d1a11a7986f3d25c60875
Reviewed-on: https://chromium-review.googlesource.com/1214626
Reviewed-by: Vitaliy Shipitsyn <vsh@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/9c482b8efe60b95ffa70011de94ef6b431987b17/hterm/js/hterm_terminal.js
[modify] https://crrev.com/9c482b8efe60b95ffa70011de94ef6b431987b17/hterm/doc/KeyboardBindings.md
[modify] https://crrev.com/9c482b8efe60b95ffa70011de94ef6b431987b17/hterm/js/hterm_parser_identifiers.js
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/38f267d88c7b47b53a00989b794cec261d10e3f5

commit 38f267d88c7b47b53a00989b794cec261d10e3f5
Author: Mike Frysinger <vapier@chromium.org>
Date: Sun Sep 09 07:36:28 2018

hterm: change CSI-J-3 to clear scrollback

We've long had CSI-J-3 (clear scrollback) wired to behave like CSI-J-2
(clear screen) because letting the remote clear local scrollback might
not be the best behavior.  Add a config setting to control it so we can
change the CSI-J-3 extension to match xterm where we got it from.

Bug:  chromium:881507 
Change-Id: I13cfa6d087e2ba456c80c9d0c7518b3db650fcfa
Reviewed-on: https://chromium-review.googlesource.com/1214627
Reviewed-by: Vitaliy Shipitsyn <vsh@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/38f267d88c7b47b53a00989b794cec261d10e3f5/hterm/js/hterm_vt.js
[modify] https://crrev.com/38f267d88c7b47b53a00989b794cec261d10e3f5/hterm/js/hterm_vt_tests.js
[modify] https://crrev.com/38f267d88c7b47b53a00989b794cec261d10e3f5/hterm/doc/ControlSequences.md
[modify] https://crrev.com/38f267d88c7b47b53a00989b794cec261d10e3f5/hterm/js/hterm_preference_manager.js
[modify] https://crrev.com/38f267d88c7b47b53a00989b794cec261d10e3f5/nassh/_locales/en/messages.json
[modify] https://crrev.com/38f267d88c7b47b53a00989b794cec261d10e3f5/hterm/js/hterm_terminal.js

Comment 3 by vapier@chromium.org, Sep 9

Owner: vapier@chromium.org
Status: Fixed (was: Available)
will be in the hterm-1.82/nassh-0.8.46 release
►

Sign in to add a comment