CL breaking ios-simulator landed through the CQ w/o issue |
||||
Issue descriptionThis is a follow up to https://bugs.chromium.org/p/chromium/issues/detail?id=881420 The CL that broke ios-simulator in that case, https://chromium-review.googlesource.com/c/chromium/src/+/1208434, landed through the CQ without apparent issue. On inspection, it caused a bunch of tests in component_unittests to start failing, and it caused the suite runtime to jump from ~4 minutes to >40 minutes. The step and the build still passed. P1 as this may allow similar CLs to land.
,
Sep 6
This looks like it might be due to a bug in the ios test runner. +ericale, lindsayw
,
Sep 7
Looked further. The tests in question all failed on the first pass, then passed on the second pass when run in isolation. The offending CL had introduced a change that modified global state & didn't clean up afterwards. Running tests in isolation in SimulatorTestRunner appeared to take >30s *per test*; with >70 test failures, that meant >35 minutes of additional runtime. I'm not sure if that's because it's spawning separate instances of the simulator per test, but it certainly seems like something could be streamlined...
,
Sep 11
+yzjr: this is an example of where an XCTestRunner owner would be valuable.
,
Sep 11
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jbudorick@chromium.org
, Sep 6