Stop showing the Import bookmarks bar on the NTP |
||||
Issue descriptionEither don't show it at all or don't show after X many loads for the new user.
,
Sep 11
,
Sep 28
To clarify, we want to remove the CTA to import bookmarks but keep the Apps part? Does this need to go through any review or are we all set to make this change?
,
Oct 1
Sharing a screenshot here before we check the change in is a good idea.
,
Oct 3
Ok, here it is.
,
Oct 3
I think we would want to wait to flip this till the Apps + Bar can be removed too.
,
Oct 3
Correction...I misread the bug and thought this was about removing the bookmark bar all together. Im fine with this for now.
,
Oct 8
So to sum up: for now we will remove the CTA to import bookmarks but keep the Apps part.
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e377ff4156fdc0712655a796be0fc4f28348eea3 commit e377ff4156fdc0712655a796be0fc4f28348eea3 Author: Tanya Gupta <tgupta@chromium.org> Date: Mon Oct 22 22:47:28 2018 Deleted code which prompted users to import bookmarks on the NTP Change-Id: Id912814a9028d1a705715d7ad482db2c0ebdc36f Bug: 881502 Reviewed-on: https://chromium-review.googlesource.com/c/1279228 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#601757} [modify] https://crrev.com/e377ff4156fdc0712655a796be0fc4f28348eea3/chrome/app/bookmarks_strings.grdp [modify] https://crrev.com/e377ff4156fdc0712655a796be0fc4f28348eea3/chrome/browser/ui/BUILD.gn [delete] https://crrev.com/7505272e539a36307091345acde5670fee94cc8d/chrome/browser/ui/bookmarks/bookmark_bar_instructions_delegate.h [delete] https://crrev.com/7505272e539a36307091345acde5670fee94cc8d/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc [delete] https://crrev.com/7505272e539a36307091345acde5670fee94cc8d/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h [modify] https://crrev.com/e377ff4156fdc0712655a796be0fc4f28348eea3/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/e377ff4156fdc0712655a796be0fc4f28348eea3/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h [modify] https://crrev.com/e377ff4156fdc0712655a796be0fc4f28348eea3/tools/grit/grit/format/gen_predetermined_ids_unittest.py [modify] https://crrev.com/e377ff4156fdc0712655a796be0fc4f28348eea3/tools/metrics/histograms/histograms.xml
,
Oct 22
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ramyan@chromium.org
, Sep 10