tracking the implementation of download UI for offline items.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc273049da880605b86462488990fcc4cb3b22fc commit dc273049da880605b86462488990fcc4cb3b22fc Author: Min Qin <qinmin@chromium.org> Date: Fri Sep 07 23:53:29 2018 Skeleton code for propagating UI to DownloadShelf for OfflineItems This CL introduces the skeleton UI code for OfflineItems. see https://docs.google.com/document/d/1xDRCoDYnOb9PvwJ8juSmG75jsE-YKzNomCMaoFtQWtQ/edit# BUG=881499 Change-Id: Ie31f6bcc77c65a4343f2e5a0be54f3b9b5fdd5bc Reviewed-on: https://chromium-review.googlesource.com/1211445 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#589720} [modify] https://crrev.com/dc273049da880605b86462488990fcc4cb3b22fc/chrome/browser/BUILD.gn [add] https://crrev.com/dc273049da880605b86462488990fcc4cb3b22fc/chrome/browser/download/download_shelf_controller.cc [add] https://crrev.com/dc273049da880605b86462488990fcc4cb3b22fc/chrome/browser/download/download_shelf_controller.h [add] https://crrev.com/dc273049da880605b86462488990fcc4cb3b22fc/chrome/browser/download/offline_item_model.cc [add] https://crrev.com/dc273049da880605b86462488990fcc4cb3b22fc/chrome/browser/download/offline_item_model.h [add] https://crrev.com/dc273049da880605b86462488990fcc4cb3b22fc/chrome/browser/download/offline_item_model_manager.cc [add] https://crrev.com/dc273049da880605b86462488990fcc4cb3b22fc/chrome/browser/download/offline_item_model_manager.h [add] https://crrev.com/dc273049da880605b86462488990fcc4cb3b22fc/chrome/browser/download/offline_item_model_manager_factory.cc [add] https://crrev.com/dc273049da880605b86462488990fcc4cb3b22fc/chrome/browser/download/offline_item_model_manager_factory.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27a5d1fe78e7b318f4c3b133d9887bcc185af688 commit 27a5d1fe78e7b318f4c3b133d9887bcc185af688 Author: Min Qin <qinmin@chromium.org> Date: Thu Sep 13 22:05:51 2018 Splitting OfflineItemModel into 2 classes. This CL splits OfflineItemModel into OfflineItemModelData and OfflineItemModel. OfflineItemModelData is equivalent to DownloadItemModelData, which stores the long lasting states that need to be accessed by UI code. OfflineItemModel is a short lived object constructed from OfflineItem, which simply provides all information for UI to display. BUG=881499 Change-Id: I18cf8585ba679b0314c0662ef40d33cdbe669156 Reviewed-on: https://chromium-review.googlesource.com/1222163 Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#591177} [modify] https://crrev.com/27a5d1fe78e7b318f4c3b133d9887bcc185af688/chrome/browser/BUILD.gn [modify] https://crrev.com/27a5d1fe78e7b318f4c3b133d9887bcc185af688/chrome/browser/download/download_shelf_controller.cc [modify] https://crrev.com/27a5d1fe78e7b318f4c3b133d9887bcc185af688/chrome/browser/download/download_shelf_controller.h [modify] https://crrev.com/27a5d1fe78e7b318f4c3b133d9887bcc185af688/chrome/browser/download/offline_item_model.cc [modify] https://crrev.com/27a5d1fe78e7b318f4c3b133d9887bcc185af688/chrome/browser/download/offline_item_model.h [add] https://crrev.com/27a5d1fe78e7b318f4c3b133d9887bcc185af688/chrome/browser/download/offline_item_model_data.h [modify] https://crrev.com/27a5d1fe78e7b318f4c3b133d9887bcc185af688/chrome/browser/download/offline_item_model_manager.cc [modify] https://crrev.com/27a5d1fe78e7b318f4c3b133d9887bcc185af688/chrome/browser/download/offline_item_model_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eefccbdc53b8841ba0a5791b5305a0f38759f2e9 commit eefccbdc53b8841ba0a5791b5305a0f38759f2e9 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Thu Sep 13 22:23:16 2018 offline_item_collections : Added single OfflineItem observer Added ability to add observers interested in only a single OfflineItem. Bug: 881499 Change-Id: I0b221071a0d7e258778fd37f668c8e0c5a8c2c26 Reviewed-on: https://chromium-review.googlesource.com/1213963 Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591184} [modify] https://crrev.com/eefccbdc53b8841ba0a5791b5305a0f38759f2e9/components/offline_items_collection/core/BUILD.gn [add] https://crrev.com/eefccbdc53b8841ba0a5791b5305a0f38759f2e9/components/offline_items_collection/core/filtered_offline_item_observer.cc [add] https://crrev.com/eefccbdc53b8841ba0a5791b5305a0f38759f2e9/components/offline_items_collection/core/filtered_offline_item_observer.h [add] https://crrev.com/eefccbdc53b8841ba0a5791b5305a0f38759f2e9/components/offline_items_collection/core/filtered_offline_item_observer_unittest.cc [modify] https://crrev.com/eefccbdc53b8841ba0a5791b5305a0f38759f2e9/components/offline_items_collection/core/test_support/BUILD.gn [add] https://crrev.com/eefccbdc53b8841ba0a5791b5305a0f38759f2e9/components/offline_items_collection/core/test_support/mock_filtered_offline_item_observer.cc [add] https://crrev.com/eefccbdc53b8841ba0a5791b5305a0f38759f2e9/components/offline_items_collection/core/test_support/mock_filtered_offline_item_observer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd83b7abebbd0becf318b2352087269eb0b1a1cc commit dd83b7abebbd0becf318b2352087269eb0b1a1cc Author: Min Qin <qinmin@chromium.org> Date: Fri Sep 14 22:40:46 2018 Add DownloadUIModel This serves as a base class for us to send UI updates for both download and offline items Bug: 881499 Change-Id: I54e50191764f9796250be02c7461cb96b9fa85a6 Reviewed-on: https://chromium-review.googlesource.com/1226456 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591505} [modify] https://crrev.com/dd83b7abebbd0becf318b2352087269eb0b1a1cc/chrome/browser/BUILD.gn [modify] https://crrev.com/dd83b7abebbd0becf318b2352087269eb0b1a1cc/chrome/browser/download/download_item_model.cc [modify] https://crrev.com/dd83b7abebbd0becf318b2352087269eb0b1a1cc/chrome/browser/download/download_item_model.h [add] https://crrev.com/dd83b7abebbd0becf318b2352087269eb0b1a1cc/chrome/browser/download/download_ui_model.cc [add] https://crrev.com/dd83b7abebbd0becf318b2352087269eb0b1a1cc/chrome/browser/download/download_ui_model.h [modify] https://crrev.com/dd83b7abebbd0becf318b2352087269eb0b1a1cc/chrome/browser/download/offline_item_model.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20add70375359ad3d551893149281aad48b7a77e commit 20add70375359ad3d551893149281aad48b7a77e Author: Shakti Sahu <shaktisahu@chromium.org> Date: Tue Sep 18 00:02:15 2018 Download Shelf : Changed DownloadItemView to use DownloadUIModel Design doc : https://docs.google.com/document/d/1xDRCoDYnOb9PvwJ8juSmG75jsE-YKzNomCMaoFtQWtQ Bug: 881499 Change-Id: Ic7e4cd78dfd4bc6d4a98de0fb870567005e294be Reviewed-on: https://chromium-review.googlesource.com/1227407 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#591882} [modify] https://crrev.com/20add70375359ad3d551893149281aad48b7a77e/chrome/browser/download/download_commands.cc [modify] https://crrev.com/20add70375359ad3d551893149281aad48b7a77e/chrome/browser/download/download_commands.h [modify] https://crrev.com/20add70375359ad3d551893149281aad48b7a77e/chrome/browser/download/download_item_model.cc [modify] https://crrev.com/20add70375359ad3d551893149281aad48b7a77e/chrome/browser/download/download_item_model.h [modify] https://crrev.com/20add70375359ad3d551893149281aad48b7a77e/chrome/browser/download/download_ui_model.cc [modify] https://crrev.com/20add70375359ad3d551893149281aad48b7a77e/chrome/browser/download/download_ui_model.h [modify] https://crrev.com/20add70375359ad3d551893149281aad48b7a77e/chrome/browser/ui/views/download/download_item_view.cc [modify] https://crrev.com/20add70375359ad3d551893149281aad48b7a77e/chrome/browser/ui/views/download/download_item_view.h [modify] https://crrev.com/20add70375359ad3d551893149281aad48b7a77e/chrome/browser/ui/views/download/download_shelf_context_menu_view.cc [modify] https://crrev.com/20add70375359ad3d551893149281aad48b7a77e/chrome/browser/ui/views/download/download_shelf_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0612c7430e4ca1b604d398862ef7d20af05efc4 commit e0612c7430e4ca1b604d398862ef7d20af05efc4 Author: qinmin <qinmin@chromium.org> Date: Wed Sep 19 22:36:26 2018 Remove chrome/browser/ui/cocoa/download/ The code under this dir is not being used. The only file left is download_start_animation_mac.mm as it needs to provide mac specific download start animation BUG=881499, 832676 Change-Id: I9f8e927da2487c519f329508a31816c5a5253415 Reviewed-on: https://chromium-review.googlesource.com/1234473 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592581} [modify] https://crrev.com/e0612c7430e4ca1b604d398862ef7d20af05efc4/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/e0612c7430e4ca1b604d398862ef7d20af05efc4/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm [modify] https://crrev.com/e0612c7430e4ca1b604d398862ef7d20af05efc4/chrome/browser/ui/cocoa/browser_window_cocoa.mm [modify] https://crrev.com/e0612c7430e4ca1b604d398862ef7d20af05efc4/chrome/browser/ui/cocoa/browser_window_controller.h [modify] https://crrev.com/e0612c7430e4ca1b604d398862ef7d20af05efc4/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/e0612c7430e4ca1b604d398862ef7d20af05efc4/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/e0612c7430e4ca1b604d398862ef7d20af05efc4/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/OWNERS [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/background_theme.h [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/background_theme.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_button.h [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_button.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_button_unittest.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_cell.h [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_cell.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_cell_unittest.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_controller.h [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_controller.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_controller_unittest.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_mac.h [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_mac.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_item_view_protocol.h [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_context_menu_controller.h [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_context_menu_controller.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_controller.h [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_controller.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_mac.h [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_mac.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_mac_unittest.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_view_cocoa.h [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_view_cocoa.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_shelf_view_cocoa_unittest.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_show_all_button.h [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_show_all_button.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_show_all_cell.h [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/download_show_all_cell.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/md_download_item_progress_indicator.h [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/md_download_item_progress_indicator.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/md_download_item_view.h [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/md_download_item_view.mm [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/md_download_item_view_testing.h [delete] https://crrev.com/7f6fac7d516212457e6c093b8db016423ba2f85f/chrome/browser/ui/cocoa/download/md_download_item_view_unittest.mm [modify] https://crrev.com/e0612c7430e4ca1b604d398862ef7d20af05efc4/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16355cbadad8588015c95f19d2a5106a33eacd56 commit 16355cbadad8588015c95f19d2a5106a33eacd56 Author: Min Qin <qinmin@chromium.org> Date: Thu Sep 20 01:07:06 2018 More OfflineItemModel implementation This CL makes OfflineItemModel inherit from DownloadUIModel Bug: 881499 Change-Id: I63270a79917bae87fdb4ae3531f9088f7900509e Reviewed-on: https://chromium-review.googlesource.com/1225888 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#592645} [modify] https://crrev.com/16355cbadad8588015c95f19d2a5106a33eacd56/chrome/browser/download/download_item_model.cc [modify] https://crrev.com/16355cbadad8588015c95f19d2a5106a33eacd56/chrome/browser/download/download_item_model.h [modify] https://crrev.com/16355cbadad8588015c95f19d2a5106a33eacd56/chrome/browser/download/download_ui_model.h [modify] https://crrev.com/16355cbadad8588015c95f19d2a5106a33eacd56/chrome/browser/download/offline_item_model.cc [modify] https://crrev.com/16355cbadad8588015c95f19d2a5106a33eacd56/chrome/browser/download/offline_item_model.h [modify] https://crrev.com/16355cbadad8588015c95f19d2a5106a33eacd56/chrome/browser/download/offline_item_model_manager.cc [modify] https://crrev.com/16355cbadad8588015c95f19d2a5106a33eacd56/chrome/browser/download/offline_item_model_manager.h [modify] https://crrev.com/16355cbadad8588015c95f19d2a5106a33eacd56/chrome/browser/download/offline_item_model_manager_factory.cc [modify] https://crrev.com/16355cbadad8588015c95f19d2a5106a33eacd56/chrome/browser/ui/views/download/download_item_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b33aa1bcdb10151c10d7ef10f096acf5eb8776e commit 7b33aa1bcdb10151c10d7ef10f096acf5eb8776e Author: Taiju Tsuiki <tzik@chromium.org> Date: Thu Sep 20 05:49:00 2018 Revert "More OfflineItemModel implementation" This reverts commit 16355cbadad8588015c95f19d2a5106a33eacd56. Reason for revert: This seems to cause an ASAN failure on the CI. The error logs are: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29069 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934902171469785040/+/steps/interactive_ui_tests/0/logs/DownloadNotificationTest.IncognitoDownloadFile/0 Original change's description: > More OfflineItemModel implementation > > This CL makes OfflineItemModel inherit from DownloadUIModel > > Bug: 881499 > Change-Id: I63270a79917bae87fdb4ae3531f9088f7900509e > Reviewed-on: https://chromium-review.googlesource.com/1225888 > Commit-Queue: Min Qin <qinmin@chromium.org> > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592645} TBR=qinmin@chromium.org,shaktisahu@chromium.org Change-Id: Ifdae8934bae3cf137fd2e4729f076f8df577241d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881499 Reviewed-on: https://chromium-review.googlesource.com/1234099 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#592691} [modify] https://crrev.com/7b33aa1bcdb10151c10d7ef10f096acf5eb8776e/chrome/browser/download/download_item_model.cc [modify] https://crrev.com/7b33aa1bcdb10151c10d7ef10f096acf5eb8776e/chrome/browser/download/download_item_model.h [modify] https://crrev.com/7b33aa1bcdb10151c10d7ef10f096acf5eb8776e/chrome/browser/download/download_ui_model.h [modify] https://crrev.com/7b33aa1bcdb10151c10d7ef10f096acf5eb8776e/chrome/browser/download/offline_item_model.cc [modify] https://crrev.com/7b33aa1bcdb10151c10d7ef10f096acf5eb8776e/chrome/browser/download/offline_item_model.h [modify] https://crrev.com/7b33aa1bcdb10151c10d7ef10f096acf5eb8776e/chrome/browser/download/offline_item_model_manager.cc [modify] https://crrev.com/7b33aa1bcdb10151c10d7ef10f096acf5eb8776e/chrome/browser/download/offline_item_model_manager.h [modify] https://crrev.com/7b33aa1bcdb10151c10d7ef10f096acf5eb8776e/chrome/browser/download/offline_item_model_manager_factory.cc [modify] https://crrev.com/7b33aa1bcdb10151c10d7ef10f096acf5eb8776e/chrome/browser/ui/views/download/download_item_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63cb63c9baead3b0345fbb3a9f1e4b15f46db886 commit 63cb63c9baead3b0345fbb3a9f1e4b15f46db886 Author: Min Qin <qinmin@chromium.org> Date: Fri Sep 21 00:52:15 2018 More OfflineItemModel implementation This CL makes OfflineItemModel inherit from DownloadUIModel Bug: 881499 Change-Id: Ic7591f5ce7f5f5243cfeb8ff89ad1e77aa1b78db Reviewed-on: https://chromium-review.googlesource.com/1237134 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#593030} [modify] https://crrev.com/63cb63c9baead3b0345fbb3a9f1e4b15f46db886/chrome/browser/download/download_item_model.cc [modify] https://crrev.com/63cb63c9baead3b0345fbb3a9f1e4b15f46db886/chrome/browser/download/download_item_model.h [modify] https://crrev.com/63cb63c9baead3b0345fbb3a9f1e4b15f46db886/chrome/browser/download/download_ui_model.h [modify] https://crrev.com/63cb63c9baead3b0345fbb3a9f1e4b15f46db886/chrome/browser/download/notification/download_item_notification.cc [modify] https://crrev.com/63cb63c9baead3b0345fbb3a9f1e4b15f46db886/chrome/browser/download/notification/download_item_notification.h [modify] https://crrev.com/63cb63c9baead3b0345fbb3a9f1e4b15f46db886/chrome/browser/download/notification/download_item_notification_unittest.cc [modify] https://crrev.com/63cb63c9baead3b0345fbb3a9f1e4b15f46db886/chrome/browser/download/notification/download_notification_manager.cc [modify] https://crrev.com/63cb63c9baead3b0345fbb3a9f1e4b15f46db886/chrome/browser/download/notification/download_notification_manager.h [modify] https://crrev.com/63cb63c9baead3b0345fbb3a9f1e4b15f46db886/chrome/browser/download/offline_item_model.cc [modify] https://crrev.com/63cb63c9baead3b0345fbb3a9f1e4b15f46db886/chrome/browser/download/offline_item_model.h [modify] https://crrev.com/63cb63c9baead3b0345fbb3a9f1e4b15f46db886/chrome/browser/download/offline_item_model_manager.cc [modify] https://crrev.com/63cb63c9baead3b0345fbb3a9f1e4b15f46db886/chrome/browser/download/offline_item_model_manager.h [modify] https://crrev.com/63cb63c9baead3b0345fbb3a9f1e4b15f46db886/chrome/browser/download/offline_item_model_manager_factory.cc [modify] https://crrev.com/63cb63c9baead3b0345fbb3a9f1e4b15f46db886/chrome/browser/ui/views/download/download_item_view.cc [modify] https://crrev.com/63cb63c9baead3b0345fbb3a9f1e4b15f46db886/chrome/browser/ui/views/download/download_item_view.h [modify] https://crrev.com/63cb63c9baead3b0345fbb3a9f1e4b15f46db886/chrome/browser/ui/views/download/download_shelf_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a7537ab2fa0068e9ddc4a35d049435fbf827dbb commit 3a7537ab2fa0068e9ddc4a35d049435fbf827dbb Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Sep 21 16:51:49 2018 Revert "More OfflineItemModel implementation" This reverts commit 63cb63c9baead3b0345fbb3a9f1e4b15f46db886. Reason for revert: Crashing in debug builds: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7920 Original change's description: > More OfflineItemModel implementation > > This CL makes OfflineItemModel inherit from DownloadUIModel > > Bug: 881499 > Change-Id: Ic7591f5ce7f5f5243cfeb8ff89ad1e77aa1b78db > Reviewed-on: https://chromium-review.googlesource.com/1237134 > Commit-Queue: Min Qin <qinmin@chromium.org> > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593030} TBR=qinmin@chromium.org,shaktisahu@chromium.org Change-Id: I6fb1e7e1ed50df3147efdfa2e57e38577cffacf8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881499 Reviewed-on: https://chromium-review.googlesource.com/1238859 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#593226} [modify] https://crrev.com/3a7537ab2fa0068e9ddc4a35d049435fbf827dbb/chrome/browser/download/download_item_model.cc [modify] https://crrev.com/3a7537ab2fa0068e9ddc4a35d049435fbf827dbb/chrome/browser/download/download_item_model.h [modify] https://crrev.com/3a7537ab2fa0068e9ddc4a35d049435fbf827dbb/chrome/browser/download/download_ui_model.h [modify] https://crrev.com/3a7537ab2fa0068e9ddc4a35d049435fbf827dbb/chrome/browser/download/notification/download_item_notification.cc [modify] https://crrev.com/3a7537ab2fa0068e9ddc4a35d049435fbf827dbb/chrome/browser/download/notification/download_item_notification.h [modify] https://crrev.com/3a7537ab2fa0068e9ddc4a35d049435fbf827dbb/chrome/browser/download/notification/download_item_notification_unittest.cc [modify] https://crrev.com/3a7537ab2fa0068e9ddc4a35d049435fbf827dbb/chrome/browser/download/notification/download_notification_manager.cc [modify] https://crrev.com/3a7537ab2fa0068e9ddc4a35d049435fbf827dbb/chrome/browser/download/notification/download_notification_manager.h [modify] https://crrev.com/3a7537ab2fa0068e9ddc4a35d049435fbf827dbb/chrome/browser/download/offline_item_model.cc [modify] https://crrev.com/3a7537ab2fa0068e9ddc4a35d049435fbf827dbb/chrome/browser/download/offline_item_model.h [modify] https://crrev.com/3a7537ab2fa0068e9ddc4a35d049435fbf827dbb/chrome/browser/download/offline_item_model_manager.cc [modify] https://crrev.com/3a7537ab2fa0068e9ddc4a35d049435fbf827dbb/chrome/browser/download/offline_item_model_manager.h [modify] https://crrev.com/3a7537ab2fa0068e9ddc4a35d049435fbf827dbb/chrome/browser/download/offline_item_model_manager_factory.cc [modify] https://crrev.com/3a7537ab2fa0068e9ddc4a35d049435fbf827dbb/chrome/browser/ui/views/download/download_item_view.cc [modify] https://crrev.com/3a7537ab2fa0068e9ddc4a35d049435fbf827dbb/chrome/browser/ui/views/download/download_item_view.h [modify] https://crrev.com/3a7537ab2fa0068e9ddc4a35d049435fbf827dbb/chrome/browser/ui/views/download/download_shelf_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6ddfbc505103f71848bc463dd5c598f5b332f86 commit b6ddfbc505103f71848bc463dd5c598f5b332f86 Author: Min Qin <qinmin@chromium.org> Date: Fri Sep 21 19:00:55 2018 Reland "More OfflineItemModel implementation" This reverts commit 3a7537ab2fa0068e9ddc4a35d049435fbf827dbb. Reason for revert: This CL fixes the crash on Chrome OS Asan bots by switching to use DownloadUIModelPtr instead of unique_ptr. This was already done in DownloadItemView in the previous commit effort, but I missed it in DownloadItemNotification. Original change's description: > Revert "More OfflineItemModel implementation" > > This reverts commit 63cb63c9baead3b0345fbb3a9f1e4b15f46db886. > > Reason for revert: Crashing in debug builds: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7920 > > Original change's description: > > More OfflineItemModel implementation > > > > This CL makes OfflineItemModel inherit from DownloadUIModel > > > > Bug: 881499 > > Change-Id: Ic7591f5ce7f5f5243cfeb8ff89ad1e77aa1b78db > > Reviewed-on: https://chromium-review.googlesource.com/1237134 > > Commit-Queue: Min Qin <qinmin@chromium.org> > > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#593030} > > TBR=qinmin@chromium.org,shaktisahu@chromium.org > > Change-Id: I6fb1e7e1ed50df3147efdfa2e57e38577cffacf8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 881499 > Reviewed-on: https://chromium-review.googlesource.com/1238859 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593226} TBR=stevenjb@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org Change-Id: I975e1a38ff8d74a62085a7fc8e941f81d19f08cc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881499 Reviewed-on: https://chromium-review.googlesource.com/1238999 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593283} [modify] https://crrev.com/b6ddfbc505103f71848bc463dd5c598f5b332f86/chrome/browser/download/download_item_model.cc [modify] https://crrev.com/b6ddfbc505103f71848bc463dd5c598f5b332f86/chrome/browser/download/download_item_model.h [modify] https://crrev.com/b6ddfbc505103f71848bc463dd5c598f5b332f86/chrome/browser/download/download_ui_model.h [modify] https://crrev.com/b6ddfbc505103f71848bc463dd5c598f5b332f86/chrome/browser/download/notification/download_item_notification.cc [modify] https://crrev.com/b6ddfbc505103f71848bc463dd5c598f5b332f86/chrome/browser/download/notification/download_item_notification.h [modify] https://crrev.com/b6ddfbc505103f71848bc463dd5c598f5b332f86/chrome/browser/download/notification/download_item_notification_unittest.cc [modify] https://crrev.com/b6ddfbc505103f71848bc463dd5c598f5b332f86/chrome/browser/download/notification/download_notification_manager.cc [modify] https://crrev.com/b6ddfbc505103f71848bc463dd5c598f5b332f86/chrome/browser/download/notification/download_notification_manager.h [modify] https://crrev.com/b6ddfbc505103f71848bc463dd5c598f5b332f86/chrome/browser/download/offline_item_model.cc [modify] https://crrev.com/b6ddfbc505103f71848bc463dd5c598f5b332f86/chrome/browser/download/offline_item_model.h [modify] https://crrev.com/b6ddfbc505103f71848bc463dd5c598f5b332f86/chrome/browser/download/offline_item_model_manager.cc [modify] https://crrev.com/b6ddfbc505103f71848bc463dd5c598f5b332f86/chrome/browser/download/offline_item_model_manager.h [modify] https://crrev.com/b6ddfbc505103f71848bc463dd5c598f5b332f86/chrome/browser/download/offline_item_model_manager_factory.cc [modify] https://crrev.com/b6ddfbc505103f71848bc463dd5c598f5b332f86/chrome/browser/ui/views/download/download_item_view.cc [modify] https://crrev.com/b6ddfbc505103f71848bc463dd5c598f5b332f86/chrome/browser/ui/views/download/download_item_view.h [modify] https://crrev.com/b6ddfbc505103f71848bc463dd5c598f5b332f86/chrome/browser/ui/views/download/download_shelf_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3fdfedc50d1b5d5d5e85fe4940d3f2234045a72 commit a3fdfedc50d1b5d5d5e85fe4940d3f2234045a72 Author: Min Qin <qinmin@chromium.org> Date: Fri Sep 21 23:02:31 2018 Implementation of OfflineItemModel This CL adds implementation of OfflineItemModel. Some of the common functionalities between OfflineItemModel and DownloadItemModel are moved to DownloadUIModel. Bug: 881499 Change-Id: Ic2e4835f4eb16422f152d0ed641dba3e9646defb Reviewed-on: https://chromium-review.googlesource.com/1239334 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#593364} [modify] https://crrev.com/a3fdfedc50d1b5d5d5e85fe4940d3f2234045a72/chrome/browser/download/download_item_model.cc [modify] https://crrev.com/a3fdfedc50d1b5d5d5e85fe4940d3f2234045a72/chrome/browser/download/download_item_model.h [modify] https://crrev.com/a3fdfedc50d1b5d5d5e85fe4940d3f2234045a72/chrome/browser/download/download_ui_model.cc [modify] https://crrev.com/a3fdfedc50d1b5d5d5e85fe4940d3f2234045a72/chrome/browser/download/download_ui_model.h [modify] https://crrev.com/a3fdfedc50d1b5d5d5e85fe4940d3f2234045a72/chrome/browser/download/offline_item_model.cc [modify] https://crrev.com/a3fdfedc50d1b5d5d5e85fe4940d3f2234045a72/chrome/browser/download/offline_item_model.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6f5eba3b2be98ba20ead82a46e4f7963a71111d commit e6f5eba3b2be98ba20ead82a46e4f7963a71111d Author: Shakti Sahu <shaktisahu@chromium.org> Date: Wed Sep 26 21:07:15 2018 Download Shelf : Connect OfflineItem to the shelf This CL connects offline item with the download shelf. Some of the OfflineItemModel methods are still not implemented. Bug: 881499 Change-Id: I2f0cd71815a08bcddfca753378543749389d78db Reviewed-on: https://chromium-review.googlesource.com/1239875 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594471} [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/download/download_core_service_impl.cc [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/download/download_core_service_impl.h [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/download/download_item_model.cc [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/download/download_item_model.h [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/download/download_shelf.cc [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/download/download_shelf.h [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/download/download_shelf_controller.cc [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/download/download_shelf_controller.h [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/download/download_shelf_unittest.cc [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/download/download_ui_controller.cc [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/download/offline_item_model.cc [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/download/offline_item_model.h [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/download/offline_item_model_manager_factory.cc [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/download/offline_item_model_manager_factory.h [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/download/offline_item_utils.cc [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/download/offline_item_utils.h [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/download/test_download_shelf.cc [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/download/test_download_shelf.h [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/offline_pages/android/offline_page_bridge.cc [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/ui/views/download/download_shelf_view.cc [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/chrome/browser/ui/views/download/download_shelf_view.h [modify] https://crrev.com/e6f5eba3b2be98ba20ead82a46e4f7963a71111d/components/offline_items_collection/core/launch_location.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50db3d6ab7f88f43fcf010513859959ddf291555 commit 50db3d6ab7f88f43fcf010513859959ddf291555 Author: Marina Ciocea <marinaciocea@chromium.org> Date: Thu Sep 27 13:10:44 2018 Revert "Download Shelf : Connect OfflineItem to the shelf" This reverts commit e6f5eba3b2be98ba20ead82a46e4f7963a71111d. Reason for revert: looks related to the Win10 Test flakiness reported by findit. Original change's description: > Download Shelf : Connect OfflineItem to the shelf > > This CL connects offline item with the download shelf. Some of > the OfflineItemModel methods are still not implemented. > > Bug: 881499 > Change-Id: I2f0cd71815a08bcddfca753378543749389d78db > Reviewed-on: https://chromium-review.googlesource.com/1239875 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594471} TBR=qinmin@chromium.org,carlosk@chromium.org,shaktisahu@chromium.org Change-Id: I98129d5eaca139d27ab7bb15f3ca194efb1331c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881499, 889790 Reviewed-on: https://chromium-review.googlesource.com/1249068 Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#594697} [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_core_service_impl.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_core_service_impl.h [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_item_model.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_item_model.h [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_shelf.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_shelf.h [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_shelf_controller.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_shelf_controller.h [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_shelf_unittest.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/download_ui_controller.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/offline_item_model.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/offline_item_model.h [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/offline_item_model_manager_factory.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/offline_item_model_manager_factory.h [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/offline_item_utils.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/offline_item_utils.h [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/test_download_shelf.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/download/test_download_shelf.h [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/offline_pages/android/offline_page_bridge.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/ui/views/download/download_shelf_view.cc [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/chrome/browser/ui/views/download/download_shelf_view.h [modify] https://crrev.com/50db3d6ab7f88f43fcf010513859959ddf291555/components/offline_items_collection/core/launch_location.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ceb08fbbd115216cb50c827976595190c6b3d009 commit ceb08fbbd115216cb50c827976595190c6b3d009 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Thu Sep 27 23:56:28 2018 Reland "Download Shelf : Connect OfflineItem to the shelf" This is a reland of e6f5eba3b2be98ba20ead82a46e4f7963a71111d Addresses a case of null handling and an incorrect check. Original change's description: > Download Shelf : Connect OfflineItem to the shelf > > This CL connects offline item with the download shelf. Some of > the OfflineItemModel methods are still not implemented. > > Bug: 881499 > Change-Id: I2f0cd71815a08bcddfca753378543749389d78db > Reviewed-on: https://chromium-review.googlesource.com/1239875 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594471} TBR=carlosk@chromium.org Bug: 881499 Change-Id: I313f0b34e95c4761fe54d5aa4296fd60643ab888 Reviewed-on: https://chromium-review.googlesource.com/1250100 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594921} [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/download/download_core_service_impl.cc [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/download/download_core_service_impl.h [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/download/download_item_model.cc [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/download/download_item_model.h [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/download/download_offline_content_provider.cc [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/download/download_shelf.cc [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/download/download_shelf.h [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/download/download_shelf_controller.cc [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/download/download_shelf_controller.h [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/download/download_shelf_unittest.cc [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/download/download_ui_controller.cc [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/download/offline_item_model.cc [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/download/offline_item_model.h [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/download/offline_item_model_manager_factory.cc [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/download/offline_item_model_manager_factory.h [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/download/offline_item_utils.cc [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/download/offline_item_utils.h [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/download/test_download_shelf.cc [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/download/test_download_shelf.h [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/offline_pages/android/offline_page_bridge.cc [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/ui/views/download/download_shelf_view.cc [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/chrome/browser/ui/views/download/download_shelf_view.h [modify] https://crrev.com/ceb08fbbd115216cb50c827976595190c6b3d009/components/offline_items_collection/core/launch_location.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44a2e6f192177bd280e7aaec12bfdd20f2cf6641 commit 44a2e6f192177bd280e7aaec12bfdd20f2cf6641 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Fri Sep 28 03:33:12 2018 Download shelf : Title for offline item Bug: 881499 Change-Id: Icbf4bdeabbe59f60ff4ca971fd7db868c13e9426 Reviewed-on: https://chromium-review.googlesource.com/1250138 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#594970} [modify] https://crrev.com/44a2e6f192177bd280e7aaec12bfdd20f2cf6641/chrome/browser/download/offline_item_model.cc [modify] https://crrev.com/44a2e6f192177bd280e7aaec12bfdd20f2cf6641/chrome/browser/download/offline_item_model.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bebc3d33f27d10cf3cd70dd1389ff5ff786e43ca commit bebc3d33f27d10cf3cd70dd1389ff5ff786e43ca Author: Shakti Sahu <shaktisahu@chromium.org> Date: Thu Oct 04 17:37:33 2018 Download shelf : Fix for incognito Currently incognito downloads are showing up on the download shelf for normal profile.We need to initialize the DownloadManagerDelegate and DownloadShelfController for incognito. Also we need to filter out the updates for the right profile in the controller since aggregator sends updates for all profiles. Bug: 881499 Change-Id: I309d1673e87de44b870d4efaca606390dd46345e Reviewed-on: https://chromium-review.googlesource.com/c/1257003 Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#596735} [modify] https://crrev.com/bebc3d33f27d10cf3cd70dd1389ff5ff786e43ca/chrome/browser/background_fetch/background_fetch_delegate_factory.cc [modify] https://crrev.com/bebc3d33f27d10cf3cd70dd1389ff5ff786e43ca/chrome/browser/background_fetch/background_fetch_delegate_impl.cc [modify] https://crrev.com/bebc3d33f27d10cf3cd70dd1389ff5ff786e43ca/chrome/browser/download/download_item_model.cc [modify] https://crrev.com/bebc3d33f27d10cf3cd70dd1389ff5ff786e43ca/chrome/browser/download/download_offline_content_provider.cc [modify] https://crrev.com/bebc3d33f27d10cf3cd70dd1389ff5ff786e43ca/chrome/browser/download/download_offline_content_provider.h [modify] https://crrev.com/bebc3d33f27d10cf3cd70dd1389ff5ff786e43ca/chrome/browser/download/download_shelf_controller.cc [modify] https://crrev.com/bebc3d33f27d10cf3cd70dd1389ff5ff786e43ca/chrome/browser/download/notification/download_item_notification_unittest.cc [modify] https://crrev.com/bebc3d33f27d10cf3cd70dd1389ff5ff786e43ca/chrome/browser/download/offline_item_utils.cc [modify] https://crrev.com/bebc3d33f27d10cf3cd70dd1389ff5ff786e43ca/chrome/browser/download/offline_item_utils.h [modify] https://crrev.com/bebc3d33f27d10cf3cd70dd1389ff5ff786e43ca/components/offline_items_collection/core/offline_content_aggregator.cc [modify] https://crrev.com/bebc3d33f27d10cf3cd70dd1389ff5ff786e43ca/components/offline_items_collection/core/offline_content_aggregator.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a88e6621e6d9c44adeaaffc14fc89f8d2ada8d37 commit a88e6621e6d9c44adeaaffc14fc89f8d2ada8d37 Author: David Trainor <dtrainor@chromium.org> Date: Thu Oct 04 22:48:55 2018 Revert "Download shelf : Fix for incognito" This reverts commit bebc3d33f27d10cf3cd70dd1389ff5ff786e43ca. Reason for revert: Causes namespace issues with ontherecord download content ids. Original change's description: > Download shelf : Fix for incognito > > Currently incognito downloads are showing up on the download shelf for > normal profile.We need to initialize the DownloadManagerDelegate and > DownloadShelfController for incognito. Also we need to filter out the > updates for the right profile in the controller since aggregator sends > updates for all profiles. > > Bug: 881499 > Change-Id: I309d1673e87de44b870d4efaca606390dd46345e > Reviewed-on: https://chromium-review.googlesource.com/c/1257003 > Reviewed-by: Min Qin <qinmin@chromium.org> > Reviewed-by: Rayan Kanso <rayankans@chromium.org> > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596735} TBR=dtrainor@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org,rayankans@chromium.org Change-Id: I996da981cb9ccf586a1c6965e65c2a90b687b296 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881499 Reviewed-on: https://chromium-review.googlesource.com/c/1263339 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#596894} [modify] https://crrev.com/a88e6621e6d9c44adeaaffc14fc89f8d2ada8d37/chrome/browser/background_fetch/background_fetch_delegate_factory.cc [modify] https://crrev.com/a88e6621e6d9c44adeaaffc14fc89f8d2ada8d37/chrome/browser/background_fetch/background_fetch_delegate_impl.cc [modify] https://crrev.com/a88e6621e6d9c44adeaaffc14fc89f8d2ada8d37/chrome/browser/download/download_item_model.cc [modify] https://crrev.com/a88e6621e6d9c44adeaaffc14fc89f8d2ada8d37/chrome/browser/download/download_offline_content_provider.cc [modify] https://crrev.com/a88e6621e6d9c44adeaaffc14fc89f8d2ada8d37/chrome/browser/download/download_offline_content_provider.h [modify] https://crrev.com/a88e6621e6d9c44adeaaffc14fc89f8d2ada8d37/chrome/browser/download/download_shelf_controller.cc [modify] https://crrev.com/a88e6621e6d9c44adeaaffc14fc89f8d2ada8d37/chrome/browser/download/notification/download_item_notification_unittest.cc [modify] https://crrev.com/a88e6621e6d9c44adeaaffc14fc89f8d2ada8d37/chrome/browser/download/offline_item_utils.cc [modify] https://crrev.com/a88e6621e6d9c44adeaaffc14fc89f8d2ada8d37/chrome/browser/download/offline_item_utils.h [modify] https://crrev.com/a88e6621e6d9c44adeaaffc14fc89f8d2ada8d37/components/offline_items_collection/core/offline_content_aggregator.cc [modify] https://crrev.com/a88e6621e6d9c44adeaaffc14fc89f8d2ada8d37/components/offline_items_collection/core/offline_content_aggregator.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fa71af8fdd41ec3f43ba6e4c6c53e6488f119a6 commit 7fa71af8fdd41ec3f43ba6e4c6c53e6488f119a6 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Wed Oct 10 00:17:06 2018 Reland "Download shelf : Fix for incognito" This is a reland of bebc3d33f27d10cf3cd70dd1389ff5ff786e43ca The original CL appended an auto-incrementing number to the namespace during registration to the aggregator. That was breaking for downloads in normal profile due to a check in Java for full namespace instead of prefix. Changed the check in Java. Also changed normal profiles to have only the prefix while incognito to have the appended number. Original change's description: > Download shelf : Fix for incognito > > Currently incognito downloads are showing up on the download shelf for > normal profile.We need to initialize the DownloadManagerDelegate and > DownloadShelfController for incognito. Also we need to filter out the > updates for the right profile in the controller since aggregator sends > updates for all profiles. > > Bug: 881499 > Change-Id: I309d1673e87de44b870d4efaca606390dd46345e > Reviewed-on: https://chromium-review.googlesource.com/c/1257003 > Reviewed-by: Min Qin <qinmin@chromium.org> > Reviewed-by: Rayan Kanso <rayankans@chromium.org> > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596735} TBR=rayankans@chromium.org Bug: 881499 Change-Id: I810c40fa5d65fd9ea9b15e6ed416ea1b3a80ae16 Reviewed-on: https://chromium-review.googlesource.com/c/1263559 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#598142} [modify] https://crrev.com/7fa71af8fdd41ec3f43ba6e4c6c53e6488f119a6/chrome/browser/background_fetch/background_fetch_delegate_factory.cc [modify] https://crrev.com/7fa71af8fdd41ec3f43ba6e4c6c53e6488f119a6/chrome/browser/background_fetch/background_fetch_delegate_impl.cc [modify] https://crrev.com/7fa71af8fdd41ec3f43ba6e4c6c53e6488f119a6/chrome/browser/download/download_item_model.cc [modify] https://crrev.com/7fa71af8fdd41ec3f43ba6e4c6c53e6488f119a6/chrome/browser/download/download_offline_content_provider.cc [modify] https://crrev.com/7fa71af8fdd41ec3f43ba6e4c6c53e6488f119a6/chrome/browser/download/download_offline_content_provider.h [modify] https://crrev.com/7fa71af8fdd41ec3f43ba6e4c6c53e6488f119a6/chrome/browser/download/download_shelf_controller.cc [modify] https://crrev.com/7fa71af8fdd41ec3f43ba6e4c6c53e6488f119a6/chrome/browser/download/notification/download_item_notification_unittest.cc [modify] https://crrev.com/7fa71af8fdd41ec3f43ba6e4c6c53e6488f119a6/chrome/browser/download/offline_item_utils.cc [modify] https://crrev.com/7fa71af8fdd41ec3f43ba6e4c6c53e6488f119a6/chrome/browser/download/offline_item_utils.h [modify] https://crrev.com/7fa71af8fdd41ec3f43ba6e4c6c53e6488f119a6/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/LegacyHelpers.java [modify] https://crrev.com/7fa71af8fdd41ec3f43ba6e4c6c53e6488f119a6/components/offline_items_collection/core/offline_content_aggregator.cc [modify] https://crrev.com/7fa71af8fdd41ec3f43ba6e4c6c53e6488f119a6/components/offline_items_collection/core/offline_content_aggregator.h
Comment 1 by bugdroid1@chromium.org
, Sep 7