New issue
Advanced search Search tips

Issue 881498 link

Starred by 1 user
Status: Verified
Owner:
qnnguyen@chromium.org
Closed: Sep 17
Cc:
abodenha@chromium.org
aashuto...@chromium.org
dsunk...@chromium.org
alemate@chromium.org
harpreet@chromium.org
osh...@chromium.org
steve...@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Unable to type credentials from login screen on Captive portal network while adding new user

Project Member Reported by jmuppala@chromium.org, Sep 6 
Chrome Version: 70.0.3538.7
Chrome OS Version: 11021.6.0
Chrome OS Platform: Cyan

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
(1)Connect to Captive Portal network from sign in screen.
(2)Add new user
(3)Unable to enter/type user credentials.

Expected Result:
Should be able to enter credentials for new user

Actual Result:
Unable to type user details.

NOTE:Clicking BACK on the same screen and ADD USER again fixes the issue.


Please see attached video.
captive_portal_add_user.MOV
7.9 MB View Download

Comment 1 by dsunk...@chromium.org, Sep 6

Cc: steve...@chromium.org abodenha@chromium.org
Components: UI>SignIn

Comment 2 by jmuppala@chromium.org, Sep 6 

Please find attached debug logs.
debug-logs_20180906-141629.tgz
661 KB Download

Comment 3 by steve...@chromium.org, Sep 6

Cc: alemate@chromium.org jdufault@chromium.org

Comment 4 by alemate@chromium.org, Sep 6

Cc: osh...@chromium.org
This is now probably about Views-based login.
I don't have any ideas here.

Comment 5 by abodenha@chromium.org, Sep 6

Labels: -ReleaseBlock-Dev ReleaseBlock-Beta
Owner: jdufault@chromium.org
This case is narrow enough that I don't think it should block dev.

Comment 6 by jdufault@chromium.org, Sep 6

Owner: qnnguyen@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 7 by geohsu@chromium.org, Sep 11 

Friendly ping. Checking on the progress of these RBBs, please update with an ETA on fixes if this issue is still an RBB. Otherwise please remove the RBB label. Thanks.

Comment 8 by qnnguyen@chromium.org, Sep 13 

I have a CL awaiting review right now: https://chromium-review.googlesource.com/c/chromium/src/+/1222314
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a755f3b53af00bd4c9004dca1aa0dcdb7697a665

commit a755f3b53af00bd4c9004dca1aa0dcdb7697a665
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Fri Sep 14 17:46:59 2018

cros: Call OnAfterCaptivePortalHidden only after widget is destroyed

This CL fixes the case where displaying the captive portal view and then
closing it would break the Gaia screen email input, preventing users from
typing into the box.

Bug:  881498 
Change-Id: Id79795566fbb4355be7954edc34929ee4cccd524
Reviewed-on: https://chromium-review.googlesource.com/1222314
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591386}
[modify] https://crrev.com/a755f3b53af00bd4c9004dca1aa0dcdb7697a665/chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc
[modify] https://crrev.com/a755f3b53af00bd4c9004dca1aa0dcdb7697a665/chrome/browser/chromeos/login/ui/captive_portal_window_proxy.cc
[modify] https://crrev.com/a755f3b53af00bd4c9004dca1aa0dcdb7697a665/chrome/browser/chromeos/login/ui/captive_portal_window_proxy.h

Comment 10 by qnnguyen@chromium.org, Sep 14

Labels: Merge-Request-70

Comment 11 by geo...@google.com, Sep 14

Labels: -Merge-Request-70 Merge-Approved-70
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 17

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76849b2e7e76099290a3ec0b745a7e8d75d38ba2

commit 76849b2e7e76099290a3ec0b745a7e8d75d38ba2
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Mon Sep 17 16:50:29 2018

cros: Call OnAfterCaptivePortalHidden only after widget is destroyed

This CL fixes the case where displaying the captive portal view and then
closing it would break the Gaia screen email input, preventing users from
typing into the box.

Bug:  881498 
Change-Id: Id79795566fbb4355be7954edc34929ee4cccd524
Reviewed-on: https://chromium-review.googlesource.com/1222314
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591386}(cherry picked from commit a755f3b53af00bd4c9004dca1aa0dcdb7697a665)
Reviewed-on: https://chromium-review.googlesource.com/1228495
Cr-Commit-Position: refs/branch-heads/3538@{#447}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/76849b2e7e76099290a3ec0b745a7e8d75d38ba2/chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc
[modify] https://crrev.com/76849b2e7e76099290a3ec0b745a7e8d75d38ba2/chrome/browser/chromeos/login/ui/captive_portal_window_proxy.cc
[modify] https://crrev.com/76849b2e7e76099290a3ec0b745a7e8d75d38ba2/chrome/browser/chromeos/login/ui/captive_portal_window_proxy.h

Comment 13 by qnnguyen@chromium.org, Sep 17

Status: Fixed (was: Assigned)

Comment 14 by harpreet@chromium.org, Sep 20 

jmuppala@ please test / verify this on a build with the above fix. thanks

Comment 15 by jmuppala@chromium.org, Sep 20

Status: Verified (was: Fixed)
Tested and verified on Cyan 11021.19.0, 70.0.3538.22
►

Sign in to add a comment