New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 881488 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[Play Library]Unable to deselect few apps from Play Library in sign-in flow

Project Member Reported by abod...@chromium.org, Sep 6

Issue description

Chrome OS 11021.6.0, 70.0.3538.7

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
(1)Add user account 
(2)Try to deselect few apps from Play Library in sign-in flow
(3)

Expected Result:
Should able to select/ deselect few apps.
Actual Result:
Unable to deselect few apps from Play Library.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)

What is the impact to the user, and is there a workaround? If so, what is
it?

Please provide any additional information below. Attach a screen shot or
log if possible.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
20180906_121823.mp4
438 KB View Download
Just to clarify, the user cannot deselect an app by clicking the checkmark, but should be able to do that by clicking the chip, right?
yes I can deselect by clicking the chip.
Cc: kellylambert@google.com
Cc: khmel@chromium.org
Yue , would you mind taking over this?

Comment 6 Deleted

Owner: rsgingerrs@chromium.org
Status: Assigned (was: yuecengoogle.com)
Not at all.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/293a9ca249a64ae1a80688ed615a4dbe0d1436ca

commit 293a9ca249a64ae1a80688ed615a4dbe0d1436ca
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Tue Sep 11 01:44:36 2018

Fix a bug that user cannot deselect apps by clicking the checkmark.

Bug:  881488 
Change-Id: Icd1464af653037ea59c20d4b5aa91dd315f9dba8
Reviewed-on: https://chromium-review.googlesource.com/1211962
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590167}
[modify] https://crrev.com/293a9ca249a64ae1a80688ed615a4dbe0d1436ca/chrome/browser/resources/chromeos/arc_support/recommend_app_list_view.js

Labels: Merge-Request-70
Project Member

Comment 10 by sheriffbot@chromium.org, Sep 12

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 13

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f31ea85bd1151ac3677a25af740cd42b1935bafa

commit f31ea85bd1151ac3677a25af740cd42b1935bafa
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Sep 13 00:25:46 2018

Fix a bug that user cannot deselect apps by clicking the checkmark.

TBR=rsgingerrs@chromium.org

(cherry picked from commit 293a9ca249a64ae1a80688ed615a4dbe0d1436ca)

Bug:  881488 
Change-Id: Icd1464af653037ea59c20d4b5aa91dd315f9dba8
Reviewed-on: https://chromium-review.googlesource.com/1211962
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590167}
Reviewed-on: https://chromium-review.googlesource.com/1222911
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#355}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/f31ea85bd1151ac3677a25af740cd42b1935bafa/chrome/browser/resources/chromeos/arc_support/recommend_app_list_view.js

Owner: abod...@chromium.org
Status: Fixed (was: Assigned)
Merged the fix to M70. Please verify.

Sign in to add a comment