New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 881483 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

With a chrome app (extension) in fullscreen, can't escape by swiping up on shelf

Project Member Reported by newcomer@chromium.org, Sep 6

Issue description

With yesterdays ToT, during the bug bash.

1. Bring a chrome app to fullscreen in tablet mode.
2. Swipe up on shelf.

Expected: 
launcher shows up

Actual:
Nothing

 
Cc: kejiashao@chromium.org
Labels: M-71 Pri-2 Type-Bug
Status: Assigned (was: Untriaged)
Components: UI>Shell>Launcher
Labels: m-72
Bulk moving all M-71 <P-1's to M-72.
Labels: -M-71 -m-71
Labels: -M-72 M-71
Status: Started (was: Assigned)
This is almost done, and i will merge soon
Labels: Merge-Request-71
Cc: kbleicher@chromium.org
+kbleicher for merge permissions
Project Member

Comment 9 by sheriffbot@chromium.org, Oct 16

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 17

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5547e63d10a8dbaf60c00a170db6556f91f6ce8e

commit 5547e63d10a8dbaf60c00a170db6556f91f6ce8e
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Oct 17 16:57:13 2018

[merge to 71] applist: Allow swiping up on shelf to show applist when autohide.

TBR=sammiequon@google.com

(cherry picked from commit c035b3ff56f31954c6ac938d5e250d00b4d7a561)

Test: manual
Bug:  881483 ,  891366 
Change-Id: I88c5d7a5d41f7ef4013c84debf5c4e963f891d21
Reviewed-on: https://chromium-review.googlesource.com/c/1279356
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599778}
Reviewed-on: https://chromium-review.googlesource.com/c/1286898
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#88}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/5547e63d10a8dbaf60c00a170db6556f91f6ce8e/ash/app_list/app_list_controller_impl.cc
[modify] https://crrev.com/5547e63d10a8dbaf60c00a170db6556f91f6ce8e/ash/app_list/home_launcher_gesture_handler.cc
[modify] https://crrev.com/5547e63d10a8dbaf60c00a170db6556f91f6ce8e/ash/app_list/home_launcher_gesture_handler.h
[modify] https://crrev.com/5547e63d10a8dbaf60c00a170db6556f91f6ce8e/ash/app_list/home_launcher_gesture_handler_unittest.cc
[modify] https://crrev.com/5547e63d10a8dbaf60c00a170db6556f91f6ce8e/ash/shelf/shelf_layout_manager.cc

Status: Fixed (was: Started)
Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/5547e63d10a8dbaf60c00a170db6556f91f6ce8e

Commit: 5547e63d10a8dbaf60c00a170db6556f91f6ce8e
Author: sammiequon@google.com
Commiter: sammiequon@chromium.org
Date: 2018-10-17 16:57:13 +0000 UTC

[merge to 71] applist: Allow swiping up on shelf to show applist when autohide.

TBR=sammiequon@google.com

(cherry picked from commit c035b3ff56f31954c6ac938d5e250d00b4d7a561)

Test: manual
Bug:  881483 ,  891366 
Change-Id: I88c5d7a5d41f7ef4013c84debf5c4e963f891d21
Reviewed-on: https://chromium-review.googlesource.com/c/1279356
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599778}
Reviewed-on: https://chromium-review.googlesource.com/c/1286898
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#88}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment