New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 881476 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
█ lawrencewu@chromium.org
xhw...@chromium.org
liber...@chromium.org
rkuroiwa@chromium.org
gab@chromium.org
gayane@chromium.org
fdoray@chromium.org
asvitk...@chromium.org
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 662944



Sign in to add a comment

"SafeBrowsingPrefsTest.GetExtendedReportingPrefName_Exhaustive" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Sep 6 
"SafeBrowsingPrefsTest.GetExtendedReportingPrefName_Exhaustive" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySAsSBUZsYWtlIj1TYWZlQnJvd3NpbmdQcmVmc1Rlc3QuR2V0RXh0ZW5kZWRSZXBvcnRpbmdQcmVmTmFtZV9FeGhhdXN0aXZlDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 878587 .

Comment 1 by battre@chromium.org, Sep 10

Cc: asvitk...@chromium.org gab@chromium.org fdoray@chromium.org lawrencewu@chromium.org
 Issue 878587  has been merged into this issue.

Comment 2 by battre@chromium.org, Sep 10 

[ RUN      ] SafeBrowsingPrefsTest.GetExtendedReportingPrefName_Exhaustive

=================================================================
==7084==ERROR: AddressSanitizer: heap-use-after-free on address 0x11a25a9b7f30 at pc 0x7ff7a5adb5da bp 0x000c535fef80 sp 0x000c535fefc8
READ of size 17 at 0x11a25a9b7f30 thread T10
==7084==*** WARNING: Failed to initialize DbgHelp!              ***
==7084==*** Most likely this means that the app is already      ***
==7084==*** using DbgHelp, possibly with incompatible flags.    ***
==7084==*** Due to technical reasons, symbolization might crash ***
==7084==*** or produce wrong results.                           ***
    #0 0x7ff7a5adb602 in __asan_wrap_memcmp C:\b\rr\tmp50yiqi\w\src\third_party\llvm\projects\compiler-rt\lib\sanitizer_common\sanitizer_common_interceptors.inc:827
    #1 0x7ff7a0bb194a in std::_Tree<std::_Tmap_traits<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,v8::internal::CompilationStatistics::OrderedStats,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<const std::basic_string<char,std::char_traits<char>,std::allocator<char> >,v8::internal::CompilationStatistics::OrderedStats> >,0> >::find C:\b\swarming\w\ir\cache\builder\src\third_party\depot_tools\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\VC\Tools\MSVC\14.14.26428\include\xtree:1471
    #2 0x7ff7a5b2836f in base::FeatureList::IsFeatureEnabled C:\b\swarming\w\ir\cache\builder\src\base\feature_list.cc:307
    #3 0x7ff7a5cb510a in base::PlatformThread::SetCurrentThreadPriority C:\b\swarming\w\ir\cache\builder\src\base\threading\platform_thread_win.cc:289
    #4 0x7ff7a5cb525c in base::`anonymous namespace'::ThreadFunc C:\b\swarming\w\ir\cache\builder\src\base\threading\platform_thread_win.cc:77
    #5 0x7ff7a5ace568 in __asan::AsanThread::ThreadStart C:\b\rr\tmp50yiqi\w\src\third_party\llvm\projects\compiler-rt\lib\asan\asan_thread.cc:262
    #6 0x7ffa774c2773 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180012773)
    #7 0x7ffa780c0d50 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x180070d50)

0x11a25a9b7f30 is located 0 bytes inside of 32-byte region [0x11a25a9b7f30,0x11a25a9b7f50)
freed by thread T0 here:
    #0 0x7ff7a5ad7050 in free C:\b\rr\tmp50yiqi\w\src\third_party\llvm\projects\compiler-rt\lib\asan\asan_malloc_win.cc:44
    #1 0x7ff7a5b29c09 in std::_Tree<std::_Tmap_traits<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::FeatureList::OverrideEntry,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<const std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::FeatureList::OverrideEntry> >,0> >::_Erase C:\b\swarming\w\ir\cache\builder\src\third_party\depot_tools\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\VC\Tools\MSVC\14.14.26428\include\xtree:2075
    #2 0x7ff7a5b2968f in std::_Tree<std::_Tmap_traits<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::FeatureList::OverrideEntry,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<const std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::FeatureList::OverrideEntry> >,0> >::erase C:\b\swarming\w\ir\cache\builder\src\third_party\depot_tools\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\VC\Tools\MSVC\14.14.26428\include\xtree:1444
    #3 0x7ff7a5b253bb in base::FeatureList::~FeatureList C:\b\swarming\w\ir\cache\builder\src\base\feature_list.cc:86
    #4 0x7ff7a6a3366c in base::test::ScopedFeatureList::~ScopedFeatureList C:\b\swarming\w\ir\cache\builder\src\base\test\scoped_feature_list.cc:98
    #5 0x7ff79f704859 in std::unique_ptr<base::test::ScopedFeatureList,std::default_delete<base::test::ScopedFeatureList> >::reset C:\b\swarming\w\ir\cache\builder\src\third_party\depot_tools\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\VC\Tools\MSVC\14.14.26428\include\memory:2304
    #6 0x7ff79f6fd4c3 in safe_browsing::SafeBrowsingPrefsTest::ResetExperiments C:\b\swarming\w\ir\cache\builder\src\components\safe_browsing\common\safe_browsing_prefs_unittest.cc:57
    #7 0x7ff79f6fc611 in safe_browsing::SafeBrowsingPrefsTest::TestGetPrefName C:\b\swarming\w\ir\cache\builder\src\components\safe_browsing\common\safe_browsing_prefs_unittest.cc:72
    #8 0x7ff79f6fcc02 in safe_browsing::SafeBrowsingPrefsTest_GetExtendedReportingPrefName_Exhaustive_Test::TestBody C:\b\swarming\w\ir\cache\builder\src\components\safe_browsing\common\safe_browsing_prefs_unittest.cc:137
    #9 0x7ff79fc4981e in testing::Test::Run C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2522
    #10 0x7ff79fc4b23f in testing::TestInfo::Run C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2698
    #11 0x7ff79fc4c2dd in testing::TestCase::Run C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2816
    #12 0x7ff79fc65c57 in testing::internal::UnitTestImpl::RunAllTests C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:5182
    #13 0x7ff79fc6519f in testing::UnitTest::Run C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:4791
    #14 0x7ff7a6a43315 in base::TestSuite::Run C:\b\swarming\w\ir\cache\builder\src\base\test\test_suite.cc:295
    #15 0x7ff7a6a48ad9 in base::`anonymous namespace'::LaunchUnitTestsInternal C:\b\swarming\w\ir\cache\builder\src\base\test\launcher\unit_test_launcher.cc:224
    #16 0x7ff7a6a48626 in base::LaunchUnitTests C:\b\swarming\w\ir\cache\builder\src\base\test\launcher\unit_test_launcher.cc:575
    #17 0x7ff79e596866 in main C:\b\swarming\w\ir\cache\builder\src\components\test\run_all_unittests.cc:20
    #18 0x7ff7b053b6b7 in __scrt_common_main_seh f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283
    #19 0x7ffa774c2773 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180012773)
    #20 0x7ffa780c0d50 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x180070d50)

previously allocated by thread T0 here:
    #0 0x7ff7a5ad7120 in malloc C:\b\rr\tmp50yiqi\w\src\third_party\llvm\projects\compiler-rt\lib\asan\asan_malloc_win.cc:60
    #1 0x7ff7b051857a in operator new f:\dd\vctools\crt\vcstartup\src\heap\new_scalar.cpp:35
    #2 0x7ff79a7e47c6 in std::basic_string<char,std::char_traits<char>,std::allocator<char> >::_Reallocate_for<`lambda at ..\..\third_party\depot_tools\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\VC\Tools\MSVC\14.14.26428\include\xstring:2650:35',const char *> C:\b\swarming\w\ir\cache\builder\src\third_party\depot_tools\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\VC\Tools\MSVC\14.14.26428\include\xstring:3872
    #3 0x7ff7a5b26013 in base::FeatureList::RegisterOverride C:\b\swarming\w\ir\cache\builder\src\base\feature_list.cc:375
    #4 0x7ff7a5b25a70 in base::FeatureList::RegisterOverridesFromCommandLine C:\b\swarming\w\ir\cache\builder\src\base\feature_list.cc:354
    #5 0x7ff7a5b254f5 in base::FeatureList::InitializeFromCommandLine C:\b\swarming\w\ir\cache\builder\src\base\feature_list.cc:96
    #6 0x7ff7a6a33f26 in base::test::ScopedFeatureList::InitFromCommandLine C:\b\swarming\w\ir\cache\builder\src\base\test\scoped_feature_list.cc:121
    #7 0x7ff79f6fd5b8 in safe_browsing::SafeBrowsingPrefsTest::ResetExperiments C:\b\swarming\w\ir\cache\builder\src\components\safe_browsing\common\safe_browsing_prefs_unittest.cc:58
    #8 0x7ff79f6fc611 in safe_browsing::SafeBrowsingPrefsTest::TestGetPrefName C:\b\swarming\w\ir\cache\builder\src\components\safe_browsing\common\safe_browsing_prefs_unittest.cc:72
    #9 0x7ff79f6fcbed in safe_browsing::SafeBrowsingPrefsTest_GetExtendedReportingPrefName_Exhaustive_Test::TestBody C:\b\swarming\w\ir\cache\builder\src\components\safe_browsing\common\safe_browsing_prefs_unittest.cc:136
    #10 0x7ff79fc4981e in testing::Test::Run C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2522
    #11 0x7ff79fc4b23f in testing::TestInfo::Run C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2698
    #12 0x7ff79fc4c2dd in testing::TestCase::Run C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2816
    #13 0x7ff79fc65c57 in testing::internal::UnitTestImpl::RunAllTests C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:5182
    #14 0x7ff79fc6519f in testing::UnitTest::Run C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:4791
    #15 0x7ff7a6a43315 in base::TestSuite::Run C:\b\swarming\w\ir\cache\builder\src\base\test\test_suite.cc:295
    #16 0x7ff7a6a48ad9 in base::`anonymous namespace'::LaunchUnitTestsInternal C:\b\swarming\w\ir\cache\builder\src\base\test\launcher\unit_test_launcher.cc:224
    #17 0x7ff7a6a48626 in base::LaunchUnitTests C:\b\swarming\w\ir\cache\builder\src\base\test\launcher\unit_test_launcher.cc:575
    #18 0x7ff79e596866 in main C:\b\swarming\w\ir\cache\builder\src\components\test\run_all_unittests.cc:20
    #19 0x7ff7b053b6b7 in __scrt_common_main_seh f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283
    #20 0x7ffa774c2773 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180012773)
    #21 0x7ffa780c0d50 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x180070d50)

Thread T10 created by T0 here:
    #0 0x7ff7a5acd3e0 in __asan_wrap_CreateThread C:\b\rr\tmp50yiqi\w\src\third_party\llvm\projects\compiler-rt\lib\asan\asan_win.cc:146
    #1 0x7ff7a5cb49de in base::`anonymous namespace'::CreateThreadInternal C:\b\swarming\w\ir\cache\builder\src\base\threading\platform_thread_win.cc:139
    #2 0x7ff7add7c23f in base::internal::SchedulerWorker::Start C:\b\swarming\w\ir\cache\builder\src\base\task\task_scheduler\scheduler_worker.cc:77
    #3 0x7ff7abef0937 in base::internal::SchedulerWorkerPoolImpl::CreateRegisterAndStartSchedulerWorkerLockRequired C:\b\swarming\w\ir\cache\builder\src\base\task\task_scheduler\scheduler_worker_pool_impl.cc:898
    #4 0x7ff7abef01eb in base::internal::SchedulerWorkerPoolImpl::Start C:\b\swarming\w\ir\cache\builder\src\base\task\task_scheduler\scheduler_worker_pool_impl.cc:249
    #5 0x7ff7a9719306 in base::internal::TaskSchedulerImpl::Start C:\b\swarming\w\ir\cache\builder\src\base\task\task_scheduler\task_scheduler_impl.cc:172
    #6 0x7ff7a6a37a31 in base::test::ScopedTaskEnvironment::ScopedTaskEnvironment C:\b\swarming\w\ir\cache\builder\src\base\test\scoped_task_environment.cc:144
    #7 0x7ff7a820ca96 in content::TestBrowserThreadBundle::Init C:\b\swarming\w\ir\cache\builder\src\content\public\test\test_browser_thread_bundle.cc:116
    #8 0x7ff7a820c35f in content::TestBrowserThreadBundle::TestBrowserThreadBundle C:\b\swarming\w\ir\cache\builder\src\content\public\test\test_browser_thread_bundle.cc:38
    #9 0x7ff79f70474e in testing::internal::TestFactoryImpl<safe_browsing::SafeBrowsingPrefsTest_GetExtendedReportingPrefName_Exhaustive_Test>::CreateTest C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\include\gtest\internal\gtest-internal.h:472
    #10 0x7ff79fc4b21b in testing::TestInfo::Run C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2689
    #11 0x7ff79fc4c2dd in testing::TestCase::Run C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2816
    #12 0x7ff79fc65c57 in testing::internal::UnitTestImpl::RunAllTests C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:5182
    #13 0x7ff79fc6519f in testing::UnitTest::Run C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:4791
    #14 0x7ff7a6a43315 in base::TestSuite::Run C:\b\swarming\w\ir\cache\builder\src\base\test\test_suite.cc:295
    #15 0x7ff7a6a48ad9 in base::`anonymous namespace'::LaunchUnitTestsInternal C:\b\swarming\w\ir\cache\builder\src\base\test\launcher\unit_test_launcher.cc:224
    #16 0x7ff7a6a48626 in base::LaunchUnitTests C:\b\swarming\w\ir\cache\builder\src\base\test\launcher\unit_test_launcher.cc:575
    #17 0x7ff79e596866 in main C:\b\swarming\w\ir\cache\builder\src\components\test\run_all_unittests.cc:20
    #18 0x7ff7b053b6b7 in __scrt_common_main_seh f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283
    #19 0x7ffa774c2773 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180012773)
    #20 0x7ffa780c0d50 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x180070d50)

SUMMARY: AddressSanitizer: heap-use-after-free C:\b\rr\tmp50yiqi\w\src\third_party\llvm\projects\compiler-rt\lib\sanitizer_common\sanitizer_common_interceptors.inc:827 in __asan_wrap_memcmp
Shadow bytes around the buggy address:
  0x03d0a5a36f90: fa fa fd fd fd fd fa fa fd fd fd fd fa fa fd fd
  0x03d0a5a36fa0: fd fd fa fa fd fd fd fd fa fa fd fd fd fd fa fa
  0x03d0a5a36fb0: fd fd fd fd fa fa fd fd fd fd fa fa fd fd fd fd
  0x03d0a5a36fc0: fa fa fd fd fd fd fa fa fd fd fd fd fa fa fd fd
  0x03d0a5a36fd0: fd fd fa fa fd fd fd fd fa fa fd fd fd fd fa fa
=>0x03d0a5a36fe0: fd fd fd fd fa fa[fd]fd fd fd fa fa fd fd fd fd
  0x03d0a5a36ff0: fa fa fd fd fd fd fa fa fd fd fd fd fa fa fd fd
  0x03d0a5a37000: fd fd fa fa fd fd fd fd fa fa fd fd fd fd fa fa
  0x03d0a5a37010: fd fd fd fd fa fa fd fd fd fd fa fa fd fd fd fd
  0x03d0a5a37020: fa fa 00 00 00 00 fa fa fd fd fd fd fa fa 00 00
  0x03d0a5a37030: 00 00 fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
  Shadow gap:              cc
==7084==ABORTING

Comment 3 by battre@chromium.org, Sep 10 

From a windows bot: https://chromium-swarm.appspot.com/task?id=3fda9c75846dbe10&refresh=10&show_raw=1

[ RUN      ] SafeBrowsingPrefsTest.GetExtendedReportingPrefName_Exhaustive
Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
	std::_Tree<std::_Tmap_traits<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::Feature const * __ptr64,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<std::basic_string<cha [0x00007FF897AC1E3F+63]
	std::_Tree<std::_Tmap_traits<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::Feature const * __ptr64,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<std::basic_string<cha [0x00007FF897AC1D4C+76]
	??$_Try_emplace@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@$$V@?$map@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@PEBUFeature@base@@U?$less@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@2@V?$allocator@U [0x00007FF897AC207D+109]
	??$try_emplace@$$V@?$map@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@PEBUFeature@base@@U?$less@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@2@V?$allocator@U?$pair@$$CBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@ [0x00007FF897AC1FE4+68]
	std::map<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::Feature const * __ptr64,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<std::basic_string<char,std::char_traits<c [0x[1332:1112:0909/214902.989:6671921:FATAL:lock.cc(19)] Check failed: owning_thread_ref_.is_null(). 
Backtrace:
	base::debug::StackTrace::StackTrace [0x00007FF897AA1915+101]
	base::debug::StackTrace::StackTrace [0x00007FF897AA094F+31]
	logging::LogMessage::~LogMessage [0x00007FF897B091C6+134]
	base::Lock::~Lock [0x00007FF897C7E2CE+174]
	base::FeatureList::~FeatureList [0x00007FF897AB7B33+51]
	std::default_delete<base::FeatureList>::operator() [0x00007FF7A27AE10D+45]
	std::unique_ptr<base::FeatureList,std::default_delete<base::FeatureList> >::~unique_ptr<base::FeatureList,std::default_delete<base::FeatureList> > [0x00007FF7A279E82B+75]
	base::test::ScopedFeatureList::~ScopedFeatureList [0x00007FF7A735037C+188]
	std::default_delete<base::test::ScopedFeatureList>::operator() [0x00007FF7A4CE3CFC+44]
	std::unique_ptr<base::test::ScopedFeatureList,std::default_delete<base::test::ScopedFeatureList> >::reset [0x00007FF7A4CE4104+100]
	safe_browsing::SafeBrowsingPrefsTest::ResetExperiments [0x00007FF7A4CDFBBB+283]
	safe_browsing::SafeBrowsingPrefsTest::TestGetPrefName [0x00007FF7A4CDF1A0+128]
	safe_browsing::SafeBrowsingPrefsTest_GetExtendedReportingPrefName_Exhaustive_Test::TestBody [0x00007FF7A4CDF5C8+344]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x00007FF7A50B684F+79]
	testing::Test::Run [0x00007FF7A50B67BC+172]
	testing::TestInfo::Run [0x00007FF7A50B742A+218]
	testing::TestCase::Run [0x00007FF7A50B7FA3+243]
	testing::internal::UnitTestImpl::RunAllTests [0x00007FF7A50C195D+765]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x00007FF7A50C1645+85]
	testing::UnitTest::Run [0x00007FF7A50C1483+307]
	RUN_ALL_TESTS [0x00007FF7A73652C1+17]
	base::TestSuite::Run [0x00007FF7A7364853+163]
	content::UnitTestTestSuite::Run [0x00007FF7A845BB7B+27]
	??$Invoke@P8UnitTestTestSuite@content@@EAAHXZV?$unique_ptr@VUnitTestTestSuite@content@@U?$default_delete@VUnitTestTestSuite@content@@@std@@@std@@$$V@?$FunctorTraits@P8UnitTestTestSuite@content@@EAAHXZX@internal@base@@SAHP8UnitTestTestSuite@content@@EAAHXZ [0x00007FF7A6B4FB1F+31]
	base::internal::InvokeHelper<0,int>::MakeItSo<int (__cdecl content::UnitTestTestSuite::*)(void) __ptr64,std::unique_ptr<content::UnitTestTestSuite,std::default_delete<content::UnitTestTestSuite> > > [0x00007FF7A6B4FA94+52]
	base::internal::Invoker<base::internal::BindState<int (__cdecl content::UnitTestTestSuite::*)(void) __ptr64,std::unique_ptr<content::UnitTestTestSuite,std::default_delete<content::UnitTestTestSuite> > >,int __cdecl(void)>::RunImpl<int (__cdecl content::Un [0x00007FF7A6B4FA39+73]
	base::internal::Invoker<base::internal::BindState<int (__cdecl content::UnitTestTestSuite::*)(void) __ptr64,std::unique_ptr<content::UnitTestTestSuite,std::default_delete<content::UnitTestTestSuite> > >,int __cdecl(void)>::RunOnce [0x00007FF7A6B4F906+70]
	base::OnceCallback<int __cdecl(void)>::Run [0x00007FF7A736BDB2+98]
	base::LaunchUnitTests [0x00007FF7A7369F10+752]
	base::LaunchUnitTests [0x00007FF7A7369D1D+253]
	main [0x00007FF7A41E5B8B+123]
	invoke_main [0x00007FF7A9E230C4+52] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:79)
	__scrt_common_main_seh [0x00007FF7A9E231F4+292] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
	__scrt_common_main [0x00007FF7A9E2327E+14] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:326)
	mainCRTStartup [0x00007FF7A9E23299+9] (f:\dd\vctools\crt\vcstartup\src\startup\exe_main.cpp:17)
	BaseThreadInitThunk [0x00007FF8B74A2774+20]
	RtlUserThreadStart [0x00007FF8B7B30D51+33]

00007FF897ABB226+70]
	base::FeatureList::CheckFeatureIdentity [0x[9290/14240] SafeBrowsingPrefsTest.GetExtendedReportingPrefName_Exhaustive (CRASHED)

Comment 4 by battre@chromium.org, Sep 10

Labels: Test-Disabled
My intuition is that FeatureList::IsEnabled() must not be used (see PlatformThread::SetCurrentThreadPriority) in the presence of ScopedFeatureLists. But I have to admit that I am puzzled as well why this is happening.

According to the flakyness dashboard, all SafeBrowsingPrefsTest.* tests are affected on windows, so I will disable those. I am asking jialiul@ as the test-owner to follow up with the respective folks on this bugs to make sure that this gets addressed (I have too much in my sheriff queue to work more on this).

Comment 5 by battre@chromium.org, Sep 10

Labels: -Sheriff-Chromium
Owner: jialiul@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/628c1e15a3143e0d9bb760fdf1207315992feb4d

commit 628c1e15a3143e0d9bb760fdf1207315992feb4d
Author: Dominic Battre <battre@chromium.org>
Date: Mon Sep 10 12:10:02 2018

Disable flaky tests in SafeBrowsingPrefsTest.*

Several tests crash flakily (see crbug.com/881476) on Windows. This CL disables
those CLs.

TBR=jialiul@chromium.org,fdoray@chromium.org,asvitkine@chromium.org

Bug: 881476,872820
Change-Id: I73104af5fc5a9215c313e06c3ecc77dcf426100c
Reviewed-on: https://chromium-review.googlesource.com/1215862
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589889}
[modify] https://crrev.com/628c1e15a3143e0d9bb760fdf1207315992feb4d/components/safe_browsing/common/safe_browsing_prefs_unittest.cc

Comment 7 by fdoray@chromium.org, Sep 10 

Changing the global feature list while you have multiple active threads (cf. TestBrowserThreadBundle below) is inherently unsafe, because nothing guarantees you that the threads aren't accessing the feature list while it is being changed. You can try clearing the TestBrowserThreadBundle before resetting the global feature list (this will join all threads). You can re-instantiate the TestBrowserThreadBundle after having set the new feature list.

Comment 8 by gab@chromium.org, Sep 10

Cc: gayane@chromium.org
ScopedFeatureList is flaky when mixed with threading. It needs to outlive the TestBrowserThreadBundle (or ScopedTaskEnvironment) in tests where it's used.

asvitkine/gayane were working on a a fix to the ScopedFeatureList API to make such races harder to introduce.

Comment 9 by jialiul@chromium.org, Sep 10

Components: Services>Safebrowsing
Labels: OS-Windows

Comment 10 by jialiul@chromium.org, Sep 10 

In fact, these disabled tests are no longer needed (features are enabled by default).
We'll do a code clean up to remove these tests.

Comment 11 by jialiul@chromium.org, Sep 10

Labels: -Pri-1 Pri-3

Comment 12 by jialiul@chromium.org, Sep 11

Owner: ----
Status: Available (was: Assigned)

Comment 13 by jialiul@chromium.org, Sep 12

Blocking: 662944

Comment 14 by jialiul@chromium.org, Sep 12

Labels: SafeBrowsing-Triaged
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d44daa00c9e3704579d15097bd9e3694b0064eb1

commit d44daa00c9e3704579d15097bd9e3694b0064eb1
Author: Luke Zielinski <lpz@chromium.org>
Date: Tue Oct 09 18:00:09 2018

Remove legacy SBER opt-in text.

Also removes methods that were used to choose between legacy and scout
texts. The scout text is the only one that is being used going forward.

Bug: 662944,881476
Change-Id: I49e08658021494994884e48d836d07e047582f93
Reviewed-on: https://chromium-review.googlesource.com/c/1269938
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597987}
[modify] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/android_webview/ui/grit_strings_whitelist.txt
[modify] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/chrome/browser/ssl/cert_report_helper.cc
[modify] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/components/safe_browsing/common/safe_browsing_prefs.cc
[modify] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/components/safe_browsing/common/safe_browsing_prefs.h
[modify] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/components/safe_browsing/common/safe_browsing_prefs_unittest.cc
[modify] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/components/security_interstitials/core/safe_browsing_loud_error_ui.cc
[modify] https://crrev.com/d44daa00c9e3704579d15097bd9e3694b0064eb1/components/security_interstitials_strings.grdp

Comment 16 by xhw...@chromium.org, Dec 18 

A similar crash happens in D3D11VideoDecoderTest, tracked by  issue 915947 .

[ RUN      ] D3D11VideoDecoderTest.DoesNotSupportEncryptionWithoutFlag
Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
        std::_Tree<std::_Tmap_traits<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,const base::Feature *,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<const std::basic_string<char, [0x00007FFE9DC397B0+48] (C:/src/chrome/src/out/Debug\..\..\third_party\depot_tools\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\VC\Tools\MSVC\14.14.26428\include\xtree:2096)
        std::_Tree<std::_Tmap_traits<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,const base::Feature *,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<const std::basic_string<char, [0x00007FFE9DC3970C+76] (C:/src/chrome/src/out/Debug\..\..\third_party\depot_tools\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\VC\Tools\MSVC\14.14.26428\include\xtree:1528)
        std::_Tree<std::_Tmap_traits<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,const base::Feature *,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<const std::basic_string<char, [0x00007FFE9DC34166+70] (C:/src/chrome/src/out/Debug\..\..\third_party\depot_tools\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\VC\Tools\MSVC\14.14.26428\include\xtree:1472)
        base::FeatureList::CheckFeatureIdentity [0x00007FFE9DC33B54+164] (C:/src/chrome/src/out/Debug\..\..\base\feature_list.cc:422)
        base::FeatureList::IsFeatureEnabled [0x00007FFE9DC32D97+423] (C:/src/chrome/src/out/Debug\..\..\base\feature_list.cc:305)
        base::FeatureList::IsEnabled [0x00007FFE9DC32BD7+71] (C:/src/chrome/src/out/Debug\..\..\base\feature_list.cc:204)
        base::PlatformThread::SetCurrentThreadPriorityImpl [0x00007FFE9DE8689A+58] (C:/src/chrome/src/out/Debug\..\..\base\threading\platform_thread_win.cc:307)
        base::PlatformThread::SetCurrentThreadPriority [0x00007FFE9DE85AB2+50] (C:/src/chrome/src/out/Debug\..\..\base\threading\platform_thread.cc:33)
        base::`anonymous namespace'::ThreadFunc [0x00007FFE9DE871C6+134] (C:/src/chrome/src/out/Debug\..\..\base\threading\platform_thread_win.cc:79)
        BaseThreadInitThunk [0x0000

Comment 17 by xhw...@chromium.org, Dec 20

Cc: rkuroiwa@chromium.org liber...@chromium.org xhw...@chromium.org
 Issue 915947  has been merged into this issue.
►

Sign in to add a comment