New issue
Advanced search Search tips

Issue 881475 link

Starred by 1 user
Status: Fixed
Owner:
msw@chromium.org
Closed: Sep 20
Cc:
msw@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

NOTIMPLEMENTED() in GetInputMethodKeyboardController

Project Member Reported by skobes@chromium.org, Sep 6 
Chrome Version       : ToT (r588843)
OS Version           : Linux
URLs (if applicable) : about:blank
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari:
    Firefox:
    IE/Edge:

What steps will reproduce the problem?
1. Click in the address bar

What is the expected result?
no log spam

What happens instead of that?
[49592:49592:0906/150702.434846:ERROR:input_method_base.cc(146)] Not implemented reached in virtual ui::InputMethodKeyboardController *ui::InputMethodBase::GetInputMethodKeyboardController()Using InputMethodKeyboardControllerStub

Looks like r585418 added this line.

Comment 1 by msw@chromium.org, Sep 12

Owner: msw@chromium.org
Status: Assigned (was: Unconfirmed)
Perhaps a valid InputMethodKeyboardController is not needed on Linux.
(I suppose desktop OS virtual keyboards could be hooked up some other way?)
While it's only logged once, I agree that this is prominent log spam... I'll remove it.

Comment 2 by msw@chromium.org, Sep 18

Status: Started (was: Assigned)
I have a CL awaiting feedback: https://crrev.com/c/1222349
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/588bebfb18308a30b009816c4d214b6c4263c16b

commit 588bebfb18308a30b009816c4d214b6c4263c16b
Author: Mike Wasserman <msw@chromium.org>
Date: Thu Sep 20 18:07:11 2018

Remove InputMethodBase log spam, let keyboard controller be null.

Do not construct a stub InputMethodKeyboardController, check for null.
Also cleanup StubInputController decl and use NOTIMPLEMENTED_LOG_ONCE.

Bug:  881475 
Test: No functional changes, less debug log spam.
Change-Id: Ib8db1778f1ae09227bf559f1bb2fe6ac752649d2
Reviewed-on: https://chromium-review.googlesource.com/1222349
Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592875}
[modify] https://crrev.com/588bebfb18308a30b009816c4d214b6c4263c16b/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/588bebfb18308a30b009816c4d214b6c4263c16b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/588bebfb18308a30b009816c4d214b6c4263c16b/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/588bebfb18308a30b009816c4d214b6c4263c16b/ui/base/ime/input_method_base.cc
[modify] https://crrev.com/588bebfb18308a30b009816c4d214b6c4263c16b/ui/ozone/public/input_controller.cc

Comment 4 by msw@chromium.org, Sep 20

Status: Fixed (was: Started)
►

Sign in to add a comment