New issue
Advanced search Search tips

Issue 881469 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Enable Surface Synchronization on Android WebView

Project Member Reported by fsam...@chromium.org, Sep 6

Issue description

We should ensure that surface synchronization works on android webview.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a91df97e284e497ecf1222b4ada5af66306718a5

commit a91df97e284e497ecf1222b4ada5af66306718a5
Author: Ned Nguyen <nednguyen@google.com>
Date: Thu Sep 06 21:40:05 2018

Disable Surface Synchronization on Webview

Bug:881469, 879151
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I419072d72f2bae1352f97a1283892f4ec5b5d04c

NOTRY=true # ios-simulator flake

Change-Id: I419072d72f2bae1352f97a1283892f4ec5b5d04c
Reviewed-on: https://chromium-review.googlesource.com/1211463
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589316}
[modify] https://crrev.com/a91df97e284e497ecf1222b4ada5af66306718a5/tools/perf/core/perf_benchmark.py

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/150c405cac8a7f14bcae30a4e2497763013252df

commit 150c405cac8a7f14bcae30a4e2497763013252df
Author: Eric Karl <ericrk@chromium.org>
Date: Fri Sep 21 20:04:36 2018

Disable Surface Synchronization for DualBrowserStorySet's WebView

DualBrowserStorySet uses non-standard set-up to create its webview,
missing the previous option customization added to PerfBenchmark's
CustomizeBrowserOptions. While this should probably be unified,
copying the relevant options over for now to un-break the dual browser
case.

Also disables VizDisplayCompositor, as this is a related unsupported
feature, and although things happen to work now, we don't want to rely
on that.

Bug: 881469
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I1070210c2a92768795689d4488369c0b589ca9bb
Reviewed-on: https://chromium-review.googlesource.com/1236468
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#593312}
[modify] https://crrev.com/150c405cac8a7f14bcae30a4e2497763013252df/tools/perf/core/perf_benchmark.py
[modify] https://crrev.com/150c405cac8a7f14bcae30a4e2497763013252df/tools/perf/page_sets/dual_browser_story.py

Sign in to add a comment