New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 881443 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Feature



Sign in to add a comment

[autofill] trigger deletion of disused data on every start

Project Member Reported by rogerm@chromium.org, Sep 6

Issue description

We only attempt to delete disused autofill data on major version upgrades.

Proposal:

Instead check for and delete disused data on each start up. For most startups this will be a NOP. This will allow us to clean up the tracking pref that stores the last version for which the deletion was attempted. It will also mean that data is deleted as soon as there's a restart after it crosses the deletion threshold.

Things to check:

 - Does checking for deletability on each start noticeably affect startup
   time metrics?
 
Summary: [autofill] trigger deletion of disused data on every start (was: [autofill] trigger deletion os disused data on every start)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e81c896a17bbd219168ff16922d2b3906f12eeb7

commit e81c896a17bbd219168ff16922d2b3906f12eeb7
Author: Roger McFarlane <rogerm@chromium.org>
Date: Thu Sep 27 18:08:42 2018

[autofill] Check for and delete disused data on every startup.

This CL removes the last-version-... pref check/update that causes
deletion of disused data to be run at most once per major version.
Instead, it will be attempted at each startup.

Bug:  881443 
Change-Id: Ie6fbae3a9c29d67af28d842f02014a1274d10540
Reviewed-on: https://chromium-review.googlesource.com/1211086
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594781}
[modify] https://crrev.com/e81c896a17bbd219168ff16922d2b3906f12eeb7/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/e81c896a17bbd219168ff16922d2b3906f12eeb7/components/autofill/core/browser/personal_data_manager_unittest.cc

Owner: rogerm@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment