New issue
Advanced search Search tips

Issue 881441 link

Starred by 1 user

Issue metadata

Status: Started
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

shift-tab should restore original text

Reported by rom7...@gmail.com, Sep 6

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.81 Safari/537.36

Steps to reproduce the problem:
1. Type "goo"
2. Press Tab
3. Press Shift-Tab

What is the expected behavior?
Address bar should contain "goo"

What went wrong?
Address bar contains "google.com"

Did this work before? N/A 

Chrome version: 69.0.3497.81  Channel: stable
OS Version: Ubuntu 17.10
Flash Version:
 
Labels: Needs-Triage-M69
Cc: viswa.karala@chromium.org
Labels: Needs-Feedback Triaged-ET
Unable to reproduce the issue on chrome reported version# 69.0.3497.81 using Ubuntu 17.10 with steps mentioned below:
1) Launched chrome reported version and in New Tab Page typed "goo"
2) Pressed "Tab" and pressed "Shift-Tab", able to see "goo" in address bar.

@Reporter: Please find the attached screencast for your reference and provide your feedback on it. Try to test this issue by creating new person with no apps and extensions in it and let us know if the issue still persists.

Thanks!
881441.mp4
5.0 MB View Download
Here is a reproduction of the issue. It only happens when there's a suggested URL, not when there's a suggested search.
Sep 7 2018 11_33 AM.webm
1.2 MB View Download
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 7

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: -UI UI>Browser>Omnibox
Owner: tommycli@chromium.org
Status: Untriaged (was: Unconfirmed)
Labels: OS-Mac OS-Windows
Owner: ----
I think we discussed this at some point in the past.  Leaving as untriaged because until we decide that it's something we want to change.  Hopefully someone has good code review search / chromium bug search capabilities and can find the discussion.  I can't.

Cc: mpear...@chromium.org
@mpearson, I don't have history, but tried to find a dupe - is it captured by the more general crbug.com/583049 (comments 30+?)
Bug 583049 was only about meant to be about undoing in the sense of control-z, not shift-tab.  But reading the original reporter's summary statement (correct me if I'm wrong), I think they'd be satisfied with undo like control-z, if it worked right.  So feel free to morph the other bug to make it clearer and mark this as a dup.
Original reporter would not be satisfied with undo like ctrl-z, because behavior would be inconsistent :)

Sometimes it would be undone with shift-tab, other times with ctrl-z. It doesn't feel natural. Pick one and stick to it.
IMHO, it should be shift-tab because it's what's used to navigate choices in the omnibox. Let's say the user is already a few choices down the list, then tries to go back, they would naturally shift-tab, but then they'd have to switch to ctrl-z when they realize that it's not possible to shift-tab more.
Components: -UI>Browser>Omnibox UI>Browser>Omnibox>TabToSearch
Labels: -Pri-2 Hotlist-Polish Hotlist-OmniboxKeyboardShortcuts OS-Chrome Pri-3
Status: Available (was: Untriaged)
Summary: shift-tab should restore original text (was: After pressing tab in the address bar, there's no way to come back to the original input)
Point well taken.  Tab in the dropdown is reversed by shift-tab; just because an item happens to be first in the dropdown (i.e., an inline autocompletion), it should still be reversed by shift-tab.  We'll have to be careful to get the selection right.  For example, crb -> inline autocompletes to crbug.com for me, with a tab-to-search.  When I tab in and tab out, I should see the regular text crb and the selected inline autocompletion text of ug.com.

Comment 12 by manukh@chromium.org, Jan 17 (5 days ago)

Status: Started (was: Available)

Sign in to add a comment