Issue metadata
Sign in to add a comment
|
Redirect logged out 404 to login page |
||||||||||||||||||||
Issue descriptionWhenever I happen to get logged out and try to visit a build link and see a 404 I am confused. If there was a message like "Not seeing something you were expecting? Try logging in." it would help me.
,
Sep 6
Sometimes the existence of a resource is considered sensitive? Anyway, I haven't seen any redirect.
,
Sep 6
correction to c#1: if the user is not logged in and is trying to access a non-public *or nonexistent* resource
,
Sep 6
sgtm we do this for logdog and no one has complained before.
,
Sep 6
Even better.
,
Sep 14
This logic already exists in Milo today, but it appears it's broken, likely because error isn't tagged with Milo-specific 404 tag. As we onboard more internal builders, this will hurt our users. Bumping priority. Ryan, would you mind owning this? +sergiyb@ FYI since you definitely worked on this before.
,
Sep 28
,
Oct 1
,
Oct 1
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/e3715a89d8a6b224736eba9ae73e1d6241aa6a71 commit e3715a89d8a6b224736eba9ae73e1d6241aa6a71 Author: Ryan Tseng <hinoka@google.com> Date: Mon Oct 01 20:21:54 2018 Redirect to login page if build not found on buildbucket CodeUnauthorized causes a redirect to the login page. Bug: 881422 Change-Id: Id8f10c777d123dfcfaa1361818ab3040fca8cd2f Reviewed-on: https://chromium-review.googlesource.com/1252024 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/e3715a89d8a6b224736eba9ae73e1d6241aa6a71/milo/buildsource/buildbucket/build.go |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by no...@chromium.org
, Sep 6