New issue
Advanced search Search tips

Issue 881400 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 7
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[Duet][Accessibility] Chrome crashes on K and J devices

Project Member Reported by mdjones@chromium.org, Sep 6

Issue description

setAccessibilityTraversalBefore is not supported on K devices and below and crashes the browser. Anyone with Duet enabled will experience this crash.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49c37b2033126ed9ad38380378ec90e394018ceb

commit 49c37b2033126ed9ad38380378ec90e394018ceb
Author: Matthew Jones <mdjones@chromium.org>
Date: Thu Sep 06 20:51:18 2018

Fix accessibility crash on < L devices

This patch adds an API util method that simply does not run the
setAccessibilityTraversalBefore method on devices that are running
Android versions < L.

Bug:  881400 
Change-Id: Ie29a7f8f96e87661d0543fe99ca9e5f1a18f468f
Reviewed-on: https://chromium-review.googlesource.com/1211103
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589288}
[modify] https://crrev.com/49c37b2033126ed9ad38380378ec90e394018ceb/base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java
[modify] https://crrev.com/49c37b2033126ed9ad38380378ec90e394018ceb/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Labels: Merge-Request-70
Summary: [Duet][Accessibility] Chrome crashes on K and J devices (was: [Duet][Accessibility] Chrome crashes on K devices)
Same issue with J devices also
Verified fix on Chrome Dev 71.0.3545.0 s/ Sony Xperia Z1 / 4.4.2.
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 7

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 7

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6d6ed1f349e3f6d508304c34e0b779dfca079c4

commit c6d6ed1f349e3f6d508304c34e0b779dfca079c4
Author: Matthew Jones <mdjones@chromium.org>
Date: Fri Sep 07 21:58:18 2018

Fix accessibility crash on < L devices

This patch adds an API util method that simply does not run the
setAccessibilityTraversalBefore method on devices that are running
Android versions < L.

TBR=mdjones@chromium.org

(cherry picked from commit 49c37b2033126ed9ad38380378ec90e394018ceb)

Bug:  881400 
Change-Id: Ie29a7f8f96e87661d0543fe99ca9e5f1a18f468f
Reviewed-on: https://chromium-review.googlesource.com/1211103
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589288}
Reviewed-on: https://chromium-review.googlesource.com/1214323
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#170}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/c6d6ed1f349e3f6d508304c34e0b779dfca079c4/base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java
[modify] https://crrev.com/c6d6ed1f349e3f6d508304c34e0b779dfca079c4/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
We don't see the crash in recent M70-70.0.3538.17 and M71 -71.0.3552.0 builds

Sign in to add a comment