New issue
Advanced search Search tips

Issue 881392 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

effective touch action is not propagated to document's layout view

Project Member Reported by xidac...@chromium.org, Sep 6

Issue description

The bug is discovered when running the GetEffectiveTouchActionForChild.*, when the effective touch action is Pan, the white listed touch action should be Pan as well, but right now it is auto.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81f32ee9bf155c42315b03a65d1c0ece71e10bb0

commit 81f32ee9bf155c42315b03a65d1c0ece71e10bb0
Author: Xida Chen <xidachen@chromium.org>
Date: Thu Sep 13 21:41:28 2018

Propagate effective touch action to Document's layout view

When running SitePerProcessBrowserTouchActionTest, I found that when
the effective touch action is Pan, the white listed touch action is Auto.
This is clearly wrong because the white listed touch action is set from
the effective touch action.

This CL fixes the problem by propagating the effective touch action
to document's layout view in style adjuster. It also changes the test
to get the whitelisted touch action.

In PS#2, we comment out the fix in style_adjuster.cc, and we can see
that these 3 browser tests failed. The tests pass in PS#3 when putting
the fix back.

Bug:  881392 
Change-Id: I86589baec9d0fc222e43268166b808971f03798b
Reviewed-on: https://chromium-review.googlesource.com/1210963
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591170}
[modify] https://crrev.com/81f32ee9bf155c42315b03a65d1c0ece71e10bb0/content/browser/renderer_host/input/input_router_impl.h
[modify] https://crrev.com/81f32ee9bf155c42315b03a65d1c0ece71e10bb0/content/browser/renderer_host/input/touch_action_filter.h
[modify] https://crrev.com/81f32ee9bf155c42315b03a65d1c0ece71e10bb0/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/81f32ee9bf155c42315b03a65d1c0ece71e10bb0/third_party/blink/renderer/core/dom/document.cc

Status: Fixed (was: Assigned)

Sign in to add a comment