Issue metadata
Sign in to add a comment
|
Text in tabs in title bar is unreadable compared to previous version
Reported by
mario.vo...@gmail.com,
Sep 6
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.81 Safari/537.36 Steps to reproduce the problem: 1. Install Chrome 69 with new design 2. Set some color in windows by using "Automatically pick accent color" 3. What is the expected behavior? Should be able to read the text in the tabs, by choosing contrasting text color. What went wrong? If the colors are not contrasting, text becomes unreadable. Previous versions of chrome didn't have tabs colored so it was always black text on white or gray. In the new version it's possible to have black text on dark blue if the Windows theme is set too dark, which makes the text impossible to read. Did this work before? Yes Chrome v68 Chrome version: 69.0.3497.81 Channel: stable OS Version: 10.0 Flash Version: If the color is chosen manually, not with the "Automatic accent color", text is white instead of black which makes it readable.
,
Sep 6
Which Theme from the Web Store are you using? Can you please share the link? Thanks in advance.
,
Sep 6
Thank you for the quick feedback. I'm not using any theme. Chrome is using default settings. I have attached the wallpaper which I'm using in Windows, on which the accent color is based. Additionaly, setting is Windows is shown, where the same color is also shown in recent list, and if I choose it from recent list, Chrome text in tab is white, if autoamtic is chosen, text tab is black
,
Sep 6
We should never have black text on dark blue -- the background tab text is supposed to be forced to a contrasting color. Black (rather than white) is the correct endpoint for this orange, with a maximum contrast of 8; white has a maximum contrast of something like 2.6. The actual color chosen seems to be #3e3b3a, which has a ratio of 4.23, which seems a bit low -- I thought we were supposed to force to 4.5. However this also looks like it may be suffering from the blurry font issue (bug 880513). I think we're probably doing the right thing here, but ->kylixrd while I'm out to verify.
,
Sep 6
,
Sep 6
Aside from the blurry font issue, this *may* be a result of how Windows cycles the automatically chosen accent colors. If you explicitly set the accent color, the tab colors are updated. However, I've noticed that if you use the "Automatically pick and accent..." option and the desktop image periodically cycles, the tab colors aren't updated until the window is activated/deactivated. That is the only time I've see the incorrect contrast selected. I suspect this is because Windows isn't sending the WM_SYSCOLORCHANGED message when the accent color is updated from the background image.
,
Sep 6
Is it possible windows sends us a message and we don't handle it? Maybe we could explicitly test that?
,
Sep 6
Possibly. However, when I looked into this a little while back I couldn't find any message other than WM_SYSCOLORCHANGED (which we *do* handle and does work, if sent) that would indicate such a state change.
,
Sep 6
In this case I don't have the wallpapers set to cycle, only one desktop background is used. And additionally, it seems that text on tab color is not changed at all if the Chrome window is not in focus (color is always black).
,
Nov 14
**UI mass Triage** We were unable to reproduce this bug. If this bug still reproduces for you, please reopen or file a new issue. Thanks!
,
Nov 15
I have tested this just know in: Chrome Version 70.0.3538.102 (Official Build) (64-bit) and it's still reproducible (to actually see the bug, in Color settings, below the color grid you have to also set the option to show accent color on title bar). Luckily I discovered that I can change the chrome://flags/#top-chrome-md to Normal which brings back the old style which has readable colors so Chrome is usable again. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mario.vo...@gmail.com
, Sep 633.3 KB
33.3 KB View Download