Fix autoupdate_ForcedOOBEUpdate to properly cancel its forced OOBE update
Reported by
jrbarnette@chromium.org,
Sep 6
|
||||
Issue descriptionRecently, a raft of broken DUTs were found to have downloaded and installed production firmware and OS software, leaving them untestable, and needing manual recovery. The failure was traced to this sequence of events (see crbug.com/877107#c52 ): 1. The test creates a new lsb-release at /mnt/stateful_partition/etc/lsb-release. This lsb-release points to a devserver. 2. The test starts a forced update at OOBE. 3. The test fails (e.g the update started too slowly) 4. The new lsb-release file is deleted as part of the test cleanup() 5. The DUT finishes the update in the background. 6. It automatically reboots when the update is finished. (This is normal for OOBE updates). 7. The DUT reboots back to the OOBE update screen and does another update check (this happens so the DUT can successfully deal with stepping stones). 8. Since we deleted the lsb-release it makes the request to production omaha 9. Since we are running a REALLY old build (It is an R65 build linked to in comment #50), the production omaha says there is a build and returns the latest serving stable build. We need to fix the autoupdate_ForcedOOBEUpdate test so that the chain above will be definitively broken during test cleanup. Ideally, this fix should be merged all the way back to the oldest release still in use by lakitu; see bug 881376.
,
Sep 6
,
Sep 7
We tested it manually and restarting update engine will cancel the update at OOBE and OOBE will complete and move to the login screen. So should be a simple fix
,
Sep 10
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b1733c8248d4436fb9f5231f9cdc88c502c978a2 commit b1733c8248d4436fb9f5231f9cdc88c502c978a2 Author: David Haddock <dhaddock@chromium.org> Date: Fri Sep 14 19:08:29 2018 Cancel any updates that are left in progress during test cleanup. Sometimes autoupdate_ForcedOOBEUPdate will fail and leave the DUT with an update in progress. This has lead to issues like crbug.com/877107 . This CL will cancel all updates in progress during the test cleanup. BUG= chromium:881382 TEST=autupdate_ForedOOBEUpdate and manually. Change-Id: I54d62d99c7ccbd20e579db7907346e70f28f1e2c Reviewed-on: https://chromium-review.googlesource.com/1213765 Commit-Ready: danny chan <dchan@chromium.org> Tested-by: David Haddock <dhaddock@chromium.org> Tested-by: danny chan <dchan@chromium.org> Reviewed-by: David Haddock <dhaddock@chromium.org> Reviewed-by: danny chan <dchan@chromium.org> [modify] https://crrev.com/b1733c8248d4436fb9f5231f9cdc88c502c978a2/server/site_tests/autoupdate_ForcedOOBEUpdate/autoupdate_ForcedOOBEUpdate.py
,
Oct 17
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dhadd...@chromium.org
, Sep 6Status: Assigned (was: Untriaged)