Multidevice Settings UI clicks are routing when they should not |
|||||
Issue descriptionThis includes: 1) non-host set modes 2) disabled button clicks 3) link clicks It looks pretty bad and it's an easy fix.
,
Sep 18
,
Sep 28
Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.
,
Oct 1
,
Oct 1
,
Oct 3
Update: Of the problematic click types listed above, (1) was already fixed and (2) is moot because we no long have a disabled button in the Settings Page so only (3) still requires a fix.
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af86de0fe5c1b37e1a16b6bf3d6b60f03e6fdbde commit af86de0fe5c1b37e1a16b6bf3d6b60f03e6fdbde Author: Jordy Greenblatt <jordynass@chromium.org> Date: Wed Oct 03 22:14:19 2018 [CrOS MultiDevice] Stop link click from opening subpage in Settings Page In the HEAD version, a click on the Settings UI 'learn more' link will route to the subpage when there is a set host (i.e. when waiting for connection/verification) in addition to the intended behavior of opening the subpage. This CL just adds a check to the settings-multidevice-page's click handler that returns before routing if the click target was a link. Screenshot: http://screen/ka5Vd3vk1YC Bug: 881375 Change-Id: I6c1c8e2ed2e6043d2f21442a0ce0b8e211da522e Reviewed-on: https://chromium-review.googlesource.com/c/1259300 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#596394} [modify] https://crrev.com/af86de0fe5c1b37e1a16b6bf3d6b60f03e6fdbde/chrome/browser/resources/settings/multidevice_page/multidevice_feature_item.js [modify] https://crrev.com/af86de0fe5c1b37e1a16b6bf3d6b60f03e6fdbde/chrome/browser/resources/settings/multidevice_page/multidevice_page.js
,
Oct 3
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jordynass@chromium.org
, Sep 6Status: Started (was: Untriaged)