Implement autofill in iframes
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/449ab884ecbd11e28698b3199811962280de7743 commit 449ab884ecbd11e28698b3199811962280de7743 Author: Olivier Robin <olivierrobin@chromium.org> Date: Tue Sep 11 12:28:36 2018 Pass WebFrames to FormActivityObserver Bug: 881364 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I99131d73c52118b1baa7dee460d91b0f9d7d8521 Reviewed-on: https://chromium-review.googlesource.com/1203997 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#590273} [modify] https://crrev.com/449ab884ecbd11e28698b3199811962280de7743/components/autofill/ios/browser/autofill_agent.mm [modify] https://crrev.com/449ab884ecbd11e28698b3199811962280de7743/components/autofill/ios/form_util/form_activity_observer.h [modify] https://crrev.com/449ab884ecbd11e28698b3199811962280de7743/components/autofill/ios/form_util/form_activity_observer_bridge.h [modify] https://crrev.com/449ab884ecbd11e28698b3199811962280de7743/components/autofill/ios/form_util/form_activity_observer_bridge.mm [modify] https://crrev.com/449ab884ecbd11e28698b3199811962280de7743/components/autofill/ios/form_util/form_activity_observer_bridge_unittest.mm [modify] https://crrev.com/449ab884ecbd11e28698b3199811962280de7743/components/autofill/ios/form_util/form_activity_tab_helper.h [modify] https://crrev.com/449ab884ecbd11e28698b3199811962280de7743/components/autofill/ios/form_util/form_activity_tab_helper.mm [modify] https://crrev.com/449ab884ecbd11e28698b3199811962280de7743/components/autofill/ios/form_util/form_activity_tab_helper_unittest.mm [modify] https://crrev.com/449ab884ecbd11e28698b3199811962280de7743/components/autofill/ios/form_util/test_form_activity_observer.h [modify] https://crrev.com/449ab884ecbd11e28698b3199811962280de7743/components/autofill/ios/form_util/test_form_activity_observer.mm [modify] https://crrev.com/449ab884ecbd11e28698b3199811962280de7743/components/autofill/ios/form_util/test_form_activity_tab_helper.h [modify] https://crrev.com/449ab884ecbd11e28698b3199811962280de7743/components/autofill/ios/form_util/test_form_activity_tab_helper.mm [modify] https://crrev.com/449ab884ecbd11e28698b3199811962280de7743/components/password_manager/ios/password_controller_helper.mm [modify] https://crrev.com/449ab884ecbd11e28698b3199811962280de7743/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm [modify] https://crrev.com/449ab884ecbd11e28698b3199811962280de7743/ios/chrome/browser/ssl/insecure_input_tab_helper.h [modify] https://crrev.com/449ab884ecbd11e28698b3199811962280de7743/ios/chrome/browser/ssl/insecure_input_tab_helper.mm [modify] https://crrev.com/449ab884ecbd11e28698b3199811962280de7743/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.mm [modify] https://crrev.com/449ab884ecbd11e28698b3199811962280de7743/ios/web_view/internal/autofill/cwv_autofill_controller.mm [modify] https://crrev.com/449ab884ecbd11e28698b3199811962280de7743/ios/web_view/internal/autofill/cwv_autofill_controller_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41d23bdde3db93542ecd18b65f644676db377540 commit 41d23bdde3db93542ecd18b65f644676db377540 Author: Olivier Robin <olivierrobin@chromium.org> Date: Wed Sep 12 07:37:23 2018 Inject autofill JS in iframes. Bug: 881364 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I23ba4755e9319b98a9c23a71d9edea2d48e49b0d Reviewed-on: https://chromium-review.googlesource.com/1209710 Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#590615} [modify] https://crrev.com/41d23bdde3db93542ecd18b65f644676db377540/components/autofill/ios/form_util/fill_js_unittest.mm [modify] https://crrev.com/41d23bdde3db93542ecd18b65f644676db377540/ios/chrome/browser/web/BUILD.gn [modify] https://crrev.com/41d23bdde3db93542ecd18b65f644676db377540/ios/chrome/browser/web/chrome_web_client_unittest.mm [modify] https://crrev.com/41d23bdde3db93542ecd18b65f644676db377540/ios/chrome/browser/web/resources/chrome_bundle_all_frames.js [modify] https://crrev.com/41d23bdde3db93542ecd18b65f644676db377540/ios/chrome/browser/web/resources/chrome_bundle_main_frame.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cba46aacefb6ef615a8997378f7c984d973d2b12 commit cba46aacefb6ef615a8997378f7c984d973d2b12 Author: Olivier Robin <olivierrobin@chromium.org> Date: Wed Sep 12 07:48:39 2018 Add a flag for Autofill in iFrames in iOS. Bug: 881364 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2abc7275648cfdd19df811d929c7f0150c212184 Reviewed-on: https://chromium-review.googlesource.com/1215944 Reviewed-by: Eric Noyau <noyau@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#590616} [modify] https://crrev.com/cba46aacefb6ef615a8997378f7c984d973d2b12/components/autofill/core/common/autofill_features.cc [modify] https://crrev.com/cba46aacefb6ef615a8997378f7c984d973d2b12/components/autofill/core/common/autofill_features.h [modify] https://crrev.com/cba46aacefb6ef615a8997378f7c984d973d2b12/components/autofill/ios/browser/autofill_switches.cc [modify] https://crrev.com/cba46aacefb6ef615a8997378f7c984d973d2b12/components/autofill/ios/browser/autofill_switches.h [modify] https://crrev.com/cba46aacefb6ef615a8997378f7c984d973d2b12/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/cba46aacefb6ef615a8997378f7c984d973d2b12/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/cba46aacefb6ef615a8997378f7c984d973d2b12/ios/chrome/browser/ios_chrome_flag_descriptions.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38300420bf3e7d800702a1828689c109b50ecd9b commit 38300420bf3e7d800702a1828689c109b50ecd9b Author: Olivier Robin <olivierrobin@chromium.org> Date: Tue Sep 18 10:13:00 2018 Pass WebFrame/frameID inside Autofill This CL pass the WebFrame (or the frameID when there will likely be asynchronous use of it) all arounf autofill. It also create AutofillDriverIOSWebState to isolate the creation of the object. This CL does not change anything in functionality. Bug: 881364 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ibe34d0c2c994a2afd690f25c54e666338809bce1 Reviewed-on: https://chromium-review.googlesource.com/1221628 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#591988} [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/components/autofill/ios/browser/BUILD.gn [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/components/autofill/ios/browser/autofill_agent.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/components/autofill/ios/browser/autofill_agent_unittests.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/components/autofill/ios/browser/autofill_driver_ios.h [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/components/autofill/ios/browser/autofill_driver_ios.mm [add] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/components/autofill/ios/browser/autofill_driver_ios_webstate.h [add] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/components/autofill/ios/browser/autofill_driver_ios_webstate.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/components/autofill/ios/browser/fake_autofill_agent.h [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/components/autofill/ios/browser/fake_autofill_agent.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/components/autofill/ios/browser/form_suggestion_provider.h [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/components/autofill/ios/form_util/form_activity_params.h [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/components/autofill/ios/form_util/form_activity_tab_helper.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/components/autofill/ios/form_util/test_form_activity_tab_helper.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/chrome/browser/autofill/autofill_controller.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/chrome/browser/autofill/autofill_controller_unittest.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/chrome/browser/autofill/automation/automation_action.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/chrome/browser/autofill/form_structure_browsertest.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/chrome/browser/autofill/form_suggestion_controller.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/chrome/browser/passwords/password_controller.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/chrome/browser/passwords/password_controller_unittest.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/chrome/browser/ui/autofill/save_card_infobar_egtest.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/chrome/browser/ui/payments/full_card_requester_unittest.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/chrome/browser/ui/payments/payment_request_manager.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/web/public/web_state/web_frame_util.h [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/web/web_state/web_frame_util.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/web/web_state/web_frame_util_unittest.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/web/web_state/web_frames_manager_impl.h [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/web/web_state/web_frames_manager_impl.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/web_view/internal/autofill/cwv_autofill_controller.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/web_view/internal/autofill/cwv_autofill_controller_unittest.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/web_view/internal/autofill/cwv_autofill_suggestion.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/web_view/internal/autofill/cwv_autofill_suggestion_internal.h [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/web_view/internal/autofill/cwv_autofill_suggestion_unittest.mm [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/web_view/public/cwv_autofill_controller.h [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/web_view/public/cwv_autofill_controller_delegate.h [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/web_view/public/cwv_autofill_suggestion.h [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/web_view/shell/shell_autofill_delegate.m [modify] https://crrev.com/38300420bf3e7d800702a1828689c109b50ecd9b/ios/web_view/test/web_view_autofill_inttest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5230c80647cd65943545ac5f0c99ab319e3a7c70 commit 5230c80647cd65943545ac5f0c99ab319e3a7c70 Author: Olivier Robin <olivierrobin@chromium.org> Date: Fri Sep 21 13:10:05 2018 Call JS using WebFrame when flag is enabled. This CL does not add support to autofill in iFrames. Unittests may fail with the Autofill in iFrame flag enabled. This will be solve in a future CL. Bug: 881364 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I38cd09b7aec31d8e47eea8e756ef937bcdde7b1b Reviewed-on: https://chromium-review.googlesource.com/1230062 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593160} [modify] https://crrev.com/5230c80647cd65943545ac5f0c99ab319e3a7c70/components/autofill/ios/browser/autofill_agent.h [modify] https://crrev.com/5230c80647cd65943545ac5f0c99ab319e3a7c70/components/autofill/ios/browser/autofill_agent.mm [modify] https://crrev.com/5230c80647cd65943545ac5f0c99ab319e3a7c70/components/autofill/ios/browser/autofill_agent_unittests.mm [modify] https://crrev.com/5230c80647cd65943545ac5f0c99ab319e3a7c70/components/autofill/ios/browser/fake_js_autofill_manager.h [modify] https://crrev.com/5230c80647cd65943545ac5f0c99ab319e3a7c70/components/autofill/ios/browser/fake_js_autofill_manager.mm [modify] https://crrev.com/5230c80647cd65943545ac5f0c99ab319e3a7c70/components/autofill/ios/browser/js_autofill_manager.h [modify] https://crrev.com/5230c80647cd65943545ac5f0c99ab319e3a7c70/components/autofill/ios/browser/js_autofill_manager.mm [modify] https://crrev.com/5230c80647cd65943545ac5f0c99ab319e3a7c70/ios/chrome/browser/autofill/autofill_controller.mm [modify] https://crrev.com/5230c80647cd65943545ac5f0c99ab319e3a7c70/ios/chrome/browser/autofill/js_autofill_manager_unittest.mm [modify] https://crrev.com/5230c80647cd65943545ac5f0c99ab319e3a7c70/ios/web_view/internal/autofill/cwv_autofill_controller.mm [modify] https://crrev.com/5230c80647cd65943545ac5f0c99ab319e3a7c70/ios/web_view/internal/autofill/cwv_autofill_controller_unittest.mm [modify] https://crrev.com/5230c80647cd65943545ac5f0c99ab319e3a7c70/ios/web_view/public/cwv_autofill_controller.h [modify] https://crrev.com/5230c80647cd65943545ac5f0c99ab319e3a7c70/ios/web_view/shell/shell_autofill_delegate.m [modify] https://crrev.com/5230c80647cd65943545ac5f0c99ab319e3a7c70/ios/web_view/test/web_view_autofill_inttest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd commit d0e0bace88bc7fe8bffaa27d1572bb7020b847dd Author: Olivier Robin <olivierrobin@chromium.org> Date: Fri Sep 21 15:39:25 2018 Implement Autofill in iframe - Known bugs: navigation buttons do not work in iframes. - Payment Request is only enabled in main frame. - This CL does not enable autofill in iFrame by default. Bug: 881364 , 792642 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia18b8a0543d0c754a22d3ee9287171f6807f5f5c Reviewed-on: https://chromium-review.googlesource.com/1233575 Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593196} [modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/components/autofill/ios/browser/autofill_agent.mm [modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/components/autofill/ios/browser/autofill_driver_ios.h [modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/components/autofill/ios/browser/autofill_util.h [modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/components/autofill/ios/browser/autofill_util.mm [modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/components/autofill/ios/form_util/resources/form.js [modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/components/password_manager/ios/password_controller_helper.mm [modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/ios/chrome/browser/autofill/form_structure_browsertest.mm [modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/ios/chrome/browser/passwords/password_controller.mm [modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/ios/web/public/test/fakes/fake_web_frame.cc [modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/ios/web/web_state/js/resources/message.js [modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/ios/web_view/test/web_view_autofill_inttest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d058a0085d277465bfc5eac591e6b8f5269ca0a8 commit d058a0085d277465bfc5eac591e6b8f5269ca0a8 Author: Olivier Robin <olivierrobin@chromium.org> Date: Fri Sep 21 15:50:59 2018 Put form data in submit info With frame messaging, the JS messages are filter sooner than with window ID filtering. The result is that the race condition on form submission is now issue. Pass the form data on submit event to avoid having to do a new JS call. Bug: 418827, 881364 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I64b0f6232e5ed46aa3f91cf7134cbe2c55c9c440 Reviewed-on: https://chromium-review.googlesource.com/1236277 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593200} [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/components/autofill/ios/browser/autofill_agent.mm [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/components/autofill/ios/browser/js_autofill_manager.mm [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/components/autofill/ios/form_util/BUILD.gn [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/components/autofill/ios/form_util/form_activity_observer.h [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/components/autofill/ios/form_util/form_activity_observer_bridge.h [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/components/autofill/ios/form_util/form_activity_observer_bridge.mm [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/components/autofill/ios/form_util/form_activity_observer_bridge_unittest.mm [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/components/autofill/ios/form_util/form_activity_tab_helper.mm [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/components/autofill/ios/form_util/form_activity_tab_helper_unittest.mm [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/components/autofill/ios/form_util/form_unittest.mm [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/components/autofill/ios/form_util/resources/fill.js [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/components/autofill/ios/form_util/resources/form.js [add] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/components/autofill/ios/form_util/resources/form_handlers.js [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/components/autofill/ios/form_util/test_form_activity_observer.h [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/components/autofill/ios/form_util/test_form_activity_observer.mm [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/components/autofill/ios/form_util/test_form_activity_tab_helper.h [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/components/autofill/ios/form_util/test_form_activity_tab_helper.mm [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/components/password_manager/ios/password_controller_helper.mm [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/ios/chrome/browser/web/BUILD.gn [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/ios/chrome/browser/web/resources/chrome_bundle_all_frames.js [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/ios/web/public/web_state/web_frame.h [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/ios/web_view/BUILD.gn [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/ios/web_view/internal/autofill/cwv_autofill_controller.mm [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/ios/web_view/internal/autofill/cwv_autofill_controller_unittest.mm [modify] https://crrev.com/d058a0085d277465bfc5eac591e6b8f5269ca0a8/ios/web_view/resources/web_view_bundle.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3d75f5bf44b981a40e4f222bb8b1117859f64ea commit b3d75f5bf44b981a40e4f222bb8b1117859f64ea Author: Olivier Robin <olivierrobin@chromium.org> Date: Fri Sep 21 18:58:29 2018 Fix tests with WebFrame messaging These are fixes that are needed to enable Autofill in iframes. It also add more tests for the frame messaging logic. Bug: 881364 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iea417c1d371094489daca66e7477d963d003c716 Reviewed-on: https://chromium-review.googlesource.com/1234333 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593282} [modify] https://crrev.com/b3d75f5bf44b981a40e4f222bb8b1117859f64ea/components/autofill/ios/browser/autofill_agent_unittests.mm [modify] https://crrev.com/b3d75f5bf44b981a40e4f222bb8b1117859f64ea/ios/chrome/browser/autofill/autofill_controller_unittest.mm [modify] https://crrev.com/b3d75f5bf44b981a40e4f222bb8b1117859f64ea/ios/chrome/browser/autofill/form_structure_browsertest.mm [modify] https://crrev.com/b3d75f5bf44b981a40e4f222bb8b1117859f64ea/ios/chrome/browser/autofill/js_autofill_manager_unittest.mm [modify] https://crrev.com/b3d75f5bf44b981a40e4f222bb8b1117859f64ea/ios/chrome/browser/web/visible_url_egtest.mm [modify] https://crrev.com/b3d75f5bf44b981a40e4f222bb8b1117859f64ea/ios/web/public/test/fakes/fake_web_frame.cc [modify] https://crrev.com/b3d75f5bf44b981a40e4f222bb8b1117859f64ea/ios/web/public/test/fakes/fake_web_frame.h [modify] https://crrev.com/b3d75f5bf44b981a40e4f222bb8b1117859f64ea/ios/web_view/test/web_view_autofill_inttest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c92470b71e1bcde103d2121660820623ff861200 commit c92470b71e1bcde103d2121660820623ff861200 Author: Olivier Robin <olivierrobin@chromium.org> Date: Mon Sep 24 11:41:48 2018 [Autofill][iOS]Only scan main frame if frame messaging is disabled. Tbr: mahmadi@chromium.org Bug: 881364 Change-Id: I763f982645697fb35a2691e96159904154030d08 Reviewed-on: https://chromium-review.googlesource.com/1238548 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593506} [modify] https://crrev.com/c92470b71e1bcde103d2121660820623ff861200/components/autofill/ios/browser/autofill_agent.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56b8fa60d69151ae827dc44a040172b17052c5f3 commit 56b8fa60d69151ae827dc44a040172b17052c5f3 Author: Olivier Robin <olivierrobin@chromium.org> Date: Wed Sep 26 17:38:17 2018 Enable Autofill in iframe flag by default. This feature will still be controlled by frame messaging. Bug: 881364 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ibdf1c1c6ed616475a1d6d2c45929831a2c5fe5e9 Reviewed-on: https://chromium-review.googlesource.com/1245728 Reviewed-by: Eric Noyau <noyau@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594373} [modify] https://crrev.com/56b8fa60d69151ae827dc44a040172b17052c5f3/components/autofill/core/common/autofill_features.cc [modify] https://crrev.com/56b8fa60d69151ae827dc44a040172b17052c5f3/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/56b8fa60d69151ae827dc44a040172b17052c5f3/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/56b8fa60d69151ae827dc44a040172b17052c5f3/ios/chrome/browser/ios_chrome_flag_descriptions.h
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/fc0d4190227d239378ff34a7b9b23671a7371924 commit fc0d4190227d239378ff34a7b9b23671a7371924 Author: Olivier Robin <olivierrobin@chromium.org> Date: Thu Sep 27 17:40:42 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25b107c858645246564bf6648e33fec6d815a2a8 commit 25b107c858645246564bf6648e33fec6d815a2a8 Author: Olivier Robin <olivierrobin@google.com> Date: Wed Oct 03 20:44:10 2018 Enable save form data in iframe Bug: 881364 Change-Id: I6cef5aa5a8acc32bc797c3abbef0869a2f094e66 Reviewed-on: https://chromium-review.googlesource.com/c/1259782 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#596349} [modify] https://crrev.com/25b107c858645246564bf6648e33fec6d815a2a8/components/autofill/ios/browser/autofill_agent.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/f535f02855d67ab973d95db0e7797ef7773b5c0d commit f535f02855d67ab973d95db0e7797ef7773b5c0d Author: Moe Ahmadi <mahmadi@chromium.org> Date: Thu Oct 04 15:14:19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c04fc106f82a1bb65508e806998033f79965ae54 commit c04fc106f82a1bb65508e806998033f79965ae54 Author: Mike Dougherty <michaeldo@chromium.org> Date: Wed Oct 10 07:04:40 2018 Support JSSuggestionManager in all frames. Bug: 881364 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I85ba4275119f53d5c081e48491d7279b364f03b1 Reviewed-on: https://chromium-review.googlesource.com/c/1263883 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#598236} [modify] https://crrev.com/c04fc106f82a1bb65508e806998033f79965ae54/components/autofill/ios/browser/autofill_util.h [modify] https://crrev.com/c04fc106f82a1bb65508e806998033f79965ae54/components/autofill/ios/browser/autofill_util.mm [modify] https://crrev.com/c04fc106f82a1bb65508e806998033f79965ae54/components/autofill/ios/browser/js_autofill_manager.mm [modify] https://crrev.com/c04fc106f82a1bb65508e806998033f79965ae54/components/autofill/ios/browser/js_suggestion_manager.h [modify] https://crrev.com/c04fc106f82a1bb65508e806998033f79965ae54/components/autofill/ios/browser/js_suggestion_manager.mm [modify] https://crrev.com/c04fc106f82a1bb65508e806998033f79965ae54/components/autofill/ios/browser/resources/suggestion_controller.js [modify] https://crrev.com/c04fc106f82a1bb65508e806998033f79965ae54/ios/chrome/browser/autofill/form_input_accessory_view_handler.h [modify] https://crrev.com/c04fc106f82a1bb65508e806998033f79965ae54/ios/chrome/browser/autofill/form_input_accessory_view_handler.mm [modify] https://crrev.com/c04fc106f82a1bb65508e806998033f79965ae54/ios/chrome/browser/autofill/form_suggestion_controller.mm [modify] https://crrev.com/c04fc106f82a1bb65508e806998033f79965ae54/ios/chrome/browser/autofill/js_suggestion_manager_unittest.mm [modify] https://crrev.com/c04fc106f82a1bb65508e806998033f79965ae54/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.mm [modify] https://crrev.com/c04fc106f82a1bb65508e806998033f79965ae54/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_injection_handler.mm [modify] https://crrev.com/c04fc106f82a1bb65508e806998033f79965ae54/ios/web_view/internal/autofill/cwv_autofill_controller.mm [modify] https://crrev.com/c04fc106f82a1bb65508e806998033f79965ae54/ios/web_view/internal/autofill/cwv_autofill_controller_unittest.mm [modify] https://crrev.com/c04fc106f82a1bb65508e806998033f79965ae54/ios/web_view/internal/cwv_web_view.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5adf72795f09b91efa82732add8df0c8e519daf4 commit 5adf72795f09b91efa82732add8df0c8e519daf4 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Tue Oct 16 01:28:30 2018 [AF] Log if in iframe for Autofill.FormEvents.Address/CreditCard histograms Bug: 881364 Change-Id: I89310a03a7afdcb4e1c38b1b22f0a1ca49722210 Reviewed-on: https://chromium-review.googlesource.com/c/1277575 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#599813} [modify] https://crrev.com/5adf72795f09b91efa82732add8df0c8e519daf4/components/autofill/content/browser/content_autofill_driver.cc [modify] https://crrev.com/5adf72795f09b91efa82732add8df0c8e519daf4/components/autofill/content/browser/content_autofill_driver.h [modify] https://crrev.com/5adf72795f09b91efa82732add8df0c8e519daf4/components/autofill/core/browser/autofill_driver.h [modify] https://crrev.com/5adf72795f09b91efa82732add8df0c8e519daf4/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/5adf72795f09b91efa82732add8df0c8e519daf4/components/autofill/core/browser/autofill_manager.h [modify] https://crrev.com/5adf72795f09b91efa82732add8df0c8e519daf4/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/5adf72795f09b91efa82732add8df0c8e519daf4/components/autofill/core/browser/autofill_metrics.h [modify] https://crrev.com/5adf72795f09b91efa82732add8df0c8e519daf4/components/autofill/core/browser/autofill_metrics_unittest.cc [modify] https://crrev.com/5adf72795f09b91efa82732add8df0c8e519daf4/components/autofill/core/browser/test_autofill_driver.cc [modify] https://crrev.com/5adf72795f09b91efa82732add8df0c8e519daf4/components/autofill/core/browser/test_autofill_driver.h [modify] https://crrev.com/5adf72795f09b91efa82732add8df0c8e519daf4/components/autofill/ios/browser/autofill_agent_unittests.mm [modify] https://crrev.com/5adf72795f09b91efa82732add8df0c8e519daf4/components/autofill/ios/browser/autofill_driver_ios.h [modify] https://crrev.com/5adf72795f09b91efa82732add8df0c8e519daf4/components/autofill/ios/browser/autofill_driver_ios.mm [modify] https://crrev.com/5adf72795f09b91efa82732add8df0c8e519daf4/tools/metrics/histograms/histograms.xml
Requesting to merge the CL in c#16. Verified in iOS Canary 72.0.03585.0
Approving CL in c#16 for merge to 71.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73ebfdc6ab014f9f424270d9f5b76731ceaae42d commit 73ebfdc6ab014f9f424270d9f5b76731ceaae42d Author: Moe Ahmadi <mahmadi@chromium.org> Date: Thu Oct 25 18:29:49 2018 [AF] Log if in iframe for Autofill.FormEvents.Address/CreditCard histograms Bug: 881364 Change-Id: I89310a03a7afdcb4e1c38b1b22f0a1ca49722210 Reviewed-on: https://chromium-review.googlesource.com/c/1277575 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599813}(cherry picked from commit 5adf72795f09b91efa82732add8df0c8e519daf4) Reviewed-on: https://chromium-review.googlesource.com/c/1299779 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#329} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/73ebfdc6ab014f9f424270d9f5b76731ceaae42d/components/autofill/content/browser/content_autofill_driver.cc [modify] https://crrev.com/73ebfdc6ab014f9f424270d9f5b76731ceaae42d/components/autofill/content/browser/content_autofill_driver.h [modify] https://crrev.com/73ebfdc6ab014f9f424270d9f5b76731ceaae42d/components/autofill/core/browser/autofill_driver.h [modify] https://crrev.com/73ebfdc6ab014f9f424270d9f5b76731ceaae42d/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/73ebfdc6ab014f9f424270d9f5b76731ceaae42d/components/autofill/core/browser/autofill_manager.h [modify] https://crrev.com/73ebfdc6ab014f9f424270d9f5b76731ceaae42d/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/73ebfdc6ab014f9f424270d9f5b76731ceaae42d/components/autofill/core/browser/autofill_metrics.h [modify] https://crrev.com/73ebfdc6ab014f9f424270d9f5b76731ceaae42d/components/autofill/core/browser/autofill_metrics_unittest.cc [modify] https://crrev.com/73ebfdc6ab014f9f424270d9f5b76731ceaae42d/components/autofill/core/browser/test_autofill_driver.cc [modify] https://crrev.com/73ebfdc6ab014f9f424270d9f5b76731ceaae42d/components/autofill/core/browser/test_autofill_driver.h [modify] https://crrev.com/73ebfdc6ab014f9f424270d9f5b76731ceaae42d/components/autofill/ios/browser/autofill_agent_unittests.mm [modify] https://crrev.com/73ebfdc6ab014f9f424270d9f5b76731ceaae42d/components/autofill/ios/browser/autofill_driver_ios.h [modify] https://crrev.com/73ebfdc6ab014f9f424270d9f5b76731ceaae42d/components/autofill/ios/browser/autofill_driver_ios.mm [modify] https://crrev.com/73ebfdc6ab014f9f424270d9f5b76731ceaae42d/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73ebfdc6ab014f9f424270d9f5b76731ceaae42d Commit: 73ebfdc6ab014f9f424270d9f5b76731ceaae42d Author: mahmadi@chromium.org Commiter: mahmadi@chromium.org Date: 2018-10-25 18:29:49 +0000 UTC [AF] Log if in iframe for Autofill.FormEvents.Address/CreditCard histograms Bug: 881364 Change-Id: I89310a03a7afdcb4e1c38b1b22f0a1ca49722210 Reviewed-on: https://chromium-review.googlesource.com/c/1277575 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599813}(cherry picked from commit 5adf72795f09b91efa82732add8df0c8e519daf4) Reviewed-on: https://chromium-review.googlesource.com/c/1299779 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#329} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Is this still targeting M71? What's the status?
mardini@, yes it is. Marking as fixed.
Comment 1 by bugdroid1@chromium.org
, Sep 11