New issue
Advanced search Search tips

Issue 881363 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 879321
Owner:
Closed: Sep 17
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

58.7% regression in rendering.desktop at 587356:587380

Project Member Reported by sullivan@chromium.org, Sep 6

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=881363

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=151ab718268042509ac1a6033bd85248914e496446077e804b073d348767d487


Bot(s) for this bug's original alert(s):

mac-10_12_laptop_low_end-perf

rendering.desktop - Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Cc: eirage@chromium.org
Owner: eirage@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1189fcd5640000

turn off use-zoom-for-dsf on Android by eirage@chromium.org
https://chromium.googlesource.com/chromium/src/+/14d5c4330c08ac9bcdcda7960561e3e92c135da6
1.258 → 1.036 (-0.2224)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Cc: -eirage@chromium.org
Owner: ----
Status: Available (was: Assigned)
My change is turning off a flag on Android, should have affect on mac. Un-assign myself
s/should have/should have no/
Cc: herb@google.com
Owner: herb@google.com
Status: Assigned (was: Available)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1421958b640000

Managing the context was dropped. Adding back in. by herb@google.com
https://skia.googlesource.com/skia/+/aca2b9eebdaf5ec45ba87a25c60510988fc54756
0.8655 → 1.266 (+0.4002)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Cc: khushals...@chromium.org
Hey Khushal,

In some ways it looks like having the scaler context have a longer lifetime was a pretty good performance win for about 5-10% memory use. Is this something we want to explore? 
Here is a corresponding memory increase  bug 883755 .
Mergedinto: 879321
Status: Duplicate (was: Assigned)
This is a dupe of issue 879321.

Sign in to add a comment