New issue
Advanced search Search tips

Issue 881353 link

Starred by 1 user
Status: Fixed
Owner:
syoussefi@chromium.org
Closed: Sep 6
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

extensions/common/BUILD.gn unnecessary dependency on chrome:resources

Project Member Reported by syoussefi@chromium.org, Sep 6 
Removing the corresponding line [1] doesn't cause a build failure.

[1] https://cs.chromium.org/chromium/src/extensions/common/BUILD.gn?g=0&l=319
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15376bfe8707ea3cb187714ecebc1578a53c2f26

commit 15376bfe8707ea3cb187714ecebc1578a53c2f26
Author: Shahbaz Youssefi <syoussefi@chromium.org>
Date: Thu Sep 06 19:50:27 2018

Remove unnecessary dependency of extensions to chrome

extensions no longer dependens on chrome:resources, so this dependency
can be removed.

Bug:  881353 
Change-Id: I520ebbdff9aab4d0f2c073bd8530c84c4e0eb9ba
Reviewed-on: https://chromium-review.googlesource.com/1210543
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589251}
[modify] https://crrev.com/15376bfe8707ea3cb187714ecebc1578a53c2f26/extensions/common/BUILD.gn

Comment 2 by syoussefi@chromium.org, Sep 6

Status: Fixed (was: Untriaged)
►

Sign in to add a comment