New issue
Advanced search Search tips

Issue 881343 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task


Show other hotlists

Hotlists containing this issue:
Autofill-Fixit


Sign in to add a comment

[Payments] Consider Remove Scan Cardholder name feature

Project Member Reported by ma...@chromium.org, Sep 6

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26

Status: Fixed (was: Available)
Status: Assigned (was: Fixed)
Reopening; apparently my fix broke the build...despite looking through code search, I must have missed a spot...
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2377ebc350d0d2e19f092066d3b28689dbc624d5

commit 2377ebc350d0d2e19f092066d3b28689dbc624d5
Author: Jared Saul <jsaul@google.com>
Date: Sat Oct 27 07:19:27 2018

Revert "[Autofill] Remove AutofillScanCardholderName feature"

This reverts commit a384ba43b74dbb182052aef61168af2ee4d6559b.

Reason for revert: Breaks build (https://bugs.chromium.org/p/chromium/issues/detail?id=899461)

Original change's description:
> [Autofill] Remove AutofillScanCardholderName feature
> 
> It's dead code with no development, and Rouslan said to kill it with
> fire. :)
> 
> Bug:  881343 
> Change-Id: I7c41130b4a1aa0e7a537e95a0b0e6aaac83aa591
> Reviewed-on: https://chromium-review.googlesource.com/c/1300794
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Commit-Queue: Jared Saul <jsaul@google.com>
> Cr-Commit-Position: refs/heads/master@{#603230}

TBR=tedchoc@chromium.org,sebsg@chromium.org,jsaul@google.com

Change-Id: Ie00886b2640e350edddff57a34b0195ae5d23671
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  881343 
Reviewed-on: https://chromium-review.googlesource.com/c/1303651
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#603320}
[modify] https://crrev.com/2377ebc350d0d2e19f092066d3b28689dbc624d5/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/2377ebc350d0d2e19f092066d3b28689dbc624d5/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/2377ebc350d0d2e19f092066d3b28689dbc624d5/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc
[modify] https://crrev.com/2377ebc350d0d2e19f092066d3b28689dbc624d5/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/2377ebc350d0d2e19f092066d3b28689dbc624d5/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/2377ebc350d0d2e19f092066d3b28689dbc624d5/components/autofill/core/common/autofill_features.h

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27

Labels: merge-merged-3593
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d605b09ec919374d24a5aa124946d3c1170f711

commit 9d605b09ec919374d24a5aa124946d3c1170f711
Author: Jared Saul <jsaul@google.com>
Date: Sat Oct 27 07:30:06 2018

Revert "[Autofill] Remove AutofillScanCardholderName feature"

This reverts commit a384ba43b74dbb182052aef61168af2ee4d6559b.

Reason for revert: Breaks build (https://bugs.chromium.org/p/chromium/issues/detail?id=899461)

Original change's description:
> [Autofill] Remove AutofillScanCardholderName feature
> 
> It's dead code with no development, and Rouslan said to kill it with
> fire. :)
> 
> Bug:  881343 
> Change-Id: I7c41130b4a1aa0e7a537e95a0b0e6aaac83aa591
> Reviewed-on: https://chromium-review.googlesource.com/c/1300794
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Commit-Queue: Jared Saul <jsaul@google.com>
> Cr-Commit-Position: refs/heads/master@{#603230}

TBR=tedchoc@chromium.org,sebsg@chromium.org,jsaul@google.com

Change-Id: Ie00886b2640e350edddff57a34b0195ae5d23671
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 899461
Reviewed-on: https://chromium-review.googlesource.com/c/1303651
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#603320}(cherry picked from commit 2377ebc350d0d2e19f092066d3b28689dbc624d5)
Reviewed-on: https://chromium-review.googlesource.com/c/1303499
Cr-Commit-Position: refs/branch-heads/3593@{#3}
Cr-Branched-From: c2c723d01a4f7b9de289fc0ba94334563da74e9a-refs/heads/master@{#603285}
[modify] https://crrev.com/9d605b09ec919374d24a5aa124946d3c1170f711/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/9d605b09ec919374d24a5aa124946d3c1170f711/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/9d605b09ec919374d24a5aa124946d3c1170f711/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc
[modify] https://crrev.com/9d605b09ec919374d24a5aa124946d3c1170f711/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/9d605b09ec919374d24a5aa124946d3c1170f711/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/9d605b09ec919374d24a5aa124946d3c1170f711/components/autofill/core/common/autofill_features.h

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/3ce01e719f04369bef5a23766f8a9e873f28c68e

commit 3ce01e719f04369bef5a23766f8a9e873f28c68e
Author: Jared Saul <jsaul@google.com>
Date: Tue Oct 30 20:23:16 2018

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c094837a0c2107d20e6902e86cb8d45f80d124b

commit 6c094837a0c2107d20e6902e86cb8d45f80d124b
Author: Jared Saul <jsaul@google.com>
Date: Wed Oct 31 16:15:55 2018

[Autofill] Remove dead AutofillScanCardholderName feature

This is a redo of
https://chromium-review.googlesource.com/c/chromium/src/+/1300794.
That CL was reverted because there were still internal Android
dependencies that I originally missed, which I resolved earlier today.

Bug:  881343 
Change-Id: I99b87e859c0fc147f1c8343f5170d93cad066f7d
Reviewed-on: https://chromium-review.googlesource.com/c/1308607
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#604279}
[modify] https://crrev.com/6c094837a0c2107d20e6902e86cb8d45f80d124b/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/6c094837a0c2107d20e6902e86cb8d45f80d124b/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/6c094837a0c2107d20e6902e86cb8d45f80d124b/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc
[modify] https://crrev.com/6c094837a0c2107d20e6902e86cb8d45f80d124b/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/6c094837a0c2107d20e6902e86cb8d45f80d124b/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/6c094837a0c2107d20e6902e86cb8d45f80d124b/components/autofill/core/common/autofill_features.h

Status: Fixed (was: Assigned)

Sign in to add a comment