New issue
Advanced search Search tips

Issue 881336 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 891194

Blocking:
issue 346473



Sign in to add a comment

Bookmark page should not rely on default behavior of mousemove

Project Member Reported by nzolghadr@chromium.org, Sep 6

Issue description

mousemove shouldn't have any default behavior. There was this hack in Chrome which was exposing drag'ndrop/selection prevention as default action of mousemove.

We would like to change Chrome to conform with the spec. So bookmark page needs a fix here.
 
Blocking: 346473
Blockedon: 891194
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ebfa2b597832dc94c9f3012871c5a92dd7b35b3

commit 1ebfa2b597832dc94c9f3012871c5a92dd7b35b3
Author: Christopher Lam <calamity@chromium.org>
Date: Tue Oct 09 01:37:19 2018

[MD Bookmarks] Implement drag drop chip in Views.

This CL deletes the JS implementation of the drag drop chip in the
Bookmark Manager and replaces it with a native drag. This decouples
the drag implementation from certain non-standard web drag behavior
which is getting removed.

Bug:  878392 ,  881336 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I862f2b675d371ed0a5a60fbbdbfe72a9c02cbd36
Reviewed-on: https://chromium-review.googlesource.com/c/1221166
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597767}
[modify] https://crrev.com/1ebfa2b597832dc94c9f3012871c5a92dd7b35b3/chrome/browser/browser_resources.grd
[modify] https://crrev.com/1ebfa2b597832dc94c9f3012871c5a92dd7b35b3/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
[modify] https://crrev.com/1ebfa2b597832dc94c9f3012871c5a92dd7b35b3/chrome/browser/resources/md_bookmarks/BUILD.gn
[delete] https://crrev.com/22ed4853bf2323d2a64ba07f00f9814b51afcd40/chrome/browser/resources/md_bookmarks/dnd_chip.html
[delete] https://crrev.com/22ed4853bf2323d2a64ba07f00f9814b51afcd40/chrome/browser/resources/md_bookmarks/dnd_chip.js
[modify] https://crrev.com/1ebfa2b597832dc94c9f3012871c5a92dd7b35b3/chrome/browser/resources/md_bookmarks/dnd_manager.html
[modify] https://crrev.com/1ebfa2b597832dc94c9f3012871c5a92dd7b35b3/chrome/browser/resources/md_bookmarks/dnd_manager.js
[modify] https://crrev.com/1ebfa2b597832dc94c9f3012871c5a92dd7b35b3/chrome/browser/ui/bookmarks/bookmark_browsertest.cc
[modify] https://crrev.com/1ebfa2b597832dc94c9f3012871c5a92dd7b35b3/chrome/browser/ui/bookmarks/bookmark_drag_drop.cc
[modify] https://crrev.com/1ebfa2b597832dc94c9f3012871c5a92dd7b35b3/chrome/browser/ui/bookmarks/bookmark_drag_drop.h
[modify] https://crrev.com/1ebfa2b597832dc94c9f3012871c5a92dd7b35b3/chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.cc
[modify] https://crrev.com/1ebfa2b597832dc94c9f3012871c5a92dd7b35b3/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[modify] https://crrev.com/1ebfa2b597832dc94c9f3012871c5a92dd7b35b3/chrome/common/extensions/api/bookmark_manager_private.json
[modify] https://crrev.com/1ebfa2b597832dc94c9f3012871c5a92dd7b35b3/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js
[modify] https://crrev.com/1ebfa2b597832dc94c9f3012871c5a92dd7b35b3/third_party/closure_compiler/externs/bookmark_manager_private.js
[modify] https://crrev.com/1ebfa2b597832dc94c9f3012871c5a92dd7b35b3/ui/gfx/color_palette.h

Status: Fixed (was: Assigned)

Sign in to add a comment