New issue
Advanced search Search tips

Issue 881305 link

Starred by 1 user
Status: Fixed
Owner:
mar...@chromium.org
Closed: Sep 11
Cc:
jiameng@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Issue report for SpellChecker: many incorrect "ALS" -> "also" suggestions

Project Member Reported by derat@chromium.org, Sep 6 
https://tricium-prod.appspot.com/run/5898934123757568

The Tricium spellchecker left 14 comments on every patch set of https://crrev.com/c/1209000 reporting that "ALS" (an acronym for "ambient light sensor") might be a misspelled version of "also".

Please don't offer suggestions for words that are all-caps in the middle of comments -- they're likely to be acronyms.

Comment 1 by derat@chromium.org, Sep 7

Owner: qyears...@chromium.org
Is there any way to turn the spellchecker off for a given change? It's still being super-noisy on every patch set in https://crrev.com/c/1209000.

At the very least, could it avoid leaving the same comments over and over?

Comment 2 by qyears...@chromium.org, Sep 7

Cc: -diegomtzg@google.com
Labels: -Pri-3 Pri-2
Owner: mar...@chromium.org
Status: Assigned (was: Untriaged)
Hi, sorry for the noise and thanks for the good suggestion -- there is unfortunately know way to immediately turn it off for only a specific change; the fix for this would be to modify https://cs.chromium.org/chromium/infra/go/src/infra/tricium/functions/spellchecker/spellchecker.go?l=47 and deploy 

I'm currently on parental leave, so reassigning.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fb082ce1e5f1d2c8202ae29884a14bbdd12238d9

commit fb082ce1e5f1d2c8202ae29884a14bbdd12238d9
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Mon Sep 10 22:44:42 2018

[spellchecker] add ALS as a skipped word

R=jchinlee@chromium.org

Bug:  881305 
Change-Id: Icfcff9694dd0c9fcd0ab6691a572ce9717575634
Reviewed-on: https://chromium-review.googlesource.com/1217211
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17491}
[modify] https://crrev.com/fb082ce1e5f1d2c8202ae29884a14bbdd12238d9/go/src/infra/tricium/functions/spellchecker/spellchecker.go

Comment 4 by mar...@chromium.org, Sep 11

Status: Fixed (was: Assigned)
Made infra/tricium/function/spellchecker:bbf23c41485b46cc8941384995a52b2299055e47 live

Comment 5 by mar...@chromium.org, Sep 11

Status: Assigned (was: Fixed)
Ugh, I sent a mac binary.

Comment 6 by mar...@chromium.org, Sep 11

Status: Fixed (was: Assigned)
Made 8c5e08d59d730025485154e77491137d1a81e350 live
►

Sign in to add a comment