New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 881292 link

Starred by 3 users
Status: Assigned
Owner:
mdjones@chromium.org
Cc:
█ tgu...@chromium.org
emilyschechter@chromium.org
mpear...@chromium.org
█ lzbylut@chromium.org
█ ainslie@chromium.org
mdjones@chromium.org
█ monicagv@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Task

Blocking:
issue 894211


Participants' hotlists:
Omnibox-Bugs-on-mpearson-Radar

Show other hotlists

Other hotlists containing this issue:
Hotlist-2


Sign in to add a comment

Add metrics to record how people use our UI in the omnibox focus state

Project Member Reported by maxwalker@chromium.org, Sep 6 
Additional metrics would help us to get a better sense of how people use our UI after focusing the omnibox. This would be useful when evaluating ideas for new feature (example: https://docs.google.com/presentation/d/1Hz8gsp96ebT_QT8THnmx8U9J6yHdp_aFv5w1TZ4Qn2o/edit#slide=id.p, Google internal link). 

See this PRD for background on the relevant experiment
https://docs.google.com/presentation/d/149lxhf9c_nWeHng8__E0pXZl8f8uzLrxueww5R5aS8Q/edit?usp=sharing

--
--

Requested Metrics

New user actions:
Omnibox.LongPressAndCutOrCopyURL - counts the number of times that the user long-pressed on the omnibox and tapped "Cut" or "Copy" in the resulting dropdown
Omnibox.LongPressAndShareURL - counts the number of times that the user long-pressed on the omnibox and tapped "Share" in the resulting dropdown
Omnibox.CopyURL - counts the number of times that the user tapped the "copy" icon on the first suggestion below the omnibox
Omnibox.ShareURL - counts the number of times that the user tapped the "share" icon on the first suggestion below the omnibox
Omnibox.EditURL - counts the number of times that the user tapped the "edit" icon on the first suggestion below the omnibox


New histograms:

Omnibox.TimeUntilCutCopy - This metric measures the number of milliseconds that pass between when the omnibox is focused and then user takes a Cut or Copy action. Cutting/copying the contents of the omnibox can be achieved either by tapping the "copy" icon on the first suggestion below the omnibox or by long pressing the contents of the omnibox and tapping "Cut" or "Copy." 

Omnibox.TimeUntilShare - This metric measures the number of milliseconds that pass between when the omnibox is focused and then user takes a Share action. Sharing the contents of the omnibox can be achieved either by tapping the "share" icon on the first suggestion below the omnibox or by long pressing the contents of the omnibox and tapping "Share." Note that "share" is recorded when the share sheet is shown, not necessarily when the user actually shares the URL.

Omnibx.FirstSuggestionAction - This metric counts the number of times that each of the possible actions on the first suggestion below the omnibox is used.
1 - tapped edit on first suggestion - counts the number of times that the user tapped the edit icon on the first suggestion below the omnibox
2 - tapped copy on first suggestion - counts the number of times that the user tapped the copy icon on the first suggestion below the omnibox
3 - tapped share on first suggestion - counts the number of times that the user tapped the share icon on the first suggestion below the omnibox
4 - tapped on first suggestion - counts the number of times that the user tapped the first suggestion below the omnibox thereby navigating to that suggestion

Omnibox.FocusToOpenTimeAnyPopupState3 - This metric counts the number of milliseconds between the omnibox coming into focus and the user going anywhere via the omnibox. Note that this histogram is already implemented on desktop, and we should only re-use the same histogram name if it can be implemented the same way on Android as it is currently implemented on desktop. If it can't be, we should use a new histogram name instead (Omnibox.TimeUntilEvent).

Comment 1 by isherman@chromium.org, Sep 6

Components: -Internals>Metrics>UMA
Labels: Hotlist-Metrics

Comment 2 by mpear...@chromium.org, Sep 6

Status: Available (was: Untriaged)

Comment 3 by mpear...@chromium.org, Sep 28 

I have two additional requests that might help decide on omnibox features/changes:

Omnibox.URLNavigateToSameHost
Omnibox.URLNavigateToSamePage
Omnibox.URLNavigateToRootPageOfSameHost

These all should be only recorded when the user is on an arbitrary URL (page context "OTHER") and uses the omnibox to navigate to a URL as opposed to doing a search.  The first should count using the omnibox to go to any page on the same host.  The second should, in effect, count the number of uses of the omnibox to reload the current page.  This is obviously a subset of the first. 
 The third should count the number of uses of the omnibox to go to the root page of the same host.  This too is a subset of the first.

We already have information to put these numbers in context (the number of omnibox uses on a page context "OTHER", the number of omnibox-issued queries from page context "OTHER").

Comment 4 by ew...@chromium.org, Oct 11

Blocking: 894211
Cc: tgu...@chromium.org mdjones@chromium.org monicagv@chromium.org lzbylut@chromium.org
Labels: -Pri-3 M-72 Pri-2
Owner: mdjones@chromium.org
Status: Assigned (was: Available)
Hey Lukasz and Matt, I think we need to add these metrics for our experiment to get the data we want. Marking this as blocking the launch bug, and assigning to Matt for now to take a look.

Comment 5 by mdjones@chromium.org, Oct 12 

Some clarifying questions:

- For Omnibox.Focus, we already have a histogram that tracks focus reason (Android.OmniboxFocusReason) and as a result has the count of omnibox focuses. Do we still want a separate count for this?

- It seems like there are two separate histograms we want here: one for how the omnibox is used and one for what goes into it. Is this correct or do we want all of these to be part of the same histogram?

- I'm not clear on what page context "OTHER" is, can someone clarify?

Comment 6 by mpear...@chromium.org, Oct 12 

> - For Omnibox.Focus, we already have a histogram that tracks focus reason
> (Android.OmniboxFocusReason) and as a result has the count of omnibox focuses.
> Do we still want a separate count for this?
Max and I weren't aware of that histogram.  I think it'll by fine.

> - It seems like there are two separate histograms we want here: one for how
> the omnibox is used and one for what goes into it. Is this correct or do we
> want all of these to be part of the same histogram?
I think we want both the second and third histogram listed in the original report, separately, that involve omnibox editing.  And we want three additional histograms (comment #3) that involve omnibox transitions.  Is that what you're asking?

> - I'm not clear on what page context "OTHER" is, can someone clarify?
These descriptions might help identify page "classification":
https://cs.chromium.org/chromium/src/third_party/metrics_proto/omnibox_event.proto?l=96-161
and here's where classification already happens in Android code:
https://cs.chromium.org/chromium/src/chrome/browser/android/omnibox/autocomplete_controller_android.h?q=ClassifyPage&sq=package:chromium&g=0&l=123-126

Comment 7 by lzbylut@google.com, Oct 12

Description: Show this description

Comment 8 by lzbylut@google.com, Oct 12

Description: Show this description

Comment 9 by lzbylut@google.com, Oct 15

Description: Show this description

Comment 10 by lzbylut@google.com, Oct 15

Description: Show this description

Comment 11 by lzbylut@google.com, Oct 15

Description: Show this description

Comment 12 by lzbylut@google.com, Oct 15

Description: Show this description

Comment 13 by lzbylut@google.com, Oct 15

Description: Show this description

Comment 14 by ew...@chromium.org, Oct 15 

I actually propose three histograms for the "time until copy or share." We should have one for Omnibox.TimeUntilCopyorShare (basically, how long between omnibox focus and the user *either* copying or sharing the URL), as well as Omnibox.TimeUntilCopy and Omnibox.TimeUntilShare (so we can split it out per action). Note that the buckets for each of these three histograms will be time in millis.

For the three user actions, I proposed the following names: Omnibox.EditURL, Omnibox.CopyURL, Omnibox.ShareURL. But I defer to Mark and Emily for help naming new omnibox-related user actions :)

Note that I've updated the doc here: https://docs.google.com/document/d/1PhTVbHgQ23-FNrxvO6YrPM-2EPdyVmDjDn-8PsXVxho/edit#heading=h.f0fxq14cnvhy

Comment 15 by ew...@chromium.org, Oct 15 

Also, it turns out we don't have a user action to track users long-pressing and cut/copying from the omnibox. We'll need to add something for that as well.

I'm going to update the original description with all the metrics I think we need.

Comment 16 by ew...@chromium.org, Oct 15

Description: Show this description

Comment 17 by ew...@chromium.org, Oct 15

Description: Show this description

Comment 18 by ew...@chromium.org, Oct 15 

Also, we need one more histogram for tracking the time between focusing the omnibox and going somewhere (either by navigating, picking a URL or search suggestion, typing in a search, etc.) Updating description again.

Comment 19 by ew...@chromium.org, Oct 15

Description: Show this description

Comment 20 by ew...@chromium.org, Nov 1

Description: Show this description

Comment 21 by lzbylut@google.com, Nov 7

Description: Show this description

Comment 22 by lzbylut@google.com, Nov 7

Description: Show this description

Comment 23 by lzbylut@google.com, Jan 16 (6 days ago)

Description: Show this description
Project Member

Comment 24 by bugdroid1@chromium.org, Jan 18 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d23145226322b5e580477ae63c173d2beeae587b

commit d23145226322b5e580477ae63c173d2beeae587b
Author: Matthew Jones <mdjones@chromium.org>
Date: Fri Jan 18 16:23:36 2019

Add histogram for action on first omnibox suggestion

The added histogram is for the search-ready omnibox and includes:
edit, copy, share, suggestion tap, and suggestion long-press.

Bug: 881292,901952
Change-Id: Ia12d3cb11c048215bad43c8752aa3afae5b5b15a
Reviewed-on: https://chromium-review.googlesource.com/c/1372560
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624151}
[modify] https://crrev.com/d23145226322b5e580477ae63c173d2beeae587b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/editurl/EditUrlSuggestionProcessor.java
[modify] https://crrev.com/d23145226322b5e580477ae63c173d2beeae587b/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/d23145226322b5e580477ae63c173d2beeae587b/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment