New issue
Advanced search Search tips

Issue 881290 link

Starred by 2 users
Status: Fixed
Owner:
aee@chromium.org
Closed: Oct 2
Cc:
ajha@chromium.org
malaykeshav@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unable to recognize White dots in 'Display Size' sidebar of chrome://settings/display page

Project Member Reported by mmanchala@chromium.org, Sep 6 
Chrome Version: 69.0.3497.82/10895.47.0 beta-channel Kip,Daisy,Celes
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Now go to chrome://settings/display page
(2)At 'Internal Display' observe 'Display Size' sidebar points
i.e. unable to recognize the points as they are in white color
(Please refer Video and Screenshot)

Expected: White dots should be visible
Actual: Instead unable to recognize

This is Regression Issue as same is working fine in M-68
Actual_DisplaySlider.mp4
14.1 MB View Download
Actual_DisplaySlider.jpg
499 KB View Download
Expected_DisplaySlidebar.jpg
84.4 KB View Download
Expected_DisplaySlidebar.webm
650 KB View Download

Comment 1 by steve...@chromium.org, Sep 6

Cc: aee@chromium.org
Owner: malaykeshav@chromium.org
Status: Assigned (was: Untriaged)
Possible side effect of https://chromium-review.googlesource.com/1181929 ?

Comment 2 by aee@chromium.org, Sep 6

Cc: -aee@chromium.org malaykeshav@chromium.org
Owner: aee@chromium.org
Status: Started (was: Assigned)
Right, this is due to the changes made to the slider styling. I can take this.

Screenshot for CL https://chromium-review.googlesource.com/c/chromium/src/+/1211805.
inactive_markers.png
5.5 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53ecd726c6d4420c25c295c3fafe95fb321f27fa

commit 53ecd726c6d4420c25c295c3fafe95fb321f27fa
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Fri Sep 28 21:58:06 2018

WebUI: cr-slider, differentiate between markers in active and inactive regions

 - Remove paper-slider dependency.
 - Differentiate active/inactive markers based on knob position.
 - Add label support from display-size-slider.
 - Replace display-size-slider with settings-slider.

Bug:  881290 ,  858882 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ib0863f37f5484f146d7cd944af4fe9a13a35ea0a
Reviewed-on: https://chromium-review.googlesource.com/1211805
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595228}
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/chrome/browser/resources/settings/a11y_page/BUILD.gn
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/chrome/browser/resources/settings/a11y_page/tts_subpage.html
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/chrome/browser/resources/settings/a11y_page/tts_subpage.js
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/chrome/browser/resources/settings/controls/settings_slider.html
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/chrome/browser/resources/settings/controls/settings_slider.js
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/chrome/browser/resources/settings/device_page/BUILD.gn
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/chrome/browser/resources/settings/device_page/display.js
[delete] https://crrev.com/7e8253c958ca8f5105d09468a45155ee8a3053c7/chrome/browser/resources/settings/device_page/display_size_slider.html
[delete] https://crrev.com/7e8253c958ca8f5105d09468a45155ee8a3053c7/chrome/browser/resources/settings/device_page/display_size_slider.js
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/chrome/browser/resources/settings/device_page/keyboard.html
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/chrome/browser/resources/settings/device_page/pointers.html
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/chrome/test/data/webui/cr_elements/cr_slider_test.js
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/chrome/test/data/webui/settings/device_page_tests.js
[delete] https://crrev.com/7e8253c958ca8f5105d09468a45155ee8a3053c7/chrome/test/data/webui/settings/display_size_slider_test.js
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/chrome/test/data/webui/settings/settings_slider_tests.js
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/testing/buildbot/filters/webui_polymer2_browser_tests.filter
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/ui/webui/resources/cr_elements/cr_slider/BUILD.gn
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/ui/webui/resources/cr_elements/cr_slider/cr_slider.html
[modify] https://crrev.com/53ecd726c6d4420c25c295c3fafe95fb321f27fa/ui/webui/resources/cr_elements/cr_slider/cr_slider.js
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72b55d78eb5058093ad987920468c4823614468c

commit 72b55d78eb5058093ad987920468c4823614468c
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Sat Sep 29 00:35:50 2018

Settings: night-light-slider, active/inactive markers and improved focus styling

Also fixing an issue with the position of a knob when tracking.

Bug:  881290 
Change-Id: Ib3520d4c89d7a9f5ac4575b47976e4ceb14131f3
Reviewed-on: https://chromium-review.googlesource.com/1228980
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595270}
[modify] https://crrev.com/72b55d78eb5058093ad987920468c4823614468c/chrome/browser/resources/settings/device_page/BUILD.gn
[modify] https://crrev.com/72b55d78eb5058093ad987920468c4823614468c/chrome/browser/resources/settings/device_page/night_light_slider.html
[modify] https://crrev.com/72b55d78eb5058093ad987920468c4823614468c/chrome/browser/resources/settings/device_page/night_light_slider.js

Comment 5 by aee@chromium.org, Oct 2

Status: Fixed (was: Started)
►

Sign in to add a comment