Regression: [NTP] Continuation dots(...) are seen instead shortcut names on increasing 'Minimum font size' to huge.
Reported by
db...@etouch.net,
Sep 6
|
|||||||
Issue descriptionChrome Version: 70.0.3538.9 (Official Build) Revision bbaf922671f0864634145724488000061f98a1a3-refs/branch-heads/3538@{#72}(32/64 bit) OS: Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.14, 10.13.6) and Linux(14.04 LTs) Pre-condition:Enable flags from chrome://flags -Enable using the Google local NTP -New Tab Page Background Selection -New Tab Page Custom Links Steps to reproduce: 1. Launch chrome, open NTP and navigate to chrome://settings 2. Click on 'Customize fonts' and increase 'Minimum font size' to huge 3. Reload NTP and observe. Actual Result : Continuation dots(...) are seen instead of shortcut names on increasing 'Minimum font size' to huge. Expected Result: Shortcut names should be seen on increasing 'Minimum font size' to huge This is a regression issue broken in ‘M-69’ and below is the per revision bisect info. Good build: 69.0.3496.0(Revision:576217) Bad build : 69.0.3497.0(Revision:576753) You are probably looking for a change made after 576440 (known good), but no later than 576441 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/47da18a50453d80541624e9aca4dffb5447d91d5..18681eba7e1f41c5ff5ead420bddb52d9e4e53d5 Suspect:https://chromium.googlesource.com/chromium/src/+/18681eba7e1f41c5ff5ead420bddb52d9e4e53d5 @kristipark: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Kindly refer attached screencast.
,
Sep 11
Updating the target release to M71, since I don't think this can be merged before Beta promotion on 9/13.
,
Sep 11
,
Sep 28
Can you take a look at this Weilun? This is an opportunity to remove the custom truncateTitleText code we have in most_visited_single.js and use ElideRectangleText in StringSlicer instead. https://cs.chromium.org/chromium/src/ui/gfx/text_elider.h?type=cs&l=137 Will probably be placed in GenerateMostVisitedItemData. https://cs.chromium.org/chromium/src/chrome/renderer/searchbox/searchbox_extension.cc?type=cs&l=137
,
Oct 1
,
Oct 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b325fca782577596ac29bb75e540cbc9515ef953 commit b325fca782577596ac29bb75e540cbc9515ef953 Author: Weilun Shi <sweilun@chromium.org> Date: Mon Oct 01 22:12:40 2018 [NTP] Change height limit for the truncateTitleText function Change the height limit for truncateTitleText function to 24 according to the largest minimum font size in the setting. Screencast: https://screencast.googleplex.com/cast/NTY0Mzc2NjE5OTIyMjI3MnxlNDZjMjRlZi0yMA Bug: 881288 Change-Id: I1f9a6e60269acbe1756f22911410f85b29249e03 Reviewed-on: https://chromium-review.googlesource.com/1255602 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#595571} [modify] https://crrev.com/b325fca782577596ac29bb75e540cbc9515ef953/chrome/browser/resources/local_ntp/most_visited_single.js
,
Oct 1
,
Oct 3
Update: Rechecked above issue and it is fixed on latest canary build #71.0.3569.0 using Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.14, 10.13.6) and Linux(14.04 LTs) OS. Thank you. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by kristip...@chromium.org
, Sep 6