Pressing tab focuses elements in wrong order
Reported by
orsch...@gmail.com,
Sep 6
|
||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36 Steps to reproduce the problem: 1. Download any file to ensure that the download bar is shown at the bottom of the screen 2. Go to https://www.google.com 3. Press Ctrl + l to put focus on the URL bar 4. Press Tab once What is the expected behavior? I expect the browser to put focus on the page because it is the second element in order (looking from top to bottom). What went wrong? Instead, focus is given to the button shown at the far right of the download bar. This button should be focused after pressing tab twice because it's far at the bottom of the entire user interface. It's not following the correct order. Pressing tab at the moment, you jump from the top (the url bar) to the bottom (the download bar) and then back to the page (the middle part) I am attaching a screenshot that further illustrates the issue. Did this work before? N/A Chrome version: 68.0.3440.106 Channel: stable OS Version: Fedora 28 Flash Version: Thank you for your attention to this!
,
Sep 6
,
Sep 7
,
Sep 7
+jamescook
,
Sep 7
I wonder if it used to work because of the explicit view indices in https://chromiumcodereview.appspot.com/12631010/diff/2016/chrome/browser/ui/views/frame/browser_view.cc?context=10&column_width=80&tab_spaces=8 It's been 5+ years since I landed that CL, though. I wouldn't be surprised if recent top-chrome changes could affect this behavior.
,
Sep 13
jamescook@ do you know who the owners of top-chrome are?
,
Sep 13
robliao, who owns top-chrome these days?
,
Sep 13
Adding dfried@ for this issue.
,
Sep 13
,
Sep 14
,
Sep 14
Verified for Windows as well.
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad06a605ed9819946c82eaff760c4406387fe240 commit ad06a605ed9819946c82eaff760c4406387fe240 Author: Dana Fried <dfried@chromium.org> Date: Mon Sep 17 21:05:12 2018 Change child order in BrowserView to fix tab-order issue. Bug: 881287 Change-Id: I8378fa4c5a77e32a72c957aa5d2d8da564f18ce8 Reviewed-on: https://chromium-review.googlesource.com/1227478 Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#591812} [modify] https://crrev.com/ad06a605ed9819946c82eaff760c4406387fe240/chrome/browser/ui/views/frame/browser_view.cc
,
Sep 17
Should be addressed. Please review to determine if this fix did what was intended.
,
Sep 17
Thank you so much for addressing this issue! This will feed into which Chromium release?
,
Sep 18
re 14: In Windows/MacOS Chrome Canary 71.0.3555.0 and newer. In Linux you can test a snapshot newer than 591812 from https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html
,
Sep 18
Verified the fix on Windows-10 and Ubuntu 17.10 using Chrome version #71.0.3555.0 as per the comment #1. Attaching screen cast for reference. Observed that browser put focus on the text field because it is the second element in order. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version with out fix. Thanks...!! |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by woxxom@gmail.com
, Sep 6481 bytes
481 bytes View Download