Verify that history backend expires remote entities |
|||||||
Issue descriptionWe should make sure that the history backend expires remote entities as well as local entities to verify we're not accidentally keeping those on clients.
,
Sep 6
Yes, and yes you're right, this is not related to Butter, and this should probably be verified before M72 anyways. I removed this from the hotlist.
,
Sep 17
triage ping: jkrcal@ you lazy lizard, where is the progress!?
,
Sep 24
jkrcal@: re-ping! Is this really a P1?
,
Sep 24
No, I think it is more like a P2. I am too busy until M71 BP to treat it like a P1.
,
Nov 16
,
Nov 20
It works both (a) by analyzing the code and (b) empirically for my personal profile where the oldest synced visit is 82 days old (the threshold is 90 days and I was on an offline vacation around the expiration threshold).
,
Nov 21
Re-opening to write an integration test for this behavior.
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8ce1ab04149b23757a13a1d9a983bdf926a16dd commit e8ce1ab04149b23757a13a1d9a983bdf926a16dd Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Nov 21 16:02:55 2018 [Typed URL Sync] Test that typed URLs coming from sync get expired This CL adds a missing integration test that typed url sync properly stores remote typed URLs and their visits so that they expire along with local typed URLs. Bug: 881285 Change-Id: I17f97c80bb4f281cc0ecd2576c81ef94a5dc0235 Reviewed-on: https://chromium-review.googlesource.com/c/1346459 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#610086} [modify] https://crrev.com/e8ce1ab04149b23757a13a1d9a983bdf926a16dd/chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc
,
Nov 21
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by treib@chromium.org
, Sep 6