New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 881275 link

Starred by 1 user
Status: Assigned
Owner:
maxmorin@chromium.org
Cc:
guidou@chromium.org
ossu@chromium.org
█ olka@chromium.org
maxmorin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rewrite MediaStreamAudioProcessor::InitializeCaptureFifo to support appropriate output parameters.

Project Member Reported by ar...@chromium.org, Sep 6 
Quoting the TODO in the source:

"For now, we assume fixed parameters for the output when audio
processing is enabled, to match the previous behavior. We should either 
use the input parameters (in which case, audio processing will convert  
at output) or ideally, have a backchannel from the sink to know what    
format it would prefer."

This is located under MediaStreamAudioProcessor::InitializeCaptureFifo in media_stream_audio_processor.cc.

Comment 1 by maxmorin@chromium.org, Sep 6

Cc: ossu@chromium.org
This sounds a lot like what Oskar and I was talking about earlier this week.

Comment 2 by ossu@chromium.org, Sep 6 

IIUC, the idea of a backchannel may be misguided, as a single stream could potentially be used by several different sinks. To my mind, this TODO should get "fixed" by us removing the old MediaStreamAudioProcessor once the new code using the APM in the audio service is fully evaluated.

Comment 3 by henrika@chromium.org, Sep 7

Cc: -ajm@chromium.org
Please assign a suitable owner to ensure that this issue does not show up in our filter for unassigned tasks.

Comment 4 by maxmorin@chromium.org, Sep 11

Owner: maxmorin@chromium.org
Status: Assigned (was: Untriaged)
►

Sign in to add a comment